Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: T8ZHtw35GvdI14dp48hyA31a631K2YYSNRnpJO8Ms1faCTviPtD/W7bxD4N6dM6/5wQX546+Rh
 xbJBhb/7A6Tg==
IronPort-SDR: vz7kfNqPAzOP9Ja+liVBuA7NBVbHoPStgbItBpDF7drpSr0G0tkUuRn2+T1KFZoMIIWAB0FdGF
 PH51FTVD7Vnw==
Date:   Wed, 1 Jul 2020 09:00:46 -0700
From:   Ben Widawsky <ben.widawsky@intel.com>
To:     Dave Hansen <dave.hansen@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org,
        cl@linux.com, akpm@linux-foundation.org, ying.huang@intel.com,
        dan.j.williams@intel.com, cai@lca.pw
Subject: Re: [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl
 ABI
Message-ID: <20200701160046.kvhsq43adcw46fbq@intel.com>
Mail-Followup-To: Dave Hansen <dave.hansen@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org,
        cl@linux.com, akpm@linux-foundation.org, ying.huang@intel.com,
        dan.j.williams@intel.com, cai@lca.pw
References: <20200701152621.D520E62B@viggo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200701152621.D520E62B@viggo.jf.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20-07-01 08:26:21, Dave Hansen wrote:
> A previous cleanup accidentally changed the vm.zone_reclaim_mode ABI.
> 
> This series restores the ABI and then reorganizes the code to make
> the ABI more obvious.  Since the single-patch v1[1], I've:
> 
>  * Restored the RECLAIM_ZONE naming, comment and Documentation now
>    that the implicit checks for it are known.
>  * Move RECLAIM_* definitions to a uapi header
>  * Add a node_reclaim_enabled() helper
> 
>  Documentation/admin-guide/sysctl/vm.rst |   10 +++++-----
>  include/linux/swap.h                    |    7 +++++++
>  include/uapi/linux/mempolicy.h          |    7 +++++++
>  mm/khugepaged.c                         |    2 +-
>  mm/page_alloc.c                         |    2 +-
>  mm/vmscan.c                             |    3 ---
>  6 files changed, 21 insertions(+), 10 deletions(-)
> 
> 1. https://lore.kernel.org/linux-mm/20200626003459.D8E015CA@viggo.jf.intel.com/
> 
> Cc: Ben Widawsky <ben.widawsky@intel.com>
> Cc: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Daniel Wagner <dwagner@suse.de>
> Cc: "Tobin C. Harding" <tobin@kernel.org>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Qian Cai <cai@lca.pw>
> Cc: Daniel Wagner <dwagner@suse.de>

Series is:
Reviewed-by: Ben Widawsky <ben.widawsky@intel.com>

I was more thorough this time in checking all uses of node_reclaim_mode :-). I
do think in patch 2/3, using an enum would be a little better, which I've
mentioned there.