Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 1 Jul 2020 18:17:13 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc:     pali@kernel.org, robh@kernel.org, afd@ti.com, dmurphy@ti.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, sspatil@android.com
Subject: Re: [EXTERNAL] Re: [PATCH v14 4/4] power: supply: bq25150 introduce
 the bq25150
Message-ID: <20200701161713.f67htedosevy4oyp@earth.universe>
References: <20200630215426.26450-1-r-rivera-matos@ti.com>
 <20200630215426.26450-5-r-rivera-matos@ti.com>
 <20200630233341.d5ztfv5rcbhjxi4r@earth.universe>
 <b22f4eed-6baf-604e-0953-d427407c904e@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b22f4eed-6baf-604e-0953-d427407c904e@ti.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Tue, Jun 30, 2020 at 11:17:30PM -0500, Ricardo Rivera-Matos wrote:
> [...]
> > > +static int bq2515x_battery_set_property(struct power_supply *psy,
> > > +		enum power_supply_property prop,
> > > +		const union power_supply_propval *val)
> > > +{
> > > +	struct bq2515x_device *bq2515x = power_supply_get_drvdata(psy);
> > > +	int ret;
> > > +
> > > +	switch (prop) {
> > > +	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
> > > +		ret = bq2515x_set_batt_reg(bq2515x, val->intval);
> > > +		break;
> > > +	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
> > > +		ret = bq2515x_set_const_charge_current(bq2515x, val->intval);
> > > +		break;
> > > +	case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
> > > +		ret = bq2515x_set_precharge_current(bq2515x, val->intval);
> > > +		break;
> > > +	default:
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	return ret;
> > > +}
> > Expose those through the charger device. The battery device
> > can expose maximum data (e.g. POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX),
> > but should not control the charging itself.
> ACK. Just to confirm this would eliminate the need for the
> bq2515x_battery_set_property altogether as these three properties should be
> set in the charger device. There will only be a bq2515x_battery_get_property
> to report the CONSTANT_CHARGE_VOLTAGE_MAX and CONSTANT_CHARGE_CURRENT_MAX
> values captured from the devicetree.

Right.

-- Sebastian