Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp784876ybt; Wed, 1 Jul 2020 09:55:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhEGO2VQD7a58o4QNU+Gw4c+7NTKMjv7D0FqS0VGe/nXB7WTWjR4Yc2e8LUPjxKqg3SNXA X-Received: by 2002:a50:da83:: with SMTP id q3mr31202476edj.325.1593622510087; Wed, 01 Jul 2020 09:55:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593622510; cv=none; d=google.com; s=arc-20160816; b=HwlZtCLBAELsHP4K08dZYeAqF4tDw3QgY/9vdvvfv2yiycJYlB+v2r8mhjbpeDQQ5b qbuQIFpgl167oszVFZXPLeVA06u23oR6h2gK1N2CX0yK/8j5RgOFgT2CwHLEBKySoCeF /QHr8X7UnoMo1ue7ztkQ6oYnjVISrx8aj1GTxgt39sM3by/Tb+/8H0ASDVRrotjDOScM YevJL9u4DaNK4xmoGSufDJl5s7pa5VumuLTLxql2jv7kYeu1feaqFlOGCA3uQUG5snot y0mpfjfXe05ySwcjlrBH1tR9SA+OvLe1n94ptOaUqZUY2dFRDez8JGrwiLSkaIjPSSpp YFew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=W4aGIA2sVJUTFvh2lVc0/GV3kZcbHmAaStG8roUdCNw=; b=zIZbi5pOzfYgBvN5vBJh+oUM2Nkn4l9HFgo+YDo9yxmxDdQgEMrVgnuj16O72p7O2W JvxN8aCS/XW/RZGERfs9KrjISM1fJq3AcQ79rp+ZvnPeA9SEtTffqZy4slWq0UqagBe0 lTFjeNq/cAK8ndg3JbvylHY0ovBDnmJgQaQykAuRfxW5l074KVnmC38omhBv40cnzdwS q8FfIyFhyoq2IkUiRfWQu9E4jfRXJxcLXhafRIn/h7beIZPV1VGLGYA9oTvhX83VTV+S 60QQdngq7KSuPTq/S9bw3QE2qIHQi7Pe9WDyRuKbuBWEfOmEi1VBWRv6bY1rr/aBqCb9 nFBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c22si4280326edx.584.2020.07.01.09.54.46; Wed, 01 Jul 2020 09:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732736AbgGAQxq (ORCPT + 99 others); Wed, 1 Jul 2020 12:53:46 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35638 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732376AbgGAQxo (ORCPT ); Wed, 1 Jul 2020 12:53:44 -0400 Received: by mail-wr1-f66.google.com with SMTP id z2so2556407wrp.2; Wed, 01 Jul 2020 09:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=W4aGIA2sVJUTFvh2lVc0/GV3kZcbHmAaStG8roUdCNw=; b=gIrprbonIy7G7RMYu/VoAhSVIYYfOEP67ud/4mRHrbK1r4VScHIPT8STviwrB4D7f8 q29TzkF1sx5IWkB9esI5lATDeFyJijcIyDvhprWshxFKwURC2iKD4xP5wVpk0dla4PRw tejf0L4GOs6rhCM7Prxib05+270pzwp4v+hPHAcBsixD8lMcUyE465ASvtU8SDwoLY00 2cqKqAqKWvwCMYB76DjH/udHBaVNT80bYX2n4MeOEzC81UJJC6m6X0vxXlLpeU7/AVFw cz3o+fYlfm21GeyZZxBSZN4dkQJ+giRonaHnfoXeVEg/SOoFWtTge8ODLDt7JfD4BOlw y4rA== X-Gm-Message-State: AOAM533/HdQz1PTMu4YMcj788w80Sy3wZWFqwHTuOYhI/vW8kC28UnHQ tnEIG4rIn/NHwjLyU0sSXGE= X-Received: by 2002:a5d:458a:: with SMTP id p10mr27066648wrq.184.1593622421731; Wed, 01 Jul 2020 09:53:41 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id n14sm8290457wro.81.2020.07.01.09.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 09:53:41 -0700 (PDT) Date: Wed, 1 Jul 2020 16:53:39 +0000 From: Wei Liu To: t-mabelt@microsoft.com Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com, parri.andrea@gmail.com, Andres Beltran , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH v4 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Message-ID: <20200701165339.chtxkixnkocnjw5u@liuwe-devbox-debian-v2> References: <20200701001221.2540-1-lkmlabelt@gmail.com> <20200701001221.2540-3-lkmlabelt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701001221.2540-3-lkmlabelt@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2020 at 08:12:20PM -0400, Andres Beltran wrote: > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in storvsc. In the face of errors or malicious > behavior in Hyper-V, storvsc should not expose or trust the transaction > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > use small integers generated by vmbus_requestor as requests > (transaction) IDs. > > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: linux-scsi@vger.kernel.org James and Martin, FYI I'm going to take this patch via hyperv tree because it depends on the first patch. Wei.