Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp790748ybt; Wed, 1 Jul 2020 10:03:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjt4vGswVx2AQw0IrLwhq0siwReCj4mijRfngU7Np/B0TX2011Bdht4bexENsfWCreoOx2 X-Received: by 2002:a17:906:c35a:: with SMTP id ci26mr8461987ejb.451.1593623008390; Wed, 01 Jul 2020 10:03:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1593623008; cv=pass; d=google.com; s=arc-20160816; b=t/gKlnKB/qFyJxq7duzy26PwppEEfzO65hXJRZE5y/5kor5kIXcS3aJiOsL/xTYo5Y 2U+X8jPioSYwOgYMVLYHZLhfoWe4GBSJ9BAjCxOjF4SJVMRRTGmxJAJhAmgNjAtbnTEv +9W1WwrpG4eWJODDO3wSQHuvb4vep+U5XDZbZxdTudoo0WraBWk5KXqqWs15zkGa1wOp L/ctIMt69x1Q5eTqz3SfXZCs9TRE5kpPxNLZ+1+DpS/jV/JhHvwZAaFWpNRGtApuWw+W K9cAbhyqQBp4HRawdC/JSg2zUq4YXbZI5/HtJuWw7kBObbqvs5gmbC1NC0muKP08yzaY zqww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:to:from:dkim-signature:ironport-sdr :ironport-sdr; bh=DkEAiHeLJlbY5klKeL2dvR2MSxTlw+/jstegdvdt7jE=; b=LnB1oEc1jDrd8DRHSj3jC5PJ2chUF9tpkijvRb2qXc5aptIv770xGebj+6PZIqvFEI ZpsT2erNpJiSuRTKBOt1CUyJogER5Yd3bbcvMUpwb6nXOUoWq3RDn8AuqUKLL8f1dkTw FSbadhnDaLOlWlAKA28WHf/i7Mdh11iiN8e5CotPbV0FXcyb2lVeZZfgQtImZA/CUdtU r/c89eZKUfaToVgdiwIMSP+ETJmACICYOupAjx4bdoJRPP1ZhMeTbHxn5aNBVoKy1bkL 94mKE1IfoUhMfZxiRqoNZl6l24UA3nVbjezGD8mcOU2hKDa0ypVWgbEXlYsw+DAdSM42 a3Wg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b="NM4i/SDL"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me7si4184768ejb.716.2020.07.01.10.03.03; Wed, 01 Jul 2020 10:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b="NM4i/SDL"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732597AbgGARCP (ORCPT + 99 others); Wed, 1 Jul 2020 13:02:15 -0400 Received: from mga06.intel.com ([134.134.136.31]:24876 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732207AbgGARCO (ORCPT ); Wed, 1 Jul 2020 13:02:14 -0400 IronPort-SDR: TZxofemwKmxNJy5CQwg/I6IKv3/ePmUSvwooc5Z7S1k9jVWN36rWr0XqL0ixHemDQQiwhe9844 XM/XYy5DnJ/w== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="208160563" X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="208160563" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 10:02:13 -0700 IronPort-SDR: P/gUF/WjPLOVm0OEYaRJFRF8O/Ul87zuKf7V4AFAHbg2jYy528znqX2hTwSgy0b99CWgcB8yjC KiwJdO/7/5ug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="481666006" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 01 Jul 2020 10:02:13 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:02:13 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jul 2020 10:01:40 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 1 Jul 2020 10:01:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:01:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AhVus4vaSuC25gWn02aHNEMSA+kYbtj2UiI8Gl6XA62MHesFMF/VEWqdrOH6Z8K/pr1xQMtSZGC530SQN3fLJYVqxbaEqrt0Bw5nTTMp5f/CS/gIubXQaupBa/xlesSVM8dLbiU1ksCShMImEcwq2JrpUAEpWSGdqFOeuIlWAiMBNghMA+q/DBU8MHK5lv7Jc4hM/k02/aNgonPBt/2IItR/PUI5AyAre3PQcGcHd/fDZUd/agm7uGmNkIFeuZ0w0XX3bVx0fhEdSp6N0JJt7AVKyJZy2IBmE0k9vyHWDBPZIOU0q+/G/dl88KJHsMG8ZOlL1skpkX5zCqXnzU7f6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkEAiHeLJlbY5klKeL2dvR2MSxTlw+/jstegdvdt7jE=; b=ImYiyfDk4s+RMjRp4dEjT2VyV6dKMxlDPLJGyyYecjkDY9ntA1nt7fbskViytGs11wo935cGIqT3CK2dmL3HTg07jkn+GnobfZeCW94cNmLZMvtCLIXsA+/UyUKNm9jwuwZpBMVk1q3DaiOISf/LPtrT/NKBKX781+WjHNqVOuCc9VLaoFMVE6gOwtC3U8h8nqooQgzPM6bpHgIfULa6GUfY3H1KbUJR57cUOOnlhDlxBzMN3obxpvPK3Fr4MWW/P/zX8vlCUpz6JYkwfdqePDJnXee4KAQxBP/1L+ZmS/0k8pkRmGJMZevmNqfpNhNXRuu0DuOWwso2RJ0kNv/qmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkEAiHeLJlbY5klKeL2dvR2MSxTlw+/jstegdvdt7jE=; b=NM4i/SDL4XZtjhyyLDAqIKxiS5PjXiy0SffnGiJCnD0Z7ikLnCMSBkAFIpqYA+J1KEv2GPmLXtuWJwB+gxS8j9pisAzRHwSegjFB6a12g8EOfGIxLdqyvMv3OBvHETx5pmhFA5J+79awXfNEF43MQPwxYavdBEPBEiNE1VihROI= Received: from BN6PR1101MB2145.namprd11.prod.outlook.com (2603:10b6:405:51::10) by BN8PR11MB3698.namprd11.prod.outlook.com (2603:10b6:408:8a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Wed, 1 Jul 2020 17:01:38 +0000 Received: from BN6PR1101MB2145.namprd11.prod.outlook.com ([fe80::c908:e244:e85:3362]) by BN6PR1101MB2145.namprd11.prod.outlook.com ([fe80::c908:e244:e85:3362%9]) with mapi id 15.20.3131.028; Wed, 1 Jul 2020 17:01:38 +0000 From: "Bowers, AndrewX" To: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Subject: RE: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power management Thread-Topic: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power management Thread-Index: AQHWTfgoV7BQ5dw9h02yqMo36TI3eqjy9mvg Date: Wed, 1 Jul 2020 17:01:38 +0000 Message-ID: References: <20200629092943.227910-1-vaibhavgupta40@gmail.com> <20200629092943.227910-5-vaibhavgupta40@gmail.com> In-Reply-To: <20200629092943.227910-5-vaibhavgupta40@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8790c588-59ca-4ab8-4fc6-08d81de06ba4 x-ms-traffictypediagnostic: BN8PR11MB3698: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9yyanhEKvgthTP7ax5kmjTM8sD5+RSMIElr3in5vMbNnVvscrEhsCuYIgJB7aBGca3m8tq42kZ0x0aMAZhZhd93nKS5JQPMznmHBNJyzXIihPA2EEmJ3MDmwFYj+nSKVy0LAfZwDmTD9dPUWlK8AAyfABJV/+b1ORbBYmSFiK6l2498R3iADcdZIDRgpZOPsWxNIFZLrAlXN9gle7TIErJgWw9UrizzgrwyyI1FwwGdvfOCjY3y+drE6REUlOze1omeBQifCqbYPofmojGjNE/7vss3hM5Cod/8kQeEs1vi2FrPBjSgmPws2NYpH4EBkccgqQ/mzhMTLj174q+rD+ciOlG0j9iSYbifX9ZZE5KRvqahH9dYQgnu4vinQb6tY x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1101MB2145.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(8936002)(6506007)(26005)(5660300002)(186003)(110136005)(64756008)(83380400001)(66476007)(71200400001)(7696005)(66556008)(76116006)(66446008)(53546011)(66946007)(55016002)(2906002)(33656002)(9686003)(8676002)(52536014)(86362001)(498600001)(41533002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: b+ANWuJztmPmG2/hyCePSVx8ytEgCXgHa1iA+5enMrXAEyhlUpqe6rqMgiMiuDJ2xTaOUqageSOUrmutFJlh9g41YMs+xEdLO85on4SK63Gjp5UIk0vhBXl/rYmAMGSE5sgGsp7iQCXk+eUlSY5B8ykLk0NWMsiJyRE3tysZsHi9MFAkmYih0Hoo56A+2bLOwifuCwq9FurqX69vnxvbhMLsdKZ7Nb2Hvjl9b8utVY2do7DUKHzDcrrVecM1pVaZDsRsJbit5aIvIMbhpp93upQT4rSlPmuogRjIJDF6dwb8f/gLYfFFdnnhGV12LE+QgW3BFnkEUhs9ZGrQlWIPbe6NIgFnwvxWCaXfNPbUA6JAHM4C5mfOUt9OV4MAoLc5Y9AmNyEs+XMKF4EPE996wYNuffkhYrToLkjVeLi9seivaIK6enG6Zb8xXIQ/RDVMeAjQxlghjOuv8m8YXzrkSEgMfjQcfbqP0BqRCYT+Wv4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2145.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8790c588-59ca-4ab8-4fc6-08d81de06ba4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 17:01:38.7196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jhkyJ+l/6Vw5u71/AL1NCO3x+6SJsUX5eViDcLUDj8dZBg7ClbpLlqbL7qXf4gxnnGKc6PKQ/Q5bTTaWmR8KtSUVrKgO+C5IF27+t1hhWv0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3698 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan On Behalf Of > Vaibhav Gupta > Sent: Monday, June 29, 2020 2:30 AM > To: Bjorn Helgaas ; Bjorn Helgaas > ; bjorn@helgaas.com; Vaibhav Gupta > ; David S. Miller ; > Jakub Kicinski ; Kirsher, Jeffrey T > > Cc: Vaibhav Gupta ; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; > skhan@linuxfoundation.org; linux-kernel- > mentees@lists.linuxfoundation.org > Subject: [Intel-wired-lan] [PATCH v1 4/5] ixgbevf: use generic power > management >=20 > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. >=20 > After upgrading to the generic structure, PCI core will take care of requ= ired > tasks and drivers should do only device-specific operations. >=20 > The driver was invoking PCI helper functions like pci_save/restore_state(= ), > and pci_enable/disable_device(), which is not recommended. >=20 > Compile-tested only. >=20 > Signed-off-by: Vaibhav Gupta > --- > .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 44 +++++-------------- > 1 file changed, 10 insertions(+), 34 deletions(-) Tested-by: Andrew Bowers