Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
AI-Spam-Status: Not processed
Date:   Wed, 01 Jul 2020 20:01:14 +0800
User-Agent: K-9 Mail for Android
In-Reply-To: <20200701103126.1512615-14-megous@megous.com>
References: <20200701103126.1512615-1-megous@megous.com> <20200701103126.1512615-14-megous@megous.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support
To:     Ondrej Jirman <megous@megous.com>, linux-sunxi@googlegroups.com,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        =?ISO-8859-1?Q?Guido_G=FCnther?= <agx@sigxcpu.org>,
        Purism Kernel Team <kernel@puri.sm>,
        Rob Herring <robh+dt@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Linus Walleij <linus.walleij@linaro.org>
CC:     dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Samuel Holland <samuel@sholland.org>,
        Martijn Braam <martijn@brixit.nl>, Luca Weiss <luca@z3ntu.xyz>,
        Bhushan Shah <bshah@kde.org>
From:   Icenowy Zheng <icenowy@aosc.io>
Message-ID: <78C72279-99DB-4FDE-81B3-1CF6BEF80BBF@aosc.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B47=E6=9C=881=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=886:=
31:26, Ondrej Jirman <megous@megous=2Ecom> =E5=86=99=E5=88=B0:
>Pinephone has a Goodix GT917S capacitive touchscreen controller on
>I2C0 bus=2E Add support for it=2E
>
>Signed-off-by: Ondrej Jirman <megous@megous=2Ecom>
>Acked-by: Linus Walleij <linus=2Ewalleij@linaro=2Eorg>
>---
> =2E=2E=2E/dts/allwinner/sun50i-a64-pinephone=2Edtsi   | 19 +++++++++++++=
++++++
> 1 file changed, 19 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone=2Edtsi
>b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone=2Edtsi
>index 85a7aa5efd32=2E=2E2d5694446d17 100644
>--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone=2Edtsi
>+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone=2Edtsi
>@@ -123,6 +123,25 @@ &ehci1 {
> 	status =3D "okay";
> };
>=20
>+&i2c0 {
>+	pinctrl-names =3D "default";
>+	pinctrl-0 =3D <&i2c0_pins>;
>+	status =3D "okay";
>+
>+	touchscreen@5d {
>+		compatible =3D "goodix,gt917s", "goodix,gt911";

Please drop gt911 here=2E GT917S belong to the GT1x product line, not the =
same line with GT911=2E

You will see this in the driver=2E

>+		reg =3D <0x5d>;
>+		interrupt-parent =3D <&pio>;
>+		interrupts =3D <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */
>+		irq-gpios =3D <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
>+		reset-gpios =3D <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
>+		AVDD28-supply =3D <&reg_ldo_io0>;
>+		VDDIO-supply =3D <&reg_ldo_io0>;
>+		touchscreen-size-x =3D <720>;
>+		touchscreen-size-y =3D <1440>;
>+	};
>+};
>+
> &i2c1 {
> 	status =3D "okay";
>=20