Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp826097ybt; Wed, 1 Jul 2020 10:58:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0mik5wRZfjrCRWwx2qI65Uyi3142gUdK/2QExYC7bV4QPkLZAqIlg19HXV0VG8O/jCB0z X-Received: by 2002:a50:a207:: with SMTP id 7mr31170347edl.92.1593626302853; Wed, 01 Jul 2020 10:58:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593626302; cv=none; d=google.com; s=arc-20160816; b=irwDNaveFMNQY8ngwjq9rbJblL5caPezMOSGQbTZchdsL9iXf2NkyHr3zApiL2iciT IaY1oS6Kh6ETvboIUQ9/EkxsM0Hf22bJyGLUHC5/eMxhouSRAqDHZru2Cu2S20AzaRxv y8Gtu1pVGHoMcKbNp6HJDxfM/vS0bhwG3ZqI050ctWkZ9NkIzvtSYgxopy1nn3dlYvd7 UzVvngTbhpG1fl3eJrAULj7anFXCu1iT8K33sDoF8Vz8nBBTAiKPrUkRaxZuzDmphK4N pi9lEtiv+FRUrCUp4tEJanpWny2U2bRJQQX96TTekxEoTPDdsb774MBMRjoA4ENK0HWo S4Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8kyCo/WSMKeeAKesOT9xH1U/NJ4187Xum7g6Zpk6+6o=; b=agrXqHbHNnthiMTdYAz1sNS7nv1g0QuOmvL3oXKf207TAkONSzIecFKKW2ZpxFZVrq 9/fYAqDR5iftk/+4evh/FuROLMqf+5T8OVRn0sep6tW61uT38NjOA+ByvOIIFTD7uTpd 1zDjtQX/Vw3xuQLMjdUECD6TWv2LHISoztpCVyUziC0oHYRBdJz3c5QUN591biistSOk NJjqgTcxnN04yac3ALFZC71JgS9D6w5MZ/LfjIunPEIZecOR0rW63bbpzaSV+vwmHXdN WXEhYmNQCxoc2aUkjQ0FszJgsfnu9PPH3M9EyjBIY4roaazuSlvpezW6ANDdVMyFGo5n YfGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=DX6Up1hK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y17si4061272ejw.53.2020.07.01.10.57.58; Wed, 01 Jul 2020 10:58:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=DX6Up1hK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732793AbgGAR5x (ORCPT + 99 others); Wed, 1 Jul 2020 13:57:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730208AbgGAR5w (ORCPT ); Wed, 1 Jul 2020 13:57:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518CEC08C5C1; Wed, 1 Jul 2020 10:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8kyCo/WSMKeeAKesOT9xH1U/NJ4187Xum7g6Zpk6+6o=; b=DX6Up1hK4j7u/eeWojDc7hevxy wGh0015OTYtpoabI255K6NZIE64Z68TzDG4SOrA1F4dXHrGlMebBB/cJ5cpOAeT7pwK/2FiGw6Oh7 Mv3iu5QVYvd1DBikfjYv8GgwwXuzPRSZHjb9pXA9sOk5jlD7M1H6dzDYNXNiFg6kQNok6+/IEOaqb FFt6dxn9U/NsxifskbHIrz81wgpRiFgOdRQExiNVWvSlB4WxBk9JsPGRtyvoOVIcxayMTbo6E8vFx Zpf76pAZIiQ3AFmVOtFpRG+DWmRX8meXqSAxeAujR83ovaWeyvcRks8ddXMT50N3+6Ei0mTWAXq8d QJ1taOjA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqgzT-0003PE-FM; Wed, 01 Jul 2020 17:57:47 +0000 Date: Wed, 1 Jul 2020 18:57:47 +0100 From: Matthew Wilcox To: Mike Snitzer Cc: Christoph Hellwig , Jens Axboe , linux-raid@vger.kernel.org, linux-mm@kvack.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@tron.linbit.com, dm-devel@redhat.com, Tejun Heo , cgroups@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: remove dead bdi congestion leftovers Message-ID: <20200701175747.GT25523@casper.infradead.org> References: <20200701090622.3354860-1-hch@lst.de> <20200701164103.GC27063@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701164103.GC27063@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2020 at 12:41:03PM -0400, Mike Snitzer wrote: > On Wed, Jul 01 2020 at 5:06am -0400, > Christoph Hellwig wrote: > > > Hi Jens, > > > > we have a lot of bdi congestion related code that is left around without > > any use. This series removes it in preparation of sorting out the bdi > > lifetime rules properly. > > I could do some git archeology to see what the fs, mm and block core > changes were to stop using bdi congested but a pointer to associated > changes (or quick recap) would save me some time. > > Also, curious to know how back-pressure should be felt back up the IO > stack now? (apologies if these are well worn topics, I haven't been > tracking this area of development). It isn't. Jens declared the implementation was broken, and broke it more. So we're just living with stupid broken timeouts.