Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH bpf-next v2] selftests/bpf: Switch test_vmlinux to use
 hrtimer_range_start_ns.
To:     Hao Luo <haoluo@google.com>, <netdev@vger.kernel.org>,
        <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <clang-built-linux@googlegroups.com>
CC:     <sdf@google.com>, Shuah Khan <shuah@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andriin@fb.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        <linux-kselftest@vger.kernel.org>
References: <20200701175315.1161242-1-haoluo@google.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <aab03e4b-2779-3b71-44ea-735a7b92a70f@fb.com>
Date:   Wed, 1 Jul 2020 11:04:12 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.9.0
In-Reply-To: <20200701175315.1161242-1-haoluo@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2620:10d:c085:21e8::15c2] (2620:10d:c090:400::5:3953) by BYAPR21CA0015.namprd21.prod.outlook.com (2603:10b6:a03:114::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.1 via Frontend Transport; Wed, 1 Jul 2020 18:04:13 +0000
X-Originating-IP: [2620:10d:c090:400::5:3953]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3c08f14d-f1de-4733-2683-08d81de929fb
X-MS-TrafficTypeDiagnostic: BYAPR15MB3045:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB3045848847851C9C3D45FBF7D36C0@BYAPR15MB3045.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-Forefront-PRVS: 04519BA941
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NCjBXFQQRscZOptB/yu4D+30RYjgP63GiRgBVX09mkBE0NSVmOXnbErXAfIV7zY9sip8CuwTKyTxOoTi0qHoc+NFR6GY332MEsBjY9/PKtLVnHezh/p+f/RBkdBtUhLVsXhFbz5Aaa0Pq+Cl74YrHOHRdZ/jXPku4VWukMipoz5P2wreXGzvIgruPPEYYr6UVW0vKNa/EYo8jwikfIGShXRKbKYYIP2PGP2HNizv3AUjRKeRG5iJUGswAPAdl02CDHqfmvpyqllij/dn9YPWlDQjAHrgd/azVfxHe007CJxOhwuokVCHGjUx3HBGwYzZRzSvBcduxGSMcFv5JVeuAH6SVoKx4rdHVpm3D19qJVwNp6wkN0pcUvTG1KbXOgHm
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4088.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(396003)(136003)(376002)(366004)(346002)(7416002)(31686004)(2616005)(36756003)(5660300002)(6486002)(4326008)(53546011)(66946007)(8936002)(83380400001)(52116002)(31696002)(54906003)(16526019)(8676002)(66476007)(186003)(2906002)(66556008)(316002)(86362001)(478600001)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: 54EfXZSgT0aC2vBmvzqIEcq+9ULGliM9PXtxhjH7gMfE11BHCYt8A91xzpZWV6m4HkQl4ci5ZbUxkJbdXzcgPsqSA4inexIWUTmZU46rcR4fc8ddDCSXicbtgYGFwdCcW35XA2fUSrgpnwmRFpoBAkkCw5n2emCyuZW5OvcB3nqpMqPTDYT/3lQlSaiEXYZbdMx1gOpSIktMCnmeCiasQwMzhbmQpIz3A1gCAANYYLhe2//kvRneNWjF6FsdPnek3bLKTAAe6hyqNiE5Vd5QsrMXP3in5GH6zGAiwhkP1uGX/9UDsxzJ7jsI2JoYDMfpOl9gBAWN8ePa9N/ta9697fH0l85+jnOHRAY2SMzf28I6slF/LMWFqZUopnBSadOv16QZlCAlKal6njyBLiAa3gWkJX5FE5QHxX9tIj3d/faygBPHzsX4Y58spP6UrNTGoXqG3AeFwY2E6KJSy4fPF1QED5oEwfZGRY8wWlmXbzYnOWSKHaxxwODoT1Y8MLmv+Dqq6q2B8sdAjZEEaXpuDQ==
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c08f14d-f1de-4733-2683-08d81de929fb
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4088.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2020 18:04:14.4414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j6PfvP7ipTstu2h8+W1cPfwG7izugmqW7YsZJK/vvdxuQXnbeLlY78qNbQ++qFth
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3045
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-07-01_09:2020-07-01,2020-07-01 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=999
 adultscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 bulkscore=0
 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 clxscore=1015
 cotscore=-2147483648 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2004280000 definitions=main-2007010127
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/1/20 10:53 AM, Hao Luo wrote:
> The test_vmlinux test uses hrtimer_nanosleep as hook to test tracing
> programs. But in a kernel built by clang, which performs more aggresive
> inlining, that function gets inlined into its caller SyS_nanosleep.
> Therefore, even though fentry and kprobe do hook on the function,
> they aren't triggered by the call to nanosleep in the test.
> 
> A possible fix is switching to use a function that is less likely to
> be inlined, such as hrtimer_range_start_ns. The EXPORT_SYMBOL functions
> shouldn't be inlined based on the description of [1], therefore safe
> to use for this test. Also the arguments of this function include the
> duration of sleep, therefore suitable for test verification.
> 
> [1] af3b56289be1 time: don't inline EXPORT_SYMBOL functions
> 
> Tested:
>   In a clang build kernel, before this change, the test fails:
> 
>   test_vmlinux:PASS:skel_open 0 nsec
>   test_vmlinux:PASS:skel_attach 0 nsec
>   test_vmlinux:PASS:tp 0 nsec
>   test_vmlinux:PASS:raw_tp 0 nsec
>   test_vmlinux:PASS:tp_btf 0 nsec
>   test_vmlinux:FAIL:kprobe not called
>   test_vmlinux:FAIL:fentry not called
> 
>   After switching to hrtimer_range_start_ns, the test passes:
> 
>   test_vmlinux:PASS:skel_open 0 nsec
>   test_vmlinux:PASS:skel_attach 0 nsec
>   test_vmlinux:PASS:tp 0 nsec
>   test_vmlinux:PASS:raw_tp 0 nsec
>   test_vmlinux:PASS:tp_btf 0 nsec
>   test_vmlinux:PASS:kprobe 0 nsec
>   test_vmlinux:PASS:fentry 0 nsec
> 
> Signed-off-by: Hao Luo <haoluo@google.com>
> Acked-by: Andrii Nakryiko <andriin@fb.com>

Thanks!
Acked-by: Yonghong Song <yhs@fb.com>