Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 1 Jul 2020 19:09:13 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Christoph Fritz <chf.fritz@googlemail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: fan53880: Add initial support
Message-ID: <20200701180913.GA22871@sirena.org.uk>
References: <20200630185203.22882-1-chf.fritz@googlemail.com>
 <20200630185203.22882-2-chf.fritz@googlemail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5"
Content-Disposition: inline
In-Reply-To: <20200630185203.22882-2-chf.fritz@googlemail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--bg08WKrSYDhXBjb5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 30, 2020 at 08:52:02PM +0200, Christoph Fritz wrote:
> This patch adds support for ON Semiconductor FAN53880 regulator.
>=20
> The FAN53880 is an I2C porgrammable power management IC (PMIC)
> that contains a BUCK (step-down converter), four LDOs (low dropouts)
> and one BOOST (step-up converter).  It is designed for mobile power
> applications.

This doesn't build with current code, there are *many* errors in the
form

/mnt/kernel/drivers/regulator/fan53880.c:48:52: error: array type has incom=
plete element type 'struct regulator_linear_range'
   .linear_ranges =3D   (struct regulator_linear_range[]) { \
                                                    ^
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro =
'FAN53880_LDO'
  FAN53880_LDO(1, "VIN12", 2800000),
  ^~~~~~~~~~~~
In file included from /mnt/kernel/drivers/regulator/fan53880.c:5:
/mnt/kernel/include/linux/regulator/driver.h:46:2: error: field name not in=
 record or union initializer
  .min  =3D _min_uV,     \
  ^
/mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro =
'REGULATOR_LINEAR_RANGE'
         REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \
         ^~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro =
'FAN53880_LDO'
  FAN53880_LDO(1, "VIN12", 2800000),
  ^~~~~~~~~~~~
/mnt/kernel/include/linux/regulator/driver.h:46:2: note: (near initializati=
on for '(anonymous)')
  .min  =3D _min_uV,     \
  ^
/mnt/kernel/drivers/regulator/fan53880.c:49:9: note: in expansion of macro =
'REGULATOR_LINEAR_RANGE'
         REGULATOR_LINEAR_RANGE(_default, 0x0, 0x0, 0), \
         ^~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of macro =
'FAN53880_LDO'
  FAN53880_LDO(1, "VIN12", 2800000),
  ^~~~~~~~~~~~
/mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name not in=
 record or union initializer
  .min_sel =3D _min_sel,     \
  ^

most likely due to the conversion introduced in 60ab7f4153b6af46
(regulator: use linear_ranges helper).  Please rebase against current
code.

--bg08WKrSYDhXBjb5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl780UgACgkQJNaLcl1U
h9AT8wf495r68vZKdK9avH8NnewD+DkphtHtdWLDgwWHgGUfGPmb+QzTFzE00v6W
FdLMuOPaUfnBn/bKB6Dzzoh/qm2ZK37JkyQOLEQhOBtCbkutE6T/rFWRgMGJvBl0
+BKye8EojxtIhOBD2qSinQ4pTWudULWCFFZoPOhm63IPDbOcdMQmLi3X+8EkXGqd
YBIStS9+jfH9yCG9h4p3+VYlIG1OEwiZekjFgpFAgTT1E4vcJhhspC1NjP3XRMCD
C/eqSRdAOjEy2GvOH0Dao7/UgEyZXvmOJ1kjQK4AN8ZpjvpgU0iee9pFDQkCoZfV
1vJQajBaumpmIymOESyi1WndLydF
=xM/a
-----END PGP SIGNATURE-----

--bg08WKrSYDhXBjb5--