Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp862271ybt;
        Wed, 1 Jul 2020 11:51:04 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJysnCJjiB4mAjWXuI71WZVmt0fIJQzbwvZ3Gfr41eztkB6/2AVn/8QE3ygn+/oezdq7RT+a
X-Received: by 2002:a17:906:3446:: with SMTP id d6mr19307430ejb.323.1593629463996;
        Wed, 01 Jul 2020 11:51:03 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1593629463; cv=none;
        d=google.com; s=arc-20160816;
        b=LsxTkWgsntIFVUVOgQdPyRCkWRSjKoW4HXBgpjhM3HY9vl0RRvZPj28WTkdn5EQZBq
         A+1ftmnfLjrds2yy6Xc9xDLC9OBeKe9/24AJNYbZECBTVjwQdECZirexN2gz8n/ZxcSl
         0P8tFNxJvQRCR99c6kNlMiCWDXxbGChKx53l4zVRtT9YK0Ax9m5yQ6yVvKKejUMEqZsK
         SZkC2pMhIYTjdPD28d7vbadc1o0nYeMBH9jXXLQdDa+zhVapid0ZFFexP27jItMeW73p
         qcR4djVfxgTYB2ihDmMmoAwr+sMduiOODghTM/Qp+c5sglxltWmNytCUGjlrPY59q8hr
         i3kA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=nLZVfvXpow546Ny83X7PcHnsthMkaf6xSSXWofMs2TM=;
        b=ZSUSFL3bb4qq/AFIwTxZhIQZBvI/yk78T8TOj5lXepqnIDBLhfF0Ou7+Q4ZR8iqGsu
         DJlkfw38DfhLlitL25l6GojGpFtVVeYvHuiEIkeX4Pt7QyuNKAKnBH/ORFDPrOhCHpeS
         7l9RJifPLwPQBnaEDT0IFTB1Zwtl1BV2lQWRdgTFWRsDaWbW3uzUkWOb2i3MnyvDb3sQ
         IhyjfuC3TLb6EOm0mqr87qH39U5ShD9BNviSlaSlmRveqizGm9tY7k2IbJJZlF5sT862
         YBrZizcZY0hf4wvfyp5GzB4/sgKmZ8VCw+FgcSOQY8oOJEtbMn6ir1u2RK9FLtQ0oJQT
         GNeg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=QhA7yD3S;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w6si4334143eja.471.2020.07.01.11.50.41;
        Wed, 01 Jul 2020 11:51:03 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=QhA7yD3S;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726936AbgGASrp (ORCPT <rfc822;luigi.mantellini.ml@gmail.com>
        + 99 others); Wed, 1 Jul 2020 14:47:45 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:15687 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726594AbgGASro (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Jul 2020 14:47:44 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5efcda430001>; Wed, 01 Jul 2020 11:47:31 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Wed, 01 Jul 2020 11:47:44 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Wed, 01 Jul 2020 11:47:44 -0700
Received: from [10.26.73.166] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 1 Jul
 2020 18:47:38 +0000
Subject: Re: [PATCH v8 2/3] dt-bindings: arm-smmu: Add binding for Tegra194
 SMMU
To:     Krishna Reddy <vdumpa@nvidia.com>,
        Robin Murphy <robin.murphy@arm.com>
CC:     "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Thierry Reding <treding@nvidia.com>,
        "Yu-Huan Hsu" <YHsu@nvidia.com>, Sachin Nikam <Snikam@nvidia.com>,
        Pritesh Raithatha <praithatha@nvidia.com>,
        Timo Alho <talho@nvidia.com>,
        Bitan Biswas <bbiswas@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Nicolin Chen <nicolinc@nvidia.com>,
        Bryan Huntsman <bhuntsman@nvidia.com>,
        "nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>
References: <20200630001051.12350-1-vdumpa@nvidia.com>
 <20200630001051.12350-3-vdumpa@nvidia.com>
 <3e655881-bac4-f083-44ed-cfa0a61298d0@arm.com>
 <BYAPR12MB28222D6ADEBA966AA27FA9ECB36C0@BYAPR12MB2822.namprd12.prod.outlook.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <0d4f46d6-6a4e-bca0-bcf3-0e22a950e57b@nvidia.com>
Date:   Wed, 1 Jul 2020 19:47:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <BYAPR12MB28222D6ADEBA966AA27FA9ECB36C0@BYAPR12MB2822.namprd12.prod.outlook.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1593629251; bh=nLZVfvXpow546Ny83X7PcHnsthMkaf6xSSXWofMs2TM=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=QhA7yD3SiAXf8VfDA29dJYVFq4lFOI+mC9BDgt2r9dl8Kvi5BN3aHtHabdaaamiuO
         jjzQYJuItO3tKtk9rmoEvOtkxWCpicS4HjEd7BVS0xuwPflbFglLL25XERE0Kb1kEL
         f+Y4jrWIZX72JtcW6JqTTpoZw3pXpHiWxsOvwV4hUJLzJjYYuYjFQVcPMQjBMHW9m9
         WKLldH2lVQRNPXmjH1h2cdIbrou+EqYPW10a7tsgKPsbU0NKxlCLsLiU9KQV9Mt9O2
         oi4sGee+2uOl6ensDh5tbnu2mxe8ZsTIDTP7tp+wom+uED6UXXT11VsMWpe2BzP4Le
         dYLj68hsZuw8Q==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 01/07/2020 19:28, Krishna Reddy wrote:
>>> +      - description: NVIDIA SoCs that use more than one "arm,mmu-500"
>> Hmm, there must be a better way to word that to express that it only applies to the sets of SMMUs that must be programmed identically, and not any other independent MMU-500s that might also happen to be in the same SoC.
> 
> Let me reword it to "NVIDIA SoCs that must program multiple MMU-500s identically".
> 
>>> +        items:
>>> +          - enum:
>>> +              - nvdia,tegra194-smmu
>>> +          - const: arm,mmu-500
> 
>> Is the fallback compatible appropriate here? If software treats this as a standard MMU-500 it will only program the first instance (because the second isn't presented as a separate MMU-500) - is there any way that isn't going to blow up?
> 
> When compatible is set to both nvidia,tegra194-smmu and arm,mmu-500, implementation override ensure that both instances are programmed. Isn't it? I am not sure I follow your comment fully.

The problem is, if for some reason someone had a Tegra194, but only set
the compatible string to 'arm,mmu-500' it would assume that it was a
normal arm,mmu-500 and only one instance would be programmed. We always
want at least 2 of the 3 instances programmed and so we should only
match 'nvidia,tegra194-smmu'. In fact, I think that we also need to
update the arm_smmu_of_match table to add 'nvidia,tegra194-smmu' with
the data set to &arm_mmu500.

Jon

-- 
nvpublic