Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <465a540e-5296-32e7-f6a6-79942dfe2618@netrounds.com>
 <20200623134259.8197-1-mzhivich@akamai.com> <1849b74f-163c-8cfa-baa5-f653159fefd4@akamai.com>
 <CAM_iQpX1+dHB0kJF8gRfuDeAb9TsA9mB9H_Og8n8Hr19+EMLJA@mail.gmail.com>
In-Reply-To: <CAM_iQpX1+dHB0kJF8gRfuDeAb9TsA9mB9H_Og8n8Hr19+EMLJA@mail.gmail.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Wed, 1 Jul 2020 12:58:45 -0700
Message-ID: <CAM_iQpWjQiG-zVs+e-V=8LvTFbRwgC4y4eoGERjezfAT0Fmm8g@mail.gmail.com>
Subject: Re: Packet gets stuck in NOLOCK pfifo_fast qdisc
To:     Josh Hunt <johunt@akamai.com>
Cc:     jonas.bonn@netrounds.com, Paolo Abeni <pabeni@redhat.com>,
        Michael Zhivich <mzhivich@akamai.com>,
        David Miller <davem@davemloft.net>,
        John Fastabend <john.fastabend@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>
Content-Type: multipart/mixed; boundary="000000000000df77dd05a966b86c"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--000000000000df77dd05a966b86c
Content-Type: text/plain; charset="UTF-8"

On Wed, Jul 1, 2020 at 9:05 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> On Tue, Jun 30, 2020 at 2:08 PM Josh Hunt <johunt@akamai.com> wrote:
> > Do either of you know if there's been any development on a fix for this
> > issue? If not we can propose something.
>
> If you have a reproducer, I can look into this.

Does the attached patch fix this bug completely?

Thanks.

--000000000000df77dd05a966b86c
Content-Type: text/x-patch; charset="US-ASCII"; name="qdisc_run.diff"
Content-Disposition: attachment; filename="qdisc_run.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_kc3s8mkg0>
X-Attachment-Id: f_kc3s8mkg0

ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbmV0L3BrdF9zY2hlZC5oIGIvaW5jbHVkZS9uZXQvcGt0X3Nj
aGVkLmgKaW5kZXggOTA5MmU2OTcwNTllLi41YTAzY2RlZDMwNTQgMTAwNjQ0Ci0tLSBhL2luY2x1
ZGUvbmV0L3BrdF9zY2hlZC5oCisrKyBiL2luY2x1ZGUvbmV0L3BrdF9zY2hlZC5oCkBAIC0xMjMs
NyArMTIzLDcgQEAgYm9vbCBzY2hfZGlyZWN0X3htaXQoc3RydWN0IHNrX2J1ZmYgKnNrYiwgc3Ry
dWN0IFFkaXNjICpxLAogCiB2b2lkIF9fcWRpc2NfcnVuKHN0cnVjdCBRZGlzYyAqcSk7CiAKLXN0
YXRpYyBpbmxpbmUgdm9pZCBxZGlzY19ydW4oc3RydWN0IFFkaXNjICpxKQorc3RhdGljIGlubGlu
ZSBib29sIHFkaXNjX3J1bihzdHJ1Y3QgUWRpc2MgKnEpCiB7CiAJaWYgKHFkaXNjX3J1bl9iZWdp
bihxKSkgewogCQkvKiBOT0xPQ0sgcWRpc2MgbXVzdCBjaGVjayAnc3RhdGUnIHVuZGVyIHRoZSBx
ZGlzYyBzZXFsb2NrCkBAIC0xMzMsNyArMTMzLDkgQEAgc3RhdGljIGlubGluZSB2b2lkIHFkaXNj
X3J1bihzdHJ1Y3QgUWRpc2MgKnEpCiAJCSAgICBsaWtlbHkoIXRlc3RfYml0KF9fUURJU0NfU1RB
VEVfREVBQ1RJVkFURUQsICZxLT5zdGF0ZSkpKQogCQkJX19xZGlzY19ydW4ocSk7CiAJCXFkaXNj
X3J1bl9lbmQocSk7CisJCXJldHVybiB0cnVlOwogCX0KKwlyZXR1cm4gZmFsc2U7CiB9CiAKIHN0
YXRpYyBpbmxpbmUgX19iZTE2IHRjX3NrYl9wcm90b2NvbChjb25zdCBzdHJ1Y3Qgc2tfYnVmZiAq
c2tiKQpkaWZmIC0tZ2l0IGEvbmV0L2NvcmUvZGV2LmMgYi9uZXQvY29yZS9kZXYuYwppbmRleCA5
MGI1OWZjNTBkYzkuLmM3ZTQ4MzU2MTMyYSAxMDA2NDQKLS0tIGEvbmV0L2NvcmUvZGV2LmMKKysr
IGIvbmV0L2NvcmUvZGV2LmMKQEAgLTM3NDQsNyArMzc0NCw4IEBAIHN0YXRpYyBpbmxpbmUgaW50
IF9fZGV2X3htaXRfc2tiKHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBRZGlzYyAqcSwKIAog
CWlmIChxLT5mbGFncyAmIFRDUV9GX05PTE9DSykgewogCQlyYyA9IHEtPmVucXVldWUoc2tiLCBx
LCAmdG9fZnJlZSkgJiBORVRfWE1JVF9NQVNLOwotCQlxZGlzY19ydW4ocSk7CisJCWlmICghcWRp
c2NfcnVuKHEpICYmIHJjID09IE5FVF9YTUlUX1NVQ0NFU1MpCisJCQlfX25ldGlmX3NjaGVkdWxl
KHEpOwogCiAJCWlmICh1bmxpa2VseSh0b19mcmVlKSkKIAkJCWtmcmVlX3NrYl9saXN0KHRvX2Zy
ZWUpOwo=
--000000000000df77dd05a966b86c--