DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com.au;
  h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
  b=DniFEou6F2fgItrovu2FOGxKKyiYJJhFyhN1uDQCJ/TBiVaZFKLLstnm7IF0+XNMXpfo1Zj9VG8KiI2uN8FJbDTTb5QvVB5hdKb4VZpiAuYmmE0XhjPb5LgIh219+ERpBQaRjWcJRYuexlcN3f+FrhS/ThBtkauFaVOmspz/6IM=  ;
Message-ID: <442B9BD5.7030101@yahoo.com.au>
Date: Thu, 30 Mar 2006 18:50:29 +1000
From: Nick Piggin <nickpiggin@yahoo.com.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
CC: Jens Axboe <axboe@suse.de>, linux-kernel@vger.kernel.org,
       torvalds@osdl.org
Subject: Re: [PATCH][RFC] splice support
References: <20060329122841.GC8186@suse.de>	<20060329143758.607c1ccc.akpm@osdl.org>	<20060330074534.GL13476@suse.de>	<20060330000240.156f4933.akpm@osdl.org>	<20060330081008.GO13476@suse.de> <20060330002726.48cf0ffb.akpm@osdl.org>
In-Reply-To: <20060330002726.48cf0ffb.akpm@osdl.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1186
Lines: 31

Andrew Morton wrote:
> Jens Axboe <axboe@suse.de> wrote:

>> It doesn't, I'm assuming that find_get_pages() returns consequtive pages
>> atm. Would seem like the sane interface :-)
> 
> 
> Yeah, sorry.  It's a "gather what's presently there" thing.  For writeback.
> 
> Nick has some gang-lookup-slots code.  So instead of populating an array of
> page*'s you can populate an array of (effectively) page**'s.  Then one
> could walk that.   All while holding ->tree_lock.    This doesn't help ;)
> 

Actually while we're on the subject, my gang_lookup_slot code is just
named to match lookup_slot and gang_lookup... it still only returns
slots that are presently populated. Suggestions for a better name
welcome?

> Probably the simplest for now is an open-coded find_get_page() loop.  Later

Agreed. I think that's the best idea for now.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/