Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1063238ybt; Wed, 1 Jul 2020 17:48:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYgqXkpd0C+XN5vAUHnm0wpekHa/jFa4m6Rh9XMzplRW35a75vyzKqaewZ6Xj7Jp/OLkby X-Received: by 2002:a05:6402:1b0e:: with SMTP id by14mr30996409edb.266.1593650881310; Wed, 01 Jul 2020 17:48:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593650881; cv=none; d=google.com; s=arc-20160816; b=bYny0elw1DAbiXK9doougcY3WYxnYoyTvIYdrYlB01UfvPoULRDNw09cGckjocqk/R t3/0y+qsehCGFOw8f0zd6ttMX/ywgcqSLsDUMaEivY/GtYjIhgOnhiGSQ1Ccl2snaWTK iDPiar/slhOAgm3+HaDlXqizxenfbxqelr8mtjGjcyuO8zx1sTfyVmDgqSBDQMCaFUjw 9+pNviWM905lSMHrJNa66eZVOe7Rpt+xhfmtvEYszbBPiavm88wl1dRhLpogWTEG+BVZ 0kJmf1GdZoeo/MgIKldghz6tgp3xtMoYqx8tAalbMg6HwD7QYeSQyG5B5SnESKqvKvdK 2t7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=QkFpAqHIEwjnDZzlaTT8UYrxvp33BFcnJrcQL30nIPA=; b=ZdBtnqo0Wzl8qpPa+R7UyO6W8ltDhBmV0RLIUteaVWuGIwQ02DtroBw1w2KijOBJHY 3i3GnBtdbgOITlRtlT7L+uo5kKfrcetBIUv1lwjw9MMD9VA7FT0MHvmksicwpu/Du43o HroWAKy1ZxEmQtloZ1lAo03oB0ZGfOEUG4uGlKoUDhsSoO15886+RrCx+kjtageq7lK8 fQscGJdX6P1rVNUmBls+2DaX20K3xMm4aYVotq3U8l9RwqIozWdjs2BiC8a58OOHJZnK AlqikRov9vUzxmKflnCiUEcTA0C7wsgH9KE6sN3IeeDHYo3OKh81cfcSH/i08WihzkgB xoCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UZ3i4lz4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g22si5539517edj.310.2020.07.01.17.47.38; Wed, 01 Jul 2020 17:48:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UZ3i4lz4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727996AbgGBArB (ORCPT + 99 others); Wed, 1 Jul 2020 20:47:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgGBArA (ORCPT ); Wed, 1 Jul 2020 20:47:00 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D75C08C5C1 for ; Wed, 1 Jul 2020 17:47:00 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id 80so24124270qko.7 for ; Wed, 01 Jul 2020 17:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :organization:user-agent:mime-version:content-transfer-encoding; bh=QkFpAqHIEwjnDZzlaTT8UYrxvp33BFcnJrcQL30nIPA=; b=UZ3i4lz4YGIqh8LxR98d8rkht9xMQ0quD9UlveG9LZH2vjLD9qj3oSfRuxQwi6SgW7 7KjIBPlRzgQVKjuRbeNPX/dSjtoRbW+wR3qT+me1d1SKHMec7LFbkT/nwJurndd8wtFx h0wvGYiX3LSAhqfKBXk7+Xk7a5fEYYAiZrzY3XwmyBtM0RuCPU7B2ir2r1gn6Iwa+gAn Xz8woox1ZNCq0tr25hZygYEW1QHbGoSF07QYS0GBCZKXt98E8b53isIUMePGv3wuyrcw mlQwAPuiu7B/VH2K/rnFVDFq9P/xaMWdWLPTfrqCF6EX2XOV2n2XoVZfjVNEnEQcZ6iq SIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=QkFpAqHIEwjnDZzlaTT8UYrxvp33BFcnJrcQL30nIPA=; b=oM7ggOqeRh4f6vycMdBxn47vMoPbFCgSFDz0BUJ/eOG7aCT6xaqxwNEfmF4Pudq41t bUvyZMhkmywO6Plybti9HneZPGgTYLhleA4vw5RlFulfGRff1ziQug92i+yDScxzWOz6 zVZGtLe5sPBV2DxTSY3Hf6CkCcnady4p9VCsPMQHA0qsh7q2vXhiahPc7moL3/lhH0pz k05LTAqWMd0DpItA9kMld5A11qhBTNv58OtMdz5RIGKPAoMQcmN8grwkFMO6OxF7Ow3L K5vZ25eXS1zkXVMDlKN16xD0B4r3yVEZnKZcmzhGGBs3FuZMTGm7MFMm7a/X2Pk3biFw 2i0g== X-Gm-Message-State: AOAM53369cvjyrigZ4tsX+NN5xj6SKYPw5KJPB+m6Odtky6/AotfQc7w 80/i01olRXUefTzEDS0IWqw= X-Received: by 2002:a37:b206:: with SMTP id b6mr28062822qkf.22.1593650819671; Wed, 01 Jul 2020 17:46:59 -0700 (PDT) Received: from LeoBras (200-236-245-17.dynamic.desktop.com.br. [200.236.245.17]) by smtp.gmail.com with ESMTPSA id q32sm7306960qte.31.2020.07.01.17.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 17:46:59 -0700 (PDT) Message-ID: <6ed28aedbad029f107721e2ea4701e5b05233dd9.camel@gmail.com> Subject: Re: [PATCH v2 1/6] powerpc/pseries/iommu: Create defines for operations in ibm,ddw-applicable From: Leonardo Bras To: Alexey Kardashevskiy , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thiago Jung Bauermann , Ram Pai Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Wed, 01 Jul 2020 21:46:54 -0300 In-Reply-To: <0d3ee444-f528-673e-48f9-633138398543@ozlabs.ru> References: <20200624062411.367796-1-leobras.c@gmail.com> <20200624062411.367796-2-leobras.c@gmail.com> <01443a2f1d58a595ddff03fd14fd56f4c26171bf.camel@gmail.com> <0d3ee444-f528-673e-48f9-633138398543@ozlabs.ru> Organization: IBM Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-07-02 at 10:43 +1000, Alexey Kardashevskiy wrote: > > Or should one stick to #define in this case? > > imho a matter of taste but after some grepping it feels like #define is > mostly used which does not mean it is a good idea. Keep it enum and see > if it passed mpe's filter :) Good idea :) Thanks !