Date: Thu, 30 Mar 2006 12:19:03 -0800
From: Andrew Morton <akpm@osdl.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: neilb@suse.de, linux-kernel@vger.kernel.org, drepper@redhat.com,
       mtk-manpages@gmx.net, nickpiggin@yahoo.com.au
Subject: Re: [patch 1/1] sys_sync_file_range()
Message-Id: <20060330121903.643352ac.akpm@osdl.org>
In-Reply-To: <87d5g4rlth.fsf@duaron.myhome.or.jp>
References: <200603300741.k2U7fQLe002202@shell0.pdx.osdl.net>
	<17451.36790.450410.79788@cse.unsw.edu.au>
	<20060330003246.31216ff2.akpm@osdl.org>
	<87d5g4rlth.fsf@duaron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 979
Lines: 33

OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
>
> Andrew Morton <akpm@osdl.org> writes:
> 
> > +	if ((s64)offset < 0)
> > +		goto out;
> > +	if ((s64)endbyte < 0)
> > +		goto out;
> 
> loff_t is long long on all arch. This is not need?

True, the casts happen to be unneeded.  But they do set the reader's mind
at ease.

> > +	if (S_ISFIFO(file->f_dentry->d_inode->i_mode)) {
> > +		ret = -ESPIPE;
> > +		goto out_put;
> > +	}
> 
> How about to check "if (!file->f_op || !file->f_op->fsync)" or something?

This syscall won't call ->fsync.

> For chrdev is also strange, and in the case of fsync(), it returns -EINVAL.
> IMHO it seems there is consistency.
> 

I guess so.   Perhaps it should be S_ISREG|S_ISBLK|S_ISDIR|S_ISLNK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/