Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Park Ju Hyung'" <qkrwngud825@gmail.com>
Cc:     "'Sungjong Seo'" <sj1557.seo@samsung.com>,
        "'open list'" <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
In-Reply-To: <20200627125509.142393-1-qkrwngud825@gmail.com>
Subject: RE: [PATCH] exfat: implement "quiet" option for setattr
Date:   Thu, 2 Jul 2020 14:16:34 +0900
Message-ID: <003801d6502f$f40101c0$dc030540$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQFjCjgoG/7FbtfSlJVNByWgm5NQEgFvhuGuqc7MRNA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200627125605epcas1p175ba4ecfbdea3426cc7b0a8fc1750cd0@epcas1p1.samsung.com>
        <20200627125509.142393-1-qkrwngud825@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
>  	if (((attr->ia_valid & ATTR_UID) &&
>  	     !uid_eq(attr->ia_uid, sbi->options.fs_uid)) || @@ -322,6 +325,12 @@ int
> exfat_setattr(struct dentry *dentry, struct iattr *attr)
>  		goto out;
You should remove goto statement and curly braces here to reach if error condition.
>  	}
> 
> +	if (error) {
> +		if (sbi->options.quiet)
> +			error = 0;
> +		goto out;
> +	}