Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 2 Jul 2020 08:16:11 +0200
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Sylwester Nawrocki <snawrocki@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH v2] ARM: dts: exynos: Fix missing empty reg/ranges
 property regulators on Trats
Message-ID: <20200702061611.GC4175@kozik-lap>
References: <CGME20200629210025eucas1p219a52e75ecce9e813aa80f0126780189@eucas1p2.samsung.com>
 <20200629205948.32250-1-krzk@kernel.org>
 <97651868-30f3-6b91-1ea2-551ee1ebad8f@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <97651868-30f3-6b91-1ea2-551ee1ebad8f@samsung.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 30, 2020 at 08:27:01AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
> 
> On 29.06.2020 22:59, Krzysztof Kozlowski wrote:
> > Remove the regulators node entirely because its children do not have any
> > unit addresses.  This fixes DTC warning:
> >
> >      Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> What about removing the regulators node from other boards: 
> exynos4412-origen.dts, exynos5420-smdk5420.dts and exynos5250-arndale.dts?
> 
> On the other hand, maybe it would be really easier to add missing 
> address/size-cells properties to exynos4210-trats.dts/regulators node?

Indeed let's keep it consistent so in such case better to add here
proper address/size-cells.

Thanks for feedback!

Best regards,
Krzysztof