Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1252667ybt; Thu, 2 Jul 2020 00:20:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkus0vaASkXbhCN3gr5IPV6Y9O01SX67YGvoZ7wwlxwvO5s+w1vodZGsB2dRnZFCQ6h2f/ X-Received: by 2002:aa7:cdca:: with SMTP id h10mr19799848edw.285.1593674426999; Thu, 02 Jul 2020 00:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593674426; cv=none; d=google.com; s=arc-20160816; b=vnGvGeOA7/zzhz3ZDuKZNolHdaiW4AiQ518VKnbq/591tvwpe1rELIYPPNSWVm0Ml2 PGWpy+EcvpxZ/yNwH9R+CpzylDMLbpmiWbowtD9svNTYJQpjEbsRBRstyCKRm7UlZLkW nkYSfsMR/+siYxF3nAekFTRhlN12C+zynhkFfH0G/Be5YTvCwuUx8NQycH4B9JLP23Nw D8HBbvlPmSSyGEBnoGRF/8OaX4W8pbM7n/kJAVCKL3obJyhQx0G6Jlg4tobCurmrA78e GIHK1kz4unqOZE7tSapBxqDkvpVOCelP5qstvRidqW/t5LSA6En9GcPoMDmR+ebYB0pS XraA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=OY7VrL1a59Qxq0BBbOuXh6ED5q1CVp62vwIhZmJJ8VQ=; b=bQw9PpMUwBJkmwwFrbHYP/Rk0wS85dQMVrFxWe/uLg2EFn8ELoNHPN5u4s2hjJ4uhP JuRH9xUQI5o9AR4fzqbnQCwWsHpdGzkWNIHJa7nqrPw/ShxAlWOnkLJBG1Tdw34mt/wF Ujr9bSE0+wCrwikg+GN9wZ2KyvuTrrikrC8Pz+wc63WpJYecYIM/u2dbcdEXL0xKSo5g dj61ftIpywsNbSCzfJT1xbzng5oenAmnA5dg5ZE+mOIQvANtWYNXUhEBQQNtd/B9kTpU EIBdE7GSfXgZ2kmCCdriDN0B3Yi8EEiFjoUTlpJv+4fzUcwJVKniPE7kB0mCX2McgDjK 0sNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="BaOM/sLa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si5440287ejx.656.2020.07.02.00.20.03; Thu, 02 Jul 2020 00:20:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="BaOM/sLa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbgGBHQp (ORCPT + 99 others); Thu, 2 Jul 2020 03:16:45 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:21365 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726092AbgGBHQo (ORCPT ); Thu, 2 Jul 2020 03:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593674203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OY7VrL1a59Qxq0BBbOuXh6ED5q1CVp62vwIhZmJJ8VQ=; b=BaOM/sLa7mJ31vg9AwjWvYBuq0Lh2Pu8DSDHlzXKylC/IFhrjIkKQc0WuKA4aWLq07r79q ybZHNdDYdKMfbxrV+IH+Ewrfaz4b9330LLJu6H3BXTwFeYbF4kRxpl9luWjjXc90IRviQr M+fuZZOgq58OqqjRz/SG1GOLAws/ojU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-laIbpHlZNWC6OsI8747z3Q-1; Thu, 02 Jul 2020 03:16:38 -0400 X-MC-Unique: laIbpHlZNWC6OsI8747z3Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB4378015F7; Thu, 2 Jul 2020 07:16:36 +0000 (UTC) Received: from [10.36.112.70] (ovpn-112-70.ams2.redhat.com [10.36.112.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C64345DAB0; Thu, 2 Jul 2020 07:16:34 +0000 (UTC) Subject: Re: [PATCH v3 1/7] iommu/vt-d: Enforce PASID devTLB field mask To: Jacob Pan , iommu@lists.linux-foundation.org, LKML , Lu Baolu , Joerg Roedel , David Woodhouse Cc: Yi Liu , "Tian, Kevin" , Raj Ashok References: <1593617636-79385-1-git-send-email-jacob.jun.pan@linux.intel.com> <1593617636-79385-2-git-send-email-jacob.jun.pan@linux.intel.com> From: Auger Eric Message-ID: <0c76fbb7-8844-6a72-5249-934ed0a5c10b@redhat.com> Date: Thu, 2 Jul 2020 09:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1593617636-79385-2-git-send-email-jacob.jun.pan@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/1/20 5:33 PM, Jacob Pan wrote: > From: Liu Yi L > > Set proper masks to avoid invalid input spillover to reserved bits. > > Acked-by: Lu Baolu > Signed-off-by: Liu Yi L > Signed-off-by: Jacob Pan > --- > include/linux/intel-iommu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h > index 4100bd224f5c..729386ca8122 100644 > --- a/include/linux/intel-iommu.h > +++ b/include/linux/intel-iommu.h > @@ -380,8 +380,8 @@ enum { > > #define QI_DEV_EIOTLB_ADDR(a) ((u64)(a) & VTD_PAGE_MASK) > #define QI_DEV_EIOTLB_SIZE (((u64)1) << 11) > -#define QI_DEV_EIOTLB_GLOB(g) ((u64)g) > -#define QI_DEV_EIOTLB_PASID(p) (((u64)p) << 32) > +#define QI_DEV_EIOTLB_GLOB(g) ((u64)(g) & 0x1) > +#define QI_DEV_EIOTLB_PASID(p) ((u64)((p) & 0xfffff) << 32) > #define QI_DEV_EIOTLB_SID(sid) ((u64)((sid) & 0xffff) << 16) > #define QI_DEV_EIOTLB_QDEP(qd) ((u64)((qd) & 0x1f) << 4) > #define QI_DEV_EIOTLB_PFSID(pfsid) (((u64)(pfsid & 0xf) << 12) | \ > Reviewed-by: Eric Auger Thanks Eric