Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1592567631-20363-1-git-send-email-gene.chen.richtek@gmail.com>
 <1592567631-20363-3-git-send-email-gene.chen.richtek@gmail.com> <20200701071620.GQ1179328@dell>
In-Reply-To: <20200701071620.GQ1179328@dell>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Thu, 2 Jul 2020 16:29:38 +0800
Message-ID: <CAE+NS35Kj_H9uSgBiff4hogTWmwh6z+vmPNWDh_yU1=p68xQZA@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC
To:     Lee Jones <lee.jones@linaro.org>
Cc:     jic23@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
        matthias.bgg@gmail.com, knaack.h@gmx.de, lars@metafoo.de,
        pmeerw@pmeerw.net, dmurphy@ti.com, lgirdwood@gmail.com,
        Mark Brown <broonie@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Gene Chen <gene_chen@richtek.com>, shufan_lee@richtek.com,
        cy_huang@richtek.com, benjamin.chao@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Lee Jones <lee.jones@linaro.org> =E6=96=BC 2020=E5=B9=B47=E6=9C=881=E6=97=
=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:16=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Fri, 19 Jun 2020, Gene Chen wrote:
>
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > imlement i2c R/W with CRC when access sub-device PMIC and LDO part
>
> Please use proper grammar, including capital letters at the start of
> the sentence and for abbreviations such as "I2C" and full stops.
>
> Also this doesn't make sense to me.  Please elaborate.
>

ACK

> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> >  drivers/mfd/Kconfig        |   1 +
> >  drivers/mfd/mt6360-core.c  | 541 +++++++++++++++++++++++++++++--------=
--------
>
> This patch is doing way too much wacky stuff all at once, making it
> very difficult to review.  Please break it up into functional pieces
> and submit as separate logical patches (in a set of course).
>

If I understand correctly, I need to separate patch[2/4] but not
entire mt6362-core.c into several patches.

> >  include/linux/mfd/mt6360.h | 240 --------------------
> >  3 files changed, 357 insertions(+), 425 deletions(-)
> >  delete mode 100644 include/linux/mfd/mt6360.h
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Senior Technical Lead - Developer Services
> Linaro.org =E2=94=82 Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog