Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1306024ybt; Thu, 2 Jul 2020 02:02:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycOGYGFm7jAta90VRLZtVIUPXHxn4bnl0S80wk5eAp/cIHfqg1y98V+BTf7aOSFIUQgGC6 X-Received: by 2002:a50:8143:: with SMTP id 61mr34058473edc.202.1593680574746; Thu, 02 Jul 2020 02:02:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593680574; cv=none; d=google.com; s=arc-20160816; b=pfpczjH0jTMNjLYuPs6VVTyZ0t9yPcRvwpYRfbn+DK/fAFJyA/zwIuJJn+lAYkzWBW 6tLqaoAb0EIIblgih7cDvTh87q/Wh47GRwe9pKI5zoqAW0bGifxcxDWaRwS+zWI5+G+Q hskoA6n6dADd/h7itRIBA/+bkUNK5e8SVH56rvHEqCcQAHFRonPfLAQeDj3kYALMjwGE u4y1j4Ra41vpKgE3ewdBTGyvFwnI5ofALWbSNHgxSSxoFIsakDLrfVNPuqdJRVOvQpfl Q3O5kyujpGrWdeYnfXLc7YZ61aXx/zCJD3Up6EAgbnZSbm0rjMnD/v7VI0mBOgi6XJLM Lk1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=iSHp+qL8jlCnfx+lpGtQHzsTwnPkgJZ+hzplODbpLis=; b=lRJjWBY3vEdTsNbarl2lwcmJvWOvY5khk2ZcOWxqscE/gOhCk462oeHwlhoOM19jwP gQ0TfMMd5XbdypL+xHNooP3i2WQqpDX1tzs3E058SK+1UoogZwbMInRSnKcMtMaTSi1p papXUQP3yc4DrQPrcugRmiE5Sb57V1OVnSImRzyYlktDKnwucl/r0RCJasbYwtTVzkrW vh0esIs2vX+JsHzzi79cLBGYCpW5ik83ANQTEW/F0aZ2UY2xGnrl4biyN+3DJxL6TzyX NWyAQSI9XOO7/3LDSC2OJ+YegGGWCE7UEqC+aJ8elf2glHl6JxV17BL1iqAeQSPKr3vR rwEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Dm6t6Oj3; dkim=neutral (no key) header.i=@vger.kernel.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si5348146edw.286.2020.07.02.02.02.31; Thu, 02 Jul 2020 02:02:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Dm6t6Oj3; dkim=neutral (no key) header.i=@vger.kernel.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbgGBJCF (ORCPT + 99 others); Thu, 2 Jul 2020 05:02:05 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:47408 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgGBJCF (ORCPT ); Thu, 2 Jul 2020 05:02:05 -0400 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1593680523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iSHp+qL8jlCnfx+lpGtQHzsTwnPkgJZ+hzplODbpLis=; b=Dm6t6Oj3BbIVrKAKyTPjW9LF/T6t9Bdmutb1cDd//FSn6oQed1lqlut+QZ/bL6vcaNKAmJ z0JGzBsNfDxwFugQRGwERqzKuxAK3zrNqmSLEQ2pdwKWeClLJCsnQZKmxgOiIdd1ftbaQW WlKM7WI3QfY26qqotnC2lsXHy7rhQRghAbA+3li6yeObek2Ek+dXKjK4UXsZAfoOhfnKVK 1r8SBDbFHUYJBrENZduuXCsHqzEGTfM+oDtvoSQ3nqff6jUoPfhcM++KrFwNh8q7bMYXfq /4I3bzmlge/U+LaUPvcl+ROpiqtDlKixRwaTPUM4finRSAVGrP6/1W4U8DfulQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1593680523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iSHp+qL8jlCnfx+lpGtQHzsTwnPkgJZ+hzplODbpLis=; b=Jzif+nd6FqtafDb6f+2yMZZidwaOxAfVki88jUDsJxCrf3uwlXuFSQCViQifPGUGQtg947 TVMYm9euQgiGUHCA== To: lijiang , Petr Mladek Cc: Peter Zijlstra , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , Paul McKenney , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] printk: use the lockless ringbuffer In-Reply-To: References: <20200618144919.9806-1-john.ogness@linutronix.de> <20200618144919.9806-4-john.ogness@linutronix.de> Date: Thu, 02 Jul 2020 11:08:02 +0206 Message-ID: <87zh8imgs5.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-02, lijiang wrote: > About the VMCOREINFO part, I made some tests based on the kernel patch > v3, the makedumpfile and crash-utility can work as expected with your > patch(userspace patch), but, unfortunately, the vmcore-dmesg(kexec-tools) > can't correctly read the printk ring buffer information, and get the > following error: > > "Missing the log_buf symbol" > > The kexec-tools(vmcore-dmesg) should also have a similar patch, just like > in the makedumpfile and crash-utility. Yes, a patch for this is needed (as well as for any other related software floating around the internet). I have no RFC patches for vmcore-dmesg. Looking at the code, I think it would be quite straight forward to port the makedumpfile patch. I will try to make some time for this. I do not want to patch any other software for this. I think with 3 examples (crash, makedumpfile, vmcore-dmesg), others should be able to implement the changes to their software without needing my help. John Ogness