Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1322097ybt; Thu, 2 Jul 2020 02:32:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmydm1/4MYtrWXejILMervBSocdoZPlkp+Ldo57+56GUDJHSRKyUDOALKy68XFcpwLlqdF X-Received: by 2002:aa7:d744:: with SMTP id a4mr33447059eds.94.1593682320323; Thu, 02 Jul 2020 02:32:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593682320; cv=none; d=google.com; s=arc-20160816; b=NYDTTyqEi14RzXePMPYBLOaAk4LpUAuXx9OxxTknrdM0Db/nowZPiN9Gg5rnvRRuX8 v54DMg9CzrxzxB3h75ZgFf/RZ7C84QDih3zId4ckN/ukCVIbx+oZW1adYqFZv1OhasXA YN+8XNX1vzctZM6q0p5DqNi7xzGyQm0E98f5yrI2i0/EWlqmNYOD1RjDlpfnGrb8xmjZ nVMmQ2c9+uCScHsqP+sGV+VYc3qhOsaFeoTYoUHFRHVxJGap6RJ3JEb6I9hzxDmsqF0+ kcI9mQPMN8qU/S7WDQPj0BXeZmldkrDq1A4S0gYUVdojLN/hJHLHQQ+qEuE6S8l7+tDP eeWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=sQCFiGzSC0dQIzc+FHc1PqcfHEnA/cl3jUVDZmdRB1g=; b=x7denJbGDqz5qdzx/6/jubFkjWn5wXJmFTzNqREXyL4H2UbMfe2Q9QKp33UkHq6Xrc ttuU+UDBD5nQUWBbogyNHOJpCJpoz+FUjfl7Kvw8PMsLq2Q4MfTuez2gdk7p/4H+I8oN 3+bKThZKmaZmqxmStczxj0pqs7Dbv9FT32UrMFp+PbI/lw6NmomXC85ii9x6wA54TcIu 1azfv2Wrdn1HaOGxOHs85eb2gqdG5uTPq95c42I4cvrJ11HTV9RM/hRPYhvXLvKakvtr +kIjsy0nWJ24jXo3rZI0mf1+RH4sUQvQh2IFmd9NJ/xzTd0c2/QnwrM0WR2gihMZmX3l 1Rsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=C37eoVAs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si5423269edv.119.2020.07.02.02.31.36; Thu, 02 Jul 2020 02:32:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=C37eoVAs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbgGBJbR (ORCPT + 99 others); Thu, 2 Jul 2020 05:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725287AbgGBJbR (ORCPT ); Thu, 2 Jul 2020 05:31:17 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 042EBC08C5C1; Thu, 2 Jul 2020 02:31:17 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id gc9so5701058pjb.2; Thu, 02 Jul 2020 02:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sQCFiGzSC0dQIzc+FHc1PqcfHEnA/cl3jUVDZmdRB1g=; b=C37eoVAss5f7k3Jv6M1iLAjeI0qjZql1L9XOz1cJU9NT4j+QdpYRAqo5uQ6Xa4HmaD 4h99BFUHabpORXI0pNfdVpO/p4DR5w6RgW0AO3zzuRjY4/csAAqOjlnZ5uQ8b93fR1Q2 pZgsuuZcBRreKuM37BSD9v5HCMhq8SPvdf18Ked0UwFkVaugq6ji2/7c301lfqXbMgTO zIeh3TZwtWfVHMurUj0AvYzbREUKmDjeFQgXeQrGQny0dwjY0xdtCzURvPlRfG8iPSIS UOCY8CkuNklRk5umzA7hxrh+EuM2MukAWKcNksgoH8oG1o35jUVpk8RNCgDpwHUFOtlf Wr/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sQCFiGzSC0dQIzc+FHc1PqcfHEnA/cl3jUVDZmdRB1g=; b=Nwzsit+1UowUpFzFqEWzjvIOoOCwrnM6shLKvwdEDo650g0KJgNFbHaaIkOBnigXCs scwwyxG3MW9FsfuT8EBtsznaJkA7PH482KUkM2iufwyOaxL5G7RuagvmPnynzdIxTQ0B VlHvs7frA5lQYAQsPneju9IZubT31W+uOELZm03pdffbUuF/dArx9Ex8qVWaJIRIUWek jrH3Wvn508DskmQ86AM6H/JRc7xM8lWIiUiL5Ed3eav/RGUMfoogyGHFw6xbZp4bR5lM J1CQWhbUli/Y0FgLRIZ89Aow1h0p7cRGCOlH6GS1XKlc1aGprAM/RZ3Hj7tG70KWijak UpeA== X-Gm-Message-State: AOAM5339OUZqrXMsicsRCCbQjVvPZcqQJ1e1aHfOFhJfXDKclPTEY38i elFV5oh1nqGQhZyHT4Fd+CAF6AGNWYVeIR7gSMY= X-Received: by 2002:a17:90b:1b52:: with SMTP id nv18mr27289148pjb.129.1593682276453; Thu, 02 Jul 2020 02:31:16 -0700 (PDT) MIME-Version: 1.0 References: <20200702085520.16901-1-aaron.ma@canonical.com> In-Reply-To: <20200702085520.16901-1-aaron.ma@canonical.com> From: Andy Shevchenko Date: Thu, 2 Jul 2020 12:30:59 +0300 Message-ID: Subject: Re: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid To: Aaron Ma Cc: mapengyu@gmail.com, Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , Thinkpad-acpi devel ML , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote: > > When _BCL invalid, disable thinkpad_acpi backlight brightness control. > > brightness_enable is already checked at the beginning, > Always print notice when enabled brightness control. Why? ... > + pr_notice("thinkpad_acpi native brightness control enabled\n"); 'notice' level is quite high, why do we spam users with this? -- With Best Regards, Andy Shevchenko