Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: NGBI4Fq2mlW8pYu/gBtQwUHP34eXyVplRtl5HUJtxCpGCXLnJ/MuBbRiIRmzdpMA4p/9/RNQ+g
 /sbkW+43EJiw==
IronPort-SDR: MfId8Xsu+pXlIBLT1E+9fv/iiNoFYtd++gWymsw2yHsvG9sWxYALZwFkKAD2yM4c+SnyCT72lE
 YVtF4tDtg/8Q==
Date:   Thu, 2 Jul 2020 12:48:08 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Ricardo Ribalda <ribalda@kernel.org>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi
Message-ID: <20200702094808.GP3703480@smile.fi.intel.com>
References: <20200702093832.2077252-1-ribalda@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702093832.2077252-1-ribalda@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 02, 2020 at 11:38:32AM +0200, Ricardo Ribalda wrote:
> Current AMD's zen-based APUs use this core for some of its i2c-buses.
> 
> With this patch we re-enable autodetection of hwmon-alike devices, so
> lm-sensors will be able to work automatically.
> 
> It does not affect the boot-time of embedded devices, as the class is
> set based on the dmi information.

dmi -> DMI

> Dmi is probed only on Qtechnology QT5222 Industrial Camera Platform

Dmi -> DMI

> https://qtec.com/camera-technology-camera-platforms/

Use DocLink: tag.

...

> +static const struct dmi_system_id allow_probe[] = {

allow_probe -> dw_i2c_hwmon_class_dmi

> +	{
> +		.ident = "Qtechnology QT5222",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"),

> +			DMI_MATCH(DMI_PRODUCT_NAME, "QT5222")

Comma is missed.

> +		}
> +	},

> +

Redundant.

> +	{ }
> +};

-- 
With Best Regards,
Andy Shevchenko