Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0zSfAUnuC4l0WCGHZw1rWCFrqGpXBmN20c40sUwQz0ch9RJ+7nILsaK7UmREFDMQmb9r5TPj3s
 +yyKCcLNMr+Q==
IronPort-SDR: w9kj9NDzTtkykBa7/zC0z5r+hsQ2eXMt9ev/7o9ZxjlZ6+RtQ4YDIKjh7O8Jc/CPweKH78hgU3
 BhzNTWPOyP6Q==
Date:   Thu, 2 Jul 2020 12:49:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Ricardo Ribalda <ribalda@kernel.org>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi
Message-ID: <20200702094958.GQ3703480@smile.fi.intel.com>
References: <20200702093832.2077252-1-ribalda@kernel.org>
 <20200702094808.GP3703480@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702094808.GP3703480@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 02, 2020 at 12:48:08PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 02, 2020 at 11:38:32AM +0200, Ricardo Ribalda wrote:
> > Current AMD's zen-based APUs use this core for some of its i2c-buses.
> > 
> > With this patch we re-enable autodetection of hwmon-alike devices, so
> > lm-sensors will be able to work automatically.
> > 
> > It does not affect the boot-time of embedded devices, as the class is
> > set based on the dmi information.
> 
> dmi -> DMI

...and in the Subject.

> > Dmi is probed only on Qtechnology QT5222 Industrial Camera Platform
> 
> Dmi -> DMI

...and period at the end of sentence.

> > https://qtec.com/camera-technology-camera-platforms/
> 
> Use DocLink: tag.
> 
> ...
> 
> > +static const struct dmi_system_id allow_probe[] = {
> 
> allow_probe -> dw_i2c_hwmon_class_dmi
> 
> > +	{
> > +		.ident = "Qtechnology QT5222",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"),
> 
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "QT5222")
> 
> Comma is missed.
> 
> > +		}
> > +	},
> 
> > +
> 
> Redundant.
> 
> > +	{ }
> > +};
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
With Best Regards,
Andy Shevchenko