Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1357380ybt; Thu, 2 Jul 2020 03:28:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCr7Tmg9V9iE++GLf0DhKSHxYIb6x2qJpWdr5Ly76FrFddij3tdmMkr8KQVpiI66Ot0S/E X-Received: by 2002:a17:907:110d:: with SMTP id qu13mr3039483ejb.217.1593685704814; Thu, 02 Jul 2020 03:28:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593685704; cv=none; d=google.com; s=arc-20160816; b=BVnjg6bcHrtvXvFu0lIbZv2qINz1aImzZiwkJWX+xC76qFgxpUfr+DhZ5YeYA3n+y2 MuncIa1MxI6UtcfFawdyD9qJvbZs1jQRbBskuJPnwXLidlaoZ26aNNWIokY4CLoO5SF9 ES9zfqVrgGVQUPipuPVFPnNFkF9E14xpYrCF9Rv3FrtQx0VnOZpn30IqCtcuDTJqHjvM WpJRft1v6aojfQwWPw/hS/PILrr7JyF8/ni/GTk5AIQqS4jMxcXJsn5ZShPmZ7t59GqQ IkE1q/SB9G9s6IR4ewTVvA7i6kJbLk8gB6rkkrkJUQTuNK1JUXWEYda9/4ihYYCR/s0Y EnDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=gBYdU800xh6dQKjBPuvfkzBmCflHN8ls1rX5bKT5/kw=; b=yzELxoYM7oZNNBZU97VRebgEP+P/M+JUSwcZ/PqGzWyP6JpSk+7XY8AzfsxpwcntE8 hSht2Yp/MpMo7QSqK9gPXE3cQrfof2XMtCn6SZwUlPuMCdnXLWbqkOyKjGVd82YsTK3x bwSWXB9zn0LajihrjR+cUNm3WJCvGA/bVGuTqUW1Sy9kV+ZYVYXpHMGrUJFNcy6+kiq+ Cmr8Ps1dfw1QQm/mBbtnWu61AMiqmS8WbH41yA2I2f0hVQ5Lr3aYKDZ2uSDH5MoIktBB sAbEvk9Em1UmMPgWRI0+hSGudN78BjsSBnqhm4/tfqDq3hOuj2OMaCLFvCtjA9deaO6X aXMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=TsmRNSiu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du1si7454395ejc.616.2020.07.02.03.28.02; Thu, 02 Jul 2020 03:28:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=TsmRNSiu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728427AbgGBKZw (ORCPT + 99 others); Thu, 2 Jul 2020 06:25:52 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:41774 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728335AbgGBKZv (ORCPT ); Thu, 2 Jul 2020 06:25:51 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 062APcbX118477; Thu, 2 Jul 2020 05:25:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1593685538; bh=gBYdU800xh6dQKjBPuvfkzBmCflHN8ls1rX5bKT5/kw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=TsmRNSiukncVTUATe3oOTSwCBh0QmKgK8rCAIytH87fm76e0uXVhwu/fKC2261QxX HhqJ3t4HjwlyrLv3KaQGuQsZjIiJHFmYKbNeMQVU8JtXWYBxceQY57pdNxX5QMfnPI Ey3s+eoCg8LhmFlktxaEicf1hWFgR5hRWJZp4vHU= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 062APcgA000760; Thu, 2 Jul 2020 05:25:38 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 2 Jul 2020 05:25:38 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 2 Jul 2020 05:25:38 -0500 Received: from [10.250.233.85] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 062APW9v117767; Thu, 2 Jul 2020 05:25:32 -0500 Subject: Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication To: "Michael S. Tsirkin" CC: Ohad Ben-Cohen , Bjorn Andersson , Jon Mason , Dave Jiang , Allen Hubbe , Lorenzo Pieralisi , Bjorn Helgaas , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Stefano Garzarella , , , , , , , , References: <20200702082143.25259-1-kishon@ti.com> <20200702055026-mutt-send-email-mst@kernel.org> From: Kishon Vijay Abraham I Message-ID: Date: Thu, 2 Jul 2020 15:55:31 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200702055026-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On 7/2/2020 3:21 PM, Michael S. Tsirkin wrote: > On Thu, Jul 02, 2020 at 01:51:21PM +0530, Kishon Vijay Abraham I wrote: >> This series enhances Linux Vhost support to enable SoC-to-SoC >> communication over MMIO. This series enables rpmsg communication between >> two SoCs using both PCIe RC<->EP and HOST1-NTB-HOST2 >> >> 1) Modify vhost to use standard Linux driver model >> 2) Add support in vring to access virtqueue over MMIO >> 3) Add vhost client driver for rpmsg >> 4) Add PCIe RC driver (uses virtio) and PCIe EP driver (uses vhost) for >> rpmsg communication between two SoCs connected to each other >> 5) Add NTB Virtio driver and NTB Vhost driver for rpmsg communication >> between two SoCs connected via NTB >> 6) Add configfs to configure the components >> >> UseCase1 : >> >> VHOST RPMSG VIRTIO RPMSG >> + + >> | | >> | | >> | | >> | | >> +-----v------+ +------v-------+ >> | Linux | | Linux | >> | Endpoint | | Root Complex | >> | <-----------------> | >> | | | | >> | SOC1 | | SOC2 | >> +------------+ +--------------+ >> >> UseCase 2: >> >> VHOST RPMSG VIRTIO RPMSG >> + + >> | | >> | | >> | | >> | | >> +------v------+ +------v------+ >> | | | | >> | HOST1 | | HOST2 | >> | | | | >> +------^------+ +------^------+ >> | | >> | | >> +---------------------------------------------------------------------+ >> | +------v------+ +------v------+ | >> | | | | | | >> | | EP | | EP | | >> | | CONTROLLER1 | | CONTROLLER2 | | >> | | <-----------------------------------> | | >> | | | | | | >> | | | | | | >> | | | SoC With Multiple EP Instances | | | >> | | | (Configured using NTB Function) | | | >> | +-------------+ +-------------+ | >> +---------------------------------------------------------------------+ >> >> Software Layering: >> >> The high-level SW layering should look something like below. This series >> adds support only for RPMSG VHOST, however something similar should be >> done for net and scsi. With that any vhost device (PCI, NTB, Platform >> device, user) can use any of the vhost client driver. >> >> >> +----------------+ +-----------+ +------------+ +----------+ >> | RPMSG VHOST | | NET VHOST | | SCSI VHOST | | X | >> +-------^--------+ +-----^-----+ +-----^------+ +----^-----+ >> | | | | >> | | | | >> | | | | >> +-----------v-----------------v--------------v--------------v----------+ >> | VHOST CORE | >> +--------^---------------^--------------------^------------------^-----+ >> | | | | >> | | | | >> | | | | >> +--------v-------+ +----v------+ +----------v----------+ +----v-----+ >> | PCI EPF VHOST | | NTB VHOST | |PLATFORM DEVICE VHOST| | X | >> +----------------+ +-----------+ +---------------------+ +----------+ >> >> This was initially proposed here [1] >> >> [1] -> https://lore.kernel.org/r/2cf00ec4-1ed6-f66e-6897-006d1a5b6390@ti.com > > > I find this very interesting. A huge patchset so will take a bit > to review, but I certainly plan to do that. Thanks! Great to hear! Thanks in advance for reviewing! Regards Kishon > >> >> Kishon Vijay Abraham I (22): >> vhost: Make _feature_ bits a property of vhost device >> vhost: Introduce standard Linux driver model in VHOST >> vhost: Add ops for the VHOST driver to configure VHOST device >> vringh: Add helpers to access vring in MMIO >> vhost: Add MMIO helpers for operations on vhost virtqueue >> vhost: Introduce configfs entry for configuring VHOST >> virtio_pci: Use request_threaded_irq() instead of request_irq() >> rpmsg: virtio_rpmsg_bus: Disable receive virtqueue callback when >> reading messages >> rpmsg: Introduce configfs entry for configuring rpmsg >> rpmsg: virtio_rpmsg_bus: Add Address Service Notification support >> rpmsg: virtio_rpmsg_bus: Move generic rpmsg structure to >> rpmsg_internal.h >> virtio: Add ops to allocate and free buffer >> rpmsg: virtio_rpmsg_bus: Use virtio_alloc_buffer() and >> virtio_free_buffer() >> rpmsg: Add VHOST based remote processor messaging bus >> samples/rpmsg: Setup delayed work to send message >> samples/rpmsg: Wait for address to be bound to rpdev for sending >> message >> rpmsg.txt: Add Documentation to configure rpmsg using configfs >> virtio_pci: Add VIRTIO driver for VHOST on Configurable PCIe Endpoint >> device >> PCI: endpoint: Add EP function driver to provide VHOST interface >> NTB: Add a new NTB client driver to implement VIRTIO functionality >> NTB: Add a new NTB client driver to implement VHOST functionality >> NTB: Describe the ntb_virtio and ntb_vhost client in the documentation >> >> Documentation/driver-api/ntb.rst | 11 + >> Documentation/rpmsg.txt | 56 + >> drivers/ntb/Kconfig | 18 + >> drivers/ntb/Makefile | 2 + >> drivers/ntb/ntb_vhost.c | 776 +++++++++++ >> drivers/ntb/ntb_virtio.c | 853 ++++++++++++ >> drivers/ntb/ntb_virtio.h | 56 + >> drivers/pci/endpoint/functions/Kconfig | 11 + >> drivers/pci/endpoint/functions/Makefile | 1 + >> .../pci/endpoint/functions/pci-epf-vhost.c | 1144 ++++++++++++++++ >> drivers/rpmsg/Kconfig | 10 + >> drivers/rpmsg/Makefile | 3 +- >> drivers/rpmsg/rpmsg_cfs.c | 394 ++++++ >> drivers/rpmsg/rpmsg_core.c | 7 + >> drivers/rpmsg/rpmsg_internal.h | 136 ++ >> drivers/rpmsg/vhost_rpmsg_bus.c | 1151 +++++++++++++++++ >> drivers/rpmsg/virtio_rpmsg_bus.c | 184 ++- >> drivers/vhost/Kconfig | 1 + >> drivers/vhost/Makefile | 2 +- >> drivers/vhost/net.c | 10 +- >> drivers/vhost/scsi.c | 24 +- >> drivers/vhost/test.c | 17 +- >> drivers/vhost/vdpa.c | 2 +- >> drivers/vhost/vhost.c | 730 ++++++++++- >> drivers/vhost/vhost_cfs.c | 341 +++++ >> drivers/vhost/vringh.c | 332 +++++ >> drivers/vhost/vsock.c | 20 +- >> drivers/virtio/Kconfig | 9 + >> drivers/virtio/Makefile | 1 + >> drivers/virtio/virtio_pci_common.c | 25 +- >> drivers/virtio/virtio_pci_epf.c | 670 ++++++++++ >> include/linux/mod_devicetable.h | 6 + >> include/linux/rpmsg.h | 6 + >> {drivers/vhost => include/linux}/vhost.h | 132 +- >> include/linux/virtio.h | 3 + >> include/linux/virtio_config.h | 42 + >> include/linux/vringh.h | 46 + >> samples/rpmsg/rpmsg_client_sample.c | 32 +- >> tools/virtio/virtio_test.c | 2 +- >> 39 files changed, 7083 insertions(+), 183 deletions(-) >> create mode 100644 drivers/ntb/ntb_vhost.c >> create mode 100644 drivers/ntb/ntb_virtio.c >> create mode 100644 drivers/ntb/ntb_virtio.h >> create mode 100644 drivers/pci/endpoint/functions/pci-epf-vhost.c >> create mode 100644 drivers/rpmsg/rpmsg_cfs.c >> create mode 100644 drivers/rpmsg/vhost_rpmsg_bus.c >> create mode 100644 drivers/vhost/vhost_cfs.c >> create mode 100644 drivers/virtio/virtio_pci_epf.c >> rename {drivers/vhost => include/linux}/vhost.h (66%) >> >> -- >> 2.17.1 >> >