Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1371708ybt; Thu, 2 Jul 2020 03:53:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY+QiLuhRWGDCPCB3JhGOZ15TnZ+tr/9l3e/VBOXCfbOlp7Mh4ssPVj38rTjIp1ujMzAih X-Received: by 2002:a17:906:7253:: with SMTP id n19mr415314ejk.31.1593687212761; Thu, 02 Jul 2020 03:53:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593687212; cv=none; d=google.com; s=arc-20160816; b=Qe0fElfVPto7DkWp8dFX1A5s0t0kYZKGsLBp7kFBHHb+9VR+1bdTrRuR7EtrAxKQ21 PkyJcwA1Ibs0Kmdy8cHTIawwup+4mump+bWbtMO2uajDRXdwdw34ies3FAb8cPQtxEdm mPNMq7QExe87SFvCznw1kVqLzQ46YDYu+5cCkec9gzHLDWIOCoTpGLxjzz4m5hr7SV5m gWSPZCdi0GF5s/eKIY9QdFfxg5lgcUeZ/IQr7n7dNQriZCkqQ6upfnpy3SHqdsLicSAQ /FjLDi+r8TkOluUu8rtnFs6h5o+5VyrjENIlY/KWZYkPz4rr+3E0rrezbqyAPMpptJHG GFzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=drChNlxcy1j7DWolOPxnni1XV6e7rQD0yHkq4Xzr4b4=; b=SEq7V5+GWFpTMkHEBtPYn2r8myJMOPo1TyoGlZm6WqYUKsR/bLL5nxrDjJ2p2uCRxf 1U6wiQAgkp+Tjlmylg4ixYTjliPZ6AH1q3rG4NXaGeExYXUVdOdKL/5fvt+n6mI5ocuP QIQUzzHXJOXaCGCbc7YsM5ftWGJ7jNIALZPj6auksjtCIwoEfQ6wQcb/bE5GPfieFQZH Qcw3V1zjBWubCo+AgGQv3QgfvqCaYyS/7p4AlTn3ToLbbrkdKlQtSAzT6dJmwPFsnJ5E qaUNZHRFta3TlTMVtH2KJuPKVtXvY2qVIUdjshOzpXgC2t3AFFtUbjZZyV7/8JdAFgAP oJMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mf17si5669964ejb.86.2020.07.02.03.53.09; Thu, 02 Jul 2020 03:53:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbgGBKv1 (ORCPT + 99 others); Thu, 2 Jul 2020 06:51:27 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39782 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726483AbgGBKv0 (ORCPT ); Thu, 2 Jul 2020 06:51:26 -0400 Received: from [222.129.43.254] (helo=[192.168.1.10]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jqwoL-00013y-I3; Thu, 02 Jul 2020 10:51:22 +0000 Subject: Re: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid To: Andy Shevchenko Cc: mapengyu@gmail.com, Henrique de Moraes Holschuh , Darren Hart , Andy Shevchenko , Thinkpad-acpi devel ML , Platform Driver , Linux Kernel Mailing List References: <20200702085520.16901-1-aaron.ma@canonical.com> From: Aaron Ma Autocrypt: addr=aaron.ma@canonical.com; prefer-encrypt=mutual; keydata= mQENBFffeLkBCACi4eE4dPsgWN6B9UDOVcAvb5QgU/hRG6yS0I1lGKQv4KA+bke0c5g8clbO 9gIlIl2bityfA9NzBsDik4Iei3AxMbFyxv9keMwcOFQBIOZF0P3f05qjxftF8P+yp9QTV4hp BkFzsXzWRgXN3r8hU8wqZybepF4B1C83sm2kQ5A5N0AUGbZli9i2G+/VscG9sWfLy8T7f4YW MjmlijCjoV6k29vsmTWQPZ7EApNpvR5BnZQPmQWzkkr0lNXlsKcyLgefQtlwg6drK4fe4wz0 ouBIHJEiXE1LWK1hUzkCUASra4WRwKk1Mv/NLLE/aJRqEvF2ukt3uVuM77RWfl7/H/v5ABEB AAG0IUFhcm9uIE1hIDxhYXJvbi5tYUBjYW5vbmljYWwuY29tPokBNwQTAQgAIQUCV994uQIb AwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRDNxCzQfVU6ntJ9B/9aVy0+RkLqF9QpLmw+ LAf1m3Fd+4ZarPTerqDqkLla3ekYhbrEtlI1mYuB5f+gtrIjmcW27gacHdslKB9YwaL8B4ZB GJKhcrntLg4YPzYUnXZkHHTv1hMw7fBYw82cBT+EbG0Djh6Po6Ihqyr3auHhfFcp1PZH4Mtq 6hN5KaDZzF/go+tRF5e4bn61Nhdue7mrhFSlfkzLG2ehHWmRV+S91ksH81YDFnazK0sRINBx V1S8ts3WJ2f1AbgmnDlbK3c/AfI5YxnIHn/x2ZdXj1P/wn7DgZHmpMy5DMuk0gN34NLUPLA/ cHeKoBAF8emugljiKecKBpMTLe8FrVOxbkrauQENBFffeLkBCACweKP3Wx+gK81+rOUpuQ00 sCyKzdtMuXXJ7oL4GzYHbLfJq+F+UHpQbytVGTn3R5+Y61v41g2zTYZooaC+Hs1+ixf+buG2 +2LZjPSELWPNzH9lsKNlCcEvu1XhyyHkBDbnFFHWlUlql3nSXMo//dOTG/XGKaEaZUxjCLUC 8ehLc16DJDvdXsPwWhHrCH/4k92F6qQ14QigBMsl75jDTDJMEYgRYEBT1D/bwxdIeoN1BfIG mYgf059RrWax4SMiJtVDSUuDOpdwoEcZ0FWesRfbFrM+k/XKiIbjMZSvLunA4FIsOdWYOob4 Hh0rsm1G+fBLYtT+bE26OWpQ/lSn4TdhABEBAAGJAR8EGAEIAAkFAlffeLkCGwwACgkQzcQs 0H1VOp6p5Af/ap5EVuP1AhFdPD3pXLNrUUt72W3cuAOjXyss43qFC2YRjGfktrizsDjQU46g VKoD6EW9XUPgvYM+k8BJEoXDLhHWnCnMKlbHP3OImxzLRhF4kdlnLicz1zKRcessQatRpJgG NIiD+eFyh0CZcWBO1BB5rWikjO/idicHao2stFdaBmIeXvhT9Xp6XNFEmzOmfHps+kKpWshY 9LDAU0ERBNsW4bekOCa/QxfqcbZYRjrVQvya0EhrPhq0bBpzkIL/7QSBMcdv6IajTlHnLARF nAIofCEKeEl7+ksiRapL5Nykcbt4dldE3sQWxIybC94SZ4inENKw6I8RNpigWm0R5w== Message-ID: <2ecf4032-267c-32c8-361f-2396730aaa65@canonical.com> Date: Thu, 2 Jul 2020 18:51:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/20 5:30 PM, Andy Shevchenko wrote: > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote: >> >> When _BCL invalid, disable thinkpad_acpi backlight brightness control. >> >> brightness_enable is already checked at the beginning, > >> Always print notice when enabled brightness control. > > Why? > Default brightness_enable = 2, so this message will always be printed as before Actually no change here. > ... > >> + pr_notice("thinkpad_acpi native brightness control enabled\n"); > > 'notice' level is quite high, why do we spam users with this? > Like above. Another reason is most thinkpads are using native gpu driver to control brightness, notice when thinkpad_acpi brightness is enabled. Aaron