Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Angelo Dureghello <angelo@sysam.it>
To:     Robin Gong <yibin.gong@nxp.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-imx@nxp.com" <linux-imx@nxp.com>
References: <1593449998-32091-1-git-send-email-yibin.gong@nxp.com>
Subject: Re: [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE
MIME-Version: 1.0
Date:   Thu, 02 Jul 2020 13:15:15 +0200
Message-Id: <979851593688387@mail.yandex.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=utf-8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Robin,

29.06.2020, 10:53, "Robin Gong" <yibin.gong@nxp.com>:
> Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
> '0x0005 --> BIT(3) | BIT(0))'
>
> Fixes: 4d6d3a90e4ac ("dmaengine: fsl-edma: fix macros")
> Cc: stable@vger.kernel.org
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> ---
>  drivers/dma/fsl-edma-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
> index 67e4225..ec11697 100644
> --- a/drivers/dma/fsl-edma-common.h
> +++ b/drivers/dma/fsl-edma-common.h
> @@ -33,7 +33,7 @@
>  #define EDMA_TCD_ATTR_DSIZE_16BIT BIT(0)
>  #define EDMA_TCD_ATTR_DSIZE_32BIT BIT(1)
>  #define EDMA_TCD_ATTR_DSIZE_64BIT (BIT(0) | BIT(1))
> -#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(3) | BIT(0))
> +#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(2) | BIT(0))

looks like i need some glasses. Thanks a lot for the fix.
I probably missed it since not using 16bytes transfers.

Tested-by: Angelo Dureghello <angelo@sysam.it>


Regards,
angelo

>  #define EDMA_TCD_ATTR_SSIZE_8BIT 0
>  #define EDMA_TCD_ATTR_SSIZE_16BIT (EDMA_TCD_ATTR_DSIZE_16BIT << 8)
>  #define EDMA_TCD_ATTR_SSIZE_32BIT (EDMA_TCD_ATTR_DSIZE_32BIT << 8)
> --
> 2.7.4