Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 2 Jul 2020 16:11:52 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Jason Gunthorpe <jgg@mellanox.com>
Cc:     Doug Ledford <dledford@redhat.com>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, Maor Gottlieb <maorg@mellanox.com>
Subject: Re: [PATCH rdma-next 0/6] Cleanup mlx5_ib main file
Message-ID: <20200702131152.GD4837@unreal>
References: <20200702081809.423482-1-leon@kernel.org>
 <20200702130809.GU23821@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702130809.GU23821@mellanox.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 02, 2020 at 10:08:09AM -0300, Jason Gunthorpe wrote:
> On Thu, Jul 02, 2020 at 11:18:03AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Over the years, the main.c file grew above all imagination and was >8K
> > LOC of the code. This caused to a huge burden while I started to work on
> > ib_flow allocation patches.
> >
> > This series implements long standing "internal" wish to move flow logic
> > from the main to separate file.
> >
> > Based on
> > https://lore.kernel.org/linux-rdma/20200630101855.368895-4-leon@kernel.org
>
> Isn't this the series you said to drop? Can this be applied
> independently?

I asked to drop one patch in question, the one that revealed issue with
reference counting and convoluted error unwind flow.
https://lore.kernel.org/lkml/20200630145926.GA4837@unreal

It probably can be applied independently, but I didn't try.

Thanks

>
> Jason