Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1591413ybt; Thu, 2 Jul 2020 09:01:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1O31WO0uRpvYU7iFvT2PjBIXu1vDPe0X6J2JAh/jjS6bhUSwqpk9FT5g2hN3zBYofGdBE X-Received: by 2002:a17:907:2108:: with SMTP id qn8mr23857509ejb.16.1593705694037; Thu, 02 Jul 2020 09:01:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593705694; cv=none; d=google.com; s=arc-20160816; b=igrhFEBipsDEhLLcjx3OrcqG2cW8pBxQl+Te4nKuKjMvpmth5VQ5e6UurTxyhC0M/H ijx96kdZymoc9HOGQP1e9PvEPn7BMgHg5+9uAkWeKco5ApretMfcX1RyKsT9xkjfC2n6 cNHQw7CLHAI5Es4ummTrE48Y2I8VqE4IIqUBnji32tQUafzxZ8TtEsFDL7nHAU+7kXAX WVNMp9UlPXzxJgeeVy/rwmxnJQw7OtFe3RDNqNRxvsPov20BoyNx+G+5I2+3HirMJQkk Hfy71mhCnvJ9M9dVvlIBKy5nKH1L8y1o/LGTN8IT/HzMTnWaTBKOEgdmNDv+y0zBLmwy tDLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=UM6d60LG+LwfEeTTxwgWbfhDfaDIYVHNWKuWoe67kAc=; b=1Ac+sTFmYdYFUCM+S8o7oGm0Jkkx5upxGXPVS59IFSgx95gRrZWR9e7+ZSuLmPsWkV EOgVIyQkY4yRxkh7MOZ3/HXL6f8WSlyKqi5ns0zuldlxTZRo2MXjx3oVLpBfISsSPUje MAw47yBBnbQQ4sHCrNI9l76R1OIUJJTkFNrfENmRqC4/MTzgdNJTwH5b2QtstB3s/0am mJxu/JebumNc8AAdRzV5E8qlSkpiuNPZ3ijaFCADT5JDqXVpCFdMno+NaQCm54kPIcwK rayDZacneS+I5OYtzde6i23c0huh/AFyvAXhwOJEbwa70Oz/zq62IoCa7CXauuXcz1H6 N+qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd13si3858158edb.153.2020.07.02.09.01.10; Thu, 02 Jul 2020 09:01:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbgGBQBA (ORCPT + 99 others); Thu, 2 Jul 2020 12:01:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:38956 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbgGBQBA (ORCPT ); Thu, 2 Jul 2020 12:01:00 -0400 IronPort-SDR: ymFLz1hv0Ok17xOhw2sa88x5qq6dnt0nchufVV+bFJ6hUbCdVP1QS7dAD/SSNiswKGe7w6jdtQ 3mhQaMbZYybQ== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="148484204" X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="148484204" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 09:00:59 -0700 IronPort-SDR: uhwaa7uGNaoqs+PK3xjQnx7NweL6s2+zvtP9lCnnjnKJs+Ggylown6aJ0ORyzmj9w3md68k77K CwvEPA5TFikA== X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="304292241" Received: from nchava-mobl1.amr.corp.intel.com (HELO [10.252.135.144]) ([10.252.135.144]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 09:00:58 -0700 Subject: Re: [PATCH AUTOSEL 5.7 15/53] ASoC: SOF: Intel: add PCI IDs for ICL-H and TGL-H To: Mark Brown , Sasha Levin Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, Kai Vehmanen , linux-kernel@vger.kernel.org, stable@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20200702012202.2700645-1-sashal@kernel.org> <20200702012202.2700645-15-sashal@kernel.org> <20200702111835.GB4483@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <0baf17f3-1af8-a4a1-644c-ab27490f9b44@linux.intel.com> Date: Thu, 2 Jul 2020 10:42:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702111835.GB4483@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/20 6:18 AM, Mark Brown wrote: > On Wed, Jul 01, 2020 at 09:21:24PM -0400, Sasha Levin wrote: >> From: Pierre-Louis Bossart >> >> [ Upstream commit c8d2e2bfaeffa0f914330e8b4e45b986c8d30b58 ] >> >> Usually the DSP is not traditionally enabled on H skews but this might >> be used moving forward. > > "This might be used moving forward"? There are two conditions for the SOF driver to be used in a distro: a) the DSP needs to be enabled (as reported by the pci class info) b) sound/hda/intel-dsp-config.c needs to contain a quirk to select SOF over the legacy HDaudio, such as presence of DMIC/SoundWire or a known vendor DMI. Traditionally for desktops neither a) nor b) are true, but this is changing: we will start adding quirks for specific product lines as requested by OEMs. Does this answer to your question?