Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1638252ybt; Thu, 2 Jul 2020 10:03:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXmD4qRUi4+wkqtYhrpDyqrENDllFXoWkzzjXJgpFurgVwMeY53s3TvgFh6GtBmJY1do8o X-Received: by 2002:a05:6402:228d:: with SMTP id cw13mr36341022edb.343.1593709418513; Thu, 02 Jul 2020 10:03:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593709418; cv=none; d=google.com; s=arc-20160816; b=JkgSEo0YEfa7DwK7ZwXzAmXPgWxxz1216WRIxM+i9ivWB1r3iTZ8RVhXbcsnf7siWI WU1d8ZYszan6NPMSyizNyQ3xH9ib3A6UVZUHJqP6gFJUBXVlWqKNmDlLIJRHiPRZIQS8 ksdiiYygJzn5sFqnudByafI41cxO3mCq/fnketl3OMubvm2Ypisg/7AVda0MvVkgwcEk A4Yg5MPKHIkmmD+zVaTJ4k0pOW5iOW5bzFU2gax3GQwPUKfHSS3naqoxrXr4fMVEC1hc 1CzYJ/5s5nLz22nlrK6zjTNmQgkjJzNVhRN+IPYwdd2TH4jSjuAJsN925RONlLHNWIog mdfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=15anBeQJObRffdqVOXy6onNX1z4WUhSf01MmlhBDonI=; b=gS4VLIbQ4vCsONExPI50Ul7qMldliDaPPgjWySq5u5R5TQlj9390yYv+yibpT96dvx J2saBaF9njmBg/FEil0VDwWgdyvkKt32CTneOzBI9w0bamk47wUBeAtHLZsHyLzvr665 sQdw0LAYg21mu+FcOW2tfh6Vy9D/xUyOzyvHjOCC6hqdHBB+p0bBkP3Bx/ODr1cXtESo HWiGOI2squZT61gnTnFSzGnP5Hfay1z6iP4Zia18cRl4/hGrYaCaVh3s0Xl7xHiHyvhz BZkbZ5ESEpwXrAQ4W9gL5HmzvYETN+X4Rx7j2WRCPWsQWSwHfZCdXCwDH2w/E3HkouTj Zmyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dNHu7uww; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si6474119edp.98.2020.07.02.10.03.15; Thu, 02 Jul 2020 10:03:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dNHu7uww; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgGBRCs (ORCPT + 99 others); Thu, 2 Jul 2020 13:02:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:32856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726754AbgGBRCs (ORCPT ); Thu, 2 Jul 2020 13:02:48 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F027206E2; Thu, 2 Jul 2020 17:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593709367; bh=bDQl5qvzxkTi9ZCnxC0GowCAYQCv6zA9MuDUFOcZCJo=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=dNHu7uwwlByzYKVhuYPFATnwTsNThKdOicvR2SDQ5sqxC1EWT2ma5t6qetH3p5nXQ s30IMGZp9b36Ba7H/OPmmq07+r9roQWe5oYdftQXYo63br5zauxZdJEVDvmQCr0g97 YRk1iV7hPxB+jvIsmUlzIoOEFbcGvy9uRoUxrnz4= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 589AE3523164; Thu, 2 Jul 2020 10:02:47 -0700 (PDT) Date: Thu, 2 Jul 2020 10:02:47 -0700 From: "Paul E. McKenney" To: Wei Yongjun Cc: Hulk Robot , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] scftorture: Make symbol 'scf_torture_rand' static Message-ID: <20200702170247.GS9247@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200702144700.3602-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702144700.3602-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 02, 2020 at 10:47:00PM +0800, Wei Yongjun wrote: > Fix sparse build warning: > > kernel/scftorture.c:124:1: warning: > symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Good catch, applied, thank you! Due to recent changes, I hand-applied this as shown below. Please let me know if I messed anything up. Thanx, Paul ------------------------------------------------------------------------ commit ff9210137b0b8d8f045dd1fd116253ba7686e892 Author: Wei Yongjun Date: Thu Jul 2 09:56:50 2020 -0700 scftorture: Make symbol 'scf_torture_rand' static The sparse tool complains as follows kernel/scftorture.c:124:1: warning: symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static? And this per-CPU variable is not used outside of scftorture.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Signed-off-by: Paul E. McKenney diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 52f74f1..a7fea76 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -134,7 +134,7 @@ static atomic_t n_alloc_errs; static bool scfdone; static char *bangstr = ""; -DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); +static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); // Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print(void)