Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1668468ybt; Thu, 2 Jul 2020 10:48:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFi+Emrhrln7bDQUm7MyRwvHbeIOlwnNYPN5SWKFeCOW1NQ/l2Aha3Jj599JFAUQhFzXuM X-Received: by 2002:a17:906:c451:: with SMTP id ck17mr29661763ejb.80.1593712123450; Thu, 02 Jul 2020 10:48:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1593712123; cv=pass; d=google.com; s=arc-20160816; b=L3bkzBlEZqH6AHZ8TNM+S43aUikZrKGT2tCkSrLZ8Rx8lhS7gd1EK+hF7Oa2m+BPmh L4h8E8N85ET7kqgWoT9mGqaP3Mqy9lvLb+AG0CDGTxppWq+6WH/j3A+XQ6hxFrpl4nYE S2e1ZMYr4X4QlhYIVU/1lBHdY4oaZ716rArk1sCHWd40RiBrKKwgORYL33x+H5h6Jnk/ XGYGP7hwJ3/Nm76QKtt+CLr8Fb31sLenOX1rysfiGfVMtFnfVHhFm+UGQLGc1SlZqXBG E/MMyyj46doLg3ECu08VkoekdUilcD6IqsK0dShKmib3DBmy7c8D9I6cMcG59C3cICu1 BIQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-language :content-transfer-encoding:in-reply-to:user-agent:date:message-id :from:references:cc:to:subject:dkim-signature; bh=hGdh+FcVEqE4DGhUiMS9vKl1jyo1XzQ/gb+eZVB/uEQ=; b=DQz5j/U790eWsyAm1QUJGZIDLpfx7NIK/xrm9SfiQxIgKo6NfGmx5VPk8/Jam812PT nDleiv8EvQbMDoDUguSmEkSpBg0NsTZVIJFwNJxQH5K/+oMT38rWu5mTaH9Wqn43aP+f YPM+2WQXqRlzgkRcUloQHmTUoNTaFQhMht+4e6vXKqHXLoxXxR1HlYDf3ffGcJCgIzpd I0IEXYHHqCVTwrSb+EG/6OgYsNKx1CkexpBG++5Y/3wsJa1OnuXdIuOxw1vHkUapHpmk NLmXzcMJDLMG2cswMFYsqib0GlHNG8wAhWWlH60YKmUstjp92Gk70eiu48pr48pkl3fr IEVQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=cbiVtJcH; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si6306947edr.185.2020.07.02.10.48.20; Thu, 02 Jul 2020 10:48:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=cbiVtJcH; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgGBRsI (ORCPT + 99 others); Thu, 2 Jul 2020 13:48:08 -0400 Received: from mail-eopbgr70045.outbound.protection.outlook.com ([40.107.7.45]:19061 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726997AbgGBRsH (ORCPT ); Thu, 2 Jul 2020 13:48:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gv3Mnpskq3OEt8cbWf5QpT53IGHNFcFUplX+AfD/QAi3j0/UbIJ4XIBjV0369mHAt5ie9QrH39gVz73uQvwoNfDUF2bYWyWIuS18JoUjLSouC+tLqPX/U7GBai4/vQsLnoMtdfBtsUmrf3EHiXrEGcZ8R1s4N7G8+FUvNLqltXCy4tYknGQ7qLaCbnGPTjl9vKKG4pwdwuTlQMyxDh63hPShEAa9GItpsrxHZ29S16DxEQ6yGdZRC9SeuKkbGTGjkFDFTlTCOsy61IE+fu6IN7HYwt7hg9CG/ol1Z5qeS/JxnqJH6JVhDXnvp16dgxuNEt9ArUoZ+yFiKUM5RlWCdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hGdh+FcVEqE4DGhUiMS9vKl1jyo1XzQ/gb+eZVB/uEQ=; b=KwtLw7wGj6//lAEIciIv5Z/kwOkGiDobzvd9wUhd++Qb+pBYN78mpf/Vc95aGw3/h4sLhiyp391EFKOv41VQaDt2BCg2NeCtuGTKmNrz8wTXa0n4t0spUmkoppY0T7WqZpVd+WU7PPFAa2j/7wRVJzUmu2B5tf3Tq22GnHhR+J928/FqSAbYUZ3xtqXqDubGYDtFPc+hq5S1XeBo35qRIDJ3bv40JmfGRKGE/LttzPoFmixBcL9zXf1uLLFIMQL9b4lTN3KBTraX4vpqk+sdwcWYy8WihvTZtdRXemYcFUlVPhHXSUKW+uAHe5ys6eIPuQwnip3USVgIg1SMCXCtKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hGdh+FcVEqE4DGhUiMS9vKl1jyo1XzQ/gb+eZVB/uEQ=; b=cbiVtJcHel1UlctNQuLpRF7QvhJqHS8UhNTgN5oBbuV44C3olZT2jhsiQCW2DSNDbJScMNXWjHS/Y1It4hSMLcLvxb8GtpSn06f1RTGZ8dYXIcC2Lt7GloP72v82BFtCoejIscD2yGH2NJunUsh+9Ljz8WeaxHwwwoxqaxZ/FCc= Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4290.eurprd05.prod.outlook.com (2603:10a6:208:63::16) by AM0PR0502MB4052.eurprd05.prod.outlook.com (2603:10a6:208:9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Thu, 2 Jul 2020 17:48:02 +0000 Received: from AM0PR05MB4290.eurprd05.prod.outlook.com ([fe80::21b3:2006:95aa:7a1f]) by AM0PR05MB4290.eurprd05.prod.outlook.com ([fe80::21b3:2006:95aa:7a1f%3]) with mapi id 15.20.3153.024; Thu, 2 Jul 2020 17:48:02 +0000 Subject: Re: [PATCH net-next 5/7] devlink: Add devlink health port reporters API To: Jakub Kicinski Cc: "David S. Miller" , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladyslav Tarasiuk References: <1593702493-15323-1-git-send-email-moshe@mellanox.com> <1593702493-15323-6-git-send-email-moshe@mellanox.com> <20200702094053.50252366@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Moshe Shemesh Message-ID: Date: Thu, 2 Jul 2020 20:48:00 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 In-Reply-To: <20200702094053.50252366@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: AM3PR07CA0089.eurprd07.prod.outlook.com (2603:10a6:207:6::23) To AM0PR05MB4290.eurprd05.prod.outlook.com (2603:10a6:208:63::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.223.0.91] (193.47.165.251) by AM3PR07CA0089.eurprd07.prod.outlook.com (2603:10a6:207:6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.9 via Frontend Transport; Thu, 2 Jul 2020 17:48:01 +0000 X-Originating-IP: [193.47.165.251] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e50c218b-6965-4bd9-4ee3-08d81eb0112f X-MS-TrafficTypeDiagnostic: AM0PR0502MB4052: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-Forefront-PRVS: 0452022BE1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OTMClVUfJzP4LBEFHe8mkcQ8EnbmaKqzS99XE22KFaccRO/e2SFQ/FQfFHj3rj1vDWbIGjqU9xwH+zjVSUgg/AHcqnbiYsnNh2HZznaI/Fi9TO8LCChjDW9SWEaeWU2FEHZnA1nvI0sXO1bnNBmFB0ZtdJsfEXs/naZcLeXN4rhW2+/rasNw14eBnRp47zx0oOBQ71PAOULTbM9Y7KdVcVjNc7K8+tl8tCAgTAbYFf1xW9MNaw6SyolqAUHT+bN4MH6Jgz5anqa8Mvq5V9q5IyfbCsW1G5fU7c84CbNzcq6n5ZICYML9pQGhGr68l5OPZ5A4pQ6vxLVNM9gL0zLeuEU5xQK5wfIPJ/lWTt8ZIprJeWzIAKcGzpb44gqrXmxC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4290.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(66476007)(83380400001)(31696002)(16576012)(66946007)(6916009)(52116002)(54906003)(107886003)(4744005)(86362001)(8936002)(2906002)(316002)(8676002)(31686004)(53546011)(66556008)(956004)(4326008)(478600001)(36756003)(16526019)(186003)(26005)(6486002)(2616005)(5660300002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: jHGgoN7x6717kfmd/7c8W7RfsdwyDaG9GkV/kv4tpwlGHc0OPVRVfI09Y8K4gc3nV75qxFmVpfe+G9WuX89AFipO0U8mEmPXnWWDV8DITGx1ag1y2ZdJ7cTL7gOi5L6GfwFPs7koIMVZOvKvOMmeYTiLP8yAnAbfysOTASRr4X5MRzMC2mX5CVOx1uSzaxgI+0rUz1Eb48WeChgDmeSvk3HnKyIb7YYL9WJZDdqp27/hr1QHea5AGTMsOcfHZDLlqf9H865C7PKD67o3OTsWTRY9zn5JeizrdQyb1mN87pxKuRUwpPwREUyJbjBhiujYvyhKNvoudmckHVsl0cDojpwH2yGnx4VSqwZjhidonp+uy2FLq91AgIx95Jc/67gNPlnno5qcXco1NkZtrPkT9bQCRY6IuNT2ktkDQKYH/G8wJCpJazoJgQ6TtZL3f0rpvLxgyS31e23+YX7sgrtTbwDL4ujgh61YlivwXI8Zgstnq/UV6FH4arV/YLyFa5vT X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e50c218b-6965-4bd9-4ee3-08d81eb0112f X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4290.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2020 17:48:02.6124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gdpg1+Db7mSpwxQYbjkRvJPtWrwvrQxpNIVfdPbiGVQcQcZ6Q50EtTj9dQUbExqE6ubz0YfD/Grotj2zdUnwDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4052 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/2020 7:40 PM, Jakub Kicinski wrote: > On Thu, 2 Jul 2020 18:08:11 +0300 Moshe Shemesh wrote: >> From: Vladyslav Tarasiuk >> >> In order to use new devlink port health reporters infrastructure, add >> corresponding constructor and destructor functions. >> >> Signed-off-by: Vladyslav Tarasiuk >> Reviewed-by: Moshe Shemesh >> Reviewed-by: Jiri Pirko > net/core/devlink.c:5361: warning: Function parameter or member 'port' not described in 'devlink_port_health_reporter_create' > net/core/devlink.c:5361: warning: Excess function parameter 'devlink_port' description in 'devlink_port_health_reporter_create' > net/core/devlink.c:5462: warning: Excess function parameter 'port' description in 'devlink_port_health_reporter_destroy' I will resend with a fix. Thanks.