Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1718850ybt; Thu, 2 Jul 2020 12:05:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjB+RIpiQPXrtrkt5OIbX/tCd5VP7G6pcHxNY5DYShwOOAPn+7NuWxL6GJEC/4BYZHgL6e X-Received: by 2002:aa7:d6cf:: with SMTP id x15mr35571353edr.164.1593716709337; Thu, 02 Jul 2020 12:05:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593716709; cv=none; d=google.com; s=arc-20160816; b=DH/E9aTbsBY8yQi6iOHjClu9JXEQYm5CDmpVr1oR2+gCRNExfFYjbHBeq8fp2WcKSa r8ugJXp8R8xaj10NwVVP9QpoyeTi9RmNTq8FkP5QkuPporA8SsOGwUTnFmbl2aOOu3JI UdPOwfYQ/PDpRDXRu/XgtoV0GVrt5vMY3YnVcFCp6WzP0/t2+iRNGIEfsfF+4TemNYfB c5qbEs0HrWfm/FDf3w+u13SFkhHY7AIloBCA/CordFVgVY5m2OC7ll3AE08RNQGYUosu 5KZDRHVSkZdJsEUcZ7WOG3XRzJDiaTbt6eq6pmaUKgzYxnks+eWaP/RnAkMcnWA3Zt7P Xn+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=iuAm8s1WYFDMMoa4G/kw9BTCdpxefLz6wzfgPDgr0iY=; b=iBMkHZqEG/WfHY51RdOw3Xg+WLNYN47KkRcKXe/8kAYPQHbBfBzMbYLOTtjtnifW+K I/X2DFQGIce9Okv1t0xUax4rnXOcBT/M9Tat6U6SJJE55ubmRCIrq0u1gBNlFyOgqLXY kN+6/a2u19ElN1ZqK3Gnk4g8DTXrAlFa0j/WV5ODne8vDUpEdR1NA3cO7v56lpLUtshs FNLg/9mHdnT5bTgr5IRSMGkLxqkad4Z6/79xkvsco+NWdruO1KR03JL4dY1YAL/5lMyb x6rkV5N/vnrF1vWaHnvLQBsxytWDc9ew6PkwSy3pgp510/UOzPYBUVbq06xwToVRpBsu 9byw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b4si6692177edk.454.2020.07.02.12.04.45; Thu, 02 Jul 2020 12:05:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbgGBTEB (ORCPT + 99 others); Thu, 2 Jul 2020 15:04:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:13360 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgGBTEB (ORCPT ); Thu, 2 Jul 2020 15:04:01 -0400 IronPort-SDR: SuwFQLU1K6qmjJsHFYMv0dNN/XyN575q3Cae1O9+NotPzAbIp8QA0JYlHHRl+nV3zZYL0xjnOF uSAKfHmzQumA== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="165054876" X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="165054876" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:04:00 -0700 IronPort-SDR: gnOBcBliBICPHYLlTAPB2fAVH+V8bYokR4W/N0dEdoSDStXp83ufUbFjAeqPKRu7wvhjleJ1g5 aUDy828pShMw== X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="295989116" Received: from dhprice-mobl1.amr.corp.intel.com (HELO [10.254.75.219]) ([10.254.75.219]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:03:59 -0700 Subject: Re: [PATCH 6/6] ASoC: fsl: fsl_esai: fix kernel-doc To: Nicolin Chen Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Timur Tabi , Xiubo Li , Fabio Estevam , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "open list:FREESCALE SOC SOUND DRIVERS" , open list References: <20200702172227.164474-1-pierre-louis.bossart@linux.intel.com> <20200702172227.164474-7-pierre-louis.bossart@linux.intel.com> <20200702185556.GG23935@Asurada-Nvidia> From: Pierre-Louis Bossart Message-ID: <2191ccbf-5c94-62e5-33b0-635284e5a8c6@linux.intel.com> Date: Thu, 2 Jul 2020 14:03:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702185556.GG23935@Asurada-Nvidia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/20 1:55 PM, Nicolin Chen wrote: > On Thu, Jul 02, 2020 at 12:22:27PM -0500, Pierre-Louis Bossart wrote: >> Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters. >> >> Signed-off-by: Pierre-Louis Bossart > >> + * fsl_esai_set_dai_sysclk - This function mainly configures the clock frequency of MCLK (HCKT/HCKR) > > Can drop "This function mainly" > >> /** >> - * This function configures the related dividers according to the bclk rate >> + * fsl_esai_set_bclk - This function configures the related dividers according to the bclk rate > > Here too -- dropping "This function" will fix both, thanks for reviewing the edits. > > Otherwise, > Acked-by: Nicolin Chen > > Thanks! >