Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1745388ybt; Thu, 2 Jul 2020 12:45:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7zfQRmOG/15ISPm66rkkB46QYs1RmGfRs3nL8vi52lInVyIhrAu2SrpA6esBKQXet3QAB X-Received: by 2002:a17:906:19c9:: with SMTP id h9mr27818388ejd.526.1593719132360; Thu, 02 Jul 2020 12:45:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593719132; cv=none; d=google.com; s=arc-20160816; b=jTOIaSAadsuMUiHVYc0k2e3f7R+H1AGt5R2uU/FgXqDNoN4VZfHzooxAlTxzMHZ29E vKIZ8Fksb6z6SbXQR2H6wbshUySltSk+I79z6PEeFlQ6hZIlvA32/zWHbGdoCZDfRKfg lLuEI1aHGTPPCHjA31WnQmJeC5Mpd/egsSBZ+I9nJsQAECJnjzMBEIgx+9oJ7MDIouF3 PIsMWSOe9yQM5tj4ScF2r6eAHi61zyKiryrLRJQUPnIbDIcUP9h75RgOEWxfmgqLeHwM PxuDUz6Osjddh/6e4/ldLJX4RlxSNsljrwETksO6M6Fz/do2nR0Wrj7AkH7k9Vb0QgcS t0ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=iHs13p9NuUarzJjQ/8cSTL6u8PBy0KT/hFdbSXe+ok8=; b=LJmVDQR4hJ9BY7YE7FS53uN8s6qwvp/bm808I/WRj1uHlHjXLCGcZasU7VvNZhutBy 6tQuObPo54PEFB1Kx2Y0d59ByXLN/j9WPXY45jlLGmM5o+BPIzAvMMaOSsdTJmmh0N3Y X+qPiZfzP/qhPsdhOZFkPyuda7eOW+zdGbGCbd6Id87iPZcOsXih9HIQNTVGnWYn4V0H qDrGkEAtwacT4TiWCKDAdkyd2Cy5sfpDsdt3xY4B0223JjqY3P95uw19zqOdVCNNnjqD hF2dowAT6wIDKh8EhIoL0RChSiILXkH7juAq7CY4mNOd7sbjRHo9EXxOrWigJEoazri9 Un5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si6073469eje.610.2020.07.02.12.45.08; Thu, 02 Jul 2020 12:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbgGBTox (ORCPT + 99 others); Thu, 2 Jul 2020 15:44:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:5385 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGBTox (ORCPT ); Thu, 2 Jul 2020 15:44:53 -0400 IronPort-SDR: 1t0tLXLFVra7Tc12dqK9rZ3OAKEKe2oE/MA6/JsncQJROVljLKxlXd56GM8N2is1HXjz09kZZz 0LFGbbbWQUBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="134474655" X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="134474655" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:44:52 -0700 IronPort-SDR: Zywr3ldWei8/LIeUJeTPM6lvkCxsULkQd9GBaC0hsSX9Jgx0hUtKk1vrwZa3EodiWQXny9irbt ClkuoJnM9zbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="387429233" Received: from frichard-mobl.ger.corp.intel.com (HELO localhost) ([10.249.44.59]) by fmsmga001.fm.intel.com with ESMTP; 02 Jul 2020 12:44:49 -0700 Date: Thu, 2 Jul 2020 22:44:48 +0300 From: Jarkko Sakkinen To: Pengfei Xu , Shuah Khan Cc: Qiuxu Zhuo , Heng Su , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Svahn Subject: Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3 Message-ID: <20200702194435.GA28988@linux.intel.com> References: <20200626034052.25263-1-pengfei.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626034052.25263-1-pengfei.xu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote: > Python 2 is no longer supported by the Python upstream project, so > upgrade TPM2 tests to Python 3. > > Signed-off-by: Pengfei Xu I think that it's perfect now. Thank you. Also 1. I checked that scripts/checkpatch.pl did not report any errors. 2. sudo python3 -m unittest -v tpm2_tests.SmokeTest 3. sudo python3 -m unittest -v tpm2_tests.SpaceTest Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen Shuah, I could pick this up after your PR (with my earlier fixes) lands to mainline, and sort out possible merge conflicts if they uprise. Is this fine by you? /Jarkko