Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7ee7829c08f45f5b6907877e0f3b11320c178867.camel@googlemail.com>
Subject: Re: [PATCH 1/2] regulator: fan53880: Add initial support
From:   Christoph Fritz <chf.fritz@googlemail.com>
Reply-To: chf.fritz@googlemail.com
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Date:   Thu, 02 Jul 2020 23:09:41 +0200
In-Reply-To: <20200701180913.GA22871@sirena.org.uk>
References: <20200630185203.22882-1-chf.fritz@googlemail.com>
         <20200630185203.22882-2-chf.fritz@googlemail.com>
         <20200701180913.GA22871@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-07-01 at 19:09 +0100, Mark Brown wrote:
> /mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of
> macro 'FAN53880_LDO'
>   FAN53880_LDO(1, "VIN12", 2800000),
>   ^~~~~~~~~~~~
> /mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name
> not in record or union initializer
>   .min_sel = _min_sel,     \
>   ^
> 
> most likely due to the conversion introduced in 60ab7f4153b6af46
> (regulator: use linear_ranges helper).  Please rebase against current
> code.

Thanks for the hint, yeah that's it. After picking up a recent linux-
next and adapting it works on current too.

Please let me respin the patches in a v2.