Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1816290ybt; Thu, 2 Jul 2020 14:51:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcLlpzkXr3KUPvxIMaDzP/m8urz2zYW33dd8g93WdwYV35mU8xcxdS2G0ZedJQnwiOjfNm X-Received: by 2002:aa7:c54f:: with SMTP id s15mr38270014edr.175.1593726673914; Thu, 02 Jul 2020 14:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593726673; cv=none; d=google.com; s=arc-20160816; b=eGJGGpygdaBnbdgE+w/07SVjw9dDCwboLRtHCuaBE7nYeBxDkZ8PHWsyhFid8z4Pfb YnmRgPqCJhPnvAMECnCdPfyfH7gKujnOlt/219hESViKrLr5IBuUcDmRgb9htQ2MdI3P U9IkrlwBUjKj+LzFxlzrj9mueYLvgIzvhaMMkeI5se7Kc4+Jkdf3+u1tfLAPhGXhR5up lR1bGkcUxdoGNA0BbrNARBZQu/hurPWhui2VnCPTncdDCabbsAfCGdwMIpbYyQKEDemq aoNssBF7u3Fa9NpozlIzufSvmDY6X1njaupgOPv8lotaRPE2CsuUjvwZ0D/7iIDEWs6s BxpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Iu5ry3qVoZrjPRKoxXiAUkkjdQ+qm5706JKzwZStJYg=; b=lAJTPObG7QCy8hkDDC2H0BDz6SNKdPQX0jVu/CLapxogpAcyrxcXzUEwdHov47/OJG s4orcYauyMt33UVQLnzwoPkMODctRSzYpPCsWTOCcwph+a0v2jZpb85C4WoV7/2IpDcy BnFuP9hanKoIwbJJlgcAIpnQA0fQ7ghy7SlOm/frCYcfenBtnTm+tmkB7qYpg9Aufj5f gec4UG4dw4yydjopnV+MIDO5fii6wfribcwPEcs56kWDjBsvJdkd5VXCsV2+f8W5YJAR 40aCkL+RtJX7bwRxvBCjymN1Ewt4rZK7CNzTZ2GbIRaFXjNSSqmm81VvH5Il+lUczY1z qkYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WhfWKe7U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g26si6576575edv.376.2020.07.02.14.50.50; Thu, 02 Jul 2020 14:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WhfWKe7U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726148AbgGBVrL (ORCPT + 99 others); Thu, 2 Jul 2020 17:47:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:49354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGBVrK (ORCPT ); Thu, 2 Jul 2020 17:47:10 -0400 Received: from kernel.org (unknown [87.71.40.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E6352075D; Thu, 2 Jul 2020 21:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593726429; bh=gvP2zjzt3W4dfD2t75YDPObWaiQFVtNlgHUhH3gNn3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WhfWKe7UYTpsr66NZ2WC307AcyCJ1TtI7G2OBKp9HhrsKZKhdx1w7pMdeOwPIp2/g Vas6aAz3CGAbswd8kXCi7FErQYIQ1j+gLUFQSSZoQXfzuWLvKdc63AGpB15cUP2ho4 d9OrkMXIELqL/mKuh/FECINnwBEdop8sjE8tgdOw= Date: Fri, 3 Jul 2020 00:46:54 +0300 From: Mike Rapoport To: Andrew Morton Cc: Abdul Haleem , Andy Lutomirski , Arnd Bergmann , Christophe Leroy , Joerg Roedel , Max Filippov , Mike Rapoport , Peter Zijlstra , Satheesh Rajendran , Stafford Horne , Stephen Rothwell , Steven Rostedt , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] mm: cleanup usage of Message-ID: <20200702214654.GB2999148@kernel.org> References: <20200627143453.31835-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200627143453.31835-1-rppt@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gentle ping. On Sat, Jun 27, 2020 at 05:34:45PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > Hi, > > Most architectures have very similar versions of pXd_alloc_one() and > pXd_free_one() for intermediate levels of page table. > These patches add generic versions of these functions in > and enable use of the generic functions where > appropriate. > > In addition, functions declared and defined in headers > are used mostly by core mm and early mm initialization in arch and there is > no actual reason to have the included all over the place. > The first patch in this series removes unneeded includes of > > In the end it didn't work out as neatly as I hoped and moving > pXd_alloc_track() definitions to would require > unnecessary changes to arches that have custom page table allocations, so > I've decided to move lib/ioremap.c to mm/ and make pgalloc-track.h local to > mm/. > > Joerg Roedel (1): > mm: move p?d_alloc_track to separate header file > > Mike Rapoport (7): > mm: remove unneeded includes of > opeinrisc: switch to generic version of pte allocation > xtensa: switch to generic version of pte allocation > asm-generic: pgalloc: provide generic pmd_alloc_one() and pmd_free_one() > asm-generic: pgalloc: provide generic pud_alloc_one() and pud_free_one() > asm-generic: pgalloc: provide generic pgd_free() > mm: move lib/ioremap.c to mm/ > > arch/alpha/include/asm/pgalloc.h | 21 +---- > arch/alpha/include/asm/tlbflush.h | 1 - > arch/alpha/kernel/core_irongate.c | 1 - > arch/alpha/kernel/core_marvel.c | 1 - > arch/alpha/kernel/core_titan.c | 1 - > arch/alpha/kernel/machvec_impl.h | 2 - > arch/alpha/kernel/smp.c | 1 - > arch/alpha/mm/numa.c | 1 - > arch/arc/mm/fault.c | 1 - > arch/arc/mm/init.c | 1 - > arch/arm/include/asm/pgalloc.h | 12 +-- > arch/arm/include/asm/tlb.h | 1 - > arch/arm/kernel/machine_kexec.c | 1 - > arch/arm/kernel/smp.c | 1 - > arch/arm/kernel/suspend.c | 1 - > arch/arm/mach-omap2/omap-mpuss-lowpower.c | 1 - > arch/arm/mm/hugetlbpage.c | 1 - > arch/arm/mm/mmu.c | 1 + > arch/arm64/include/asm/pgalloc.h | 39 +--------- > arch/arm64/kernel/smp.c | 1 - > arch/arm64/mm/hugetlbpage.c | 1 - > arch/arm64/mm/ioremap.c | 1 - > arch/arm64/mm/mmu.c | 1 + > arch/csky/include/asm/pgalloc.h | 7 +- > arch/csky/kernel/smp.c | 1 - > arch/hexagon/include/asm/pgalloc.h | 7 +- > arch/ia64/include/asm/pgalloc.h | 24 ------ > arch/ia64/include/asm/tlb.h | 1 - > arch/ia64/kernel/process.c | 1 - > arch/ia64/kernel/smp.c | 1 - > arch/ia64/kernel/smpboot.c | 1 - > arch/ia64/mm/contig.c | 1 - > arch/ia64/mm/discontig.c | 1 - > arch/ia64/mm/hugetlbpage.c | 1 - > arch/ia64/mm/tlb.c | 1 - > arch/m68k/include/asm/mmu_context.h | 2 +- > arch/m68k/include/asm/sun3_pgalloc.h | 7 +- > arch/m68k/kernel/dma.c | 2 +- > arch/m68k/kernel/traps.c | 3 +- > arch/m68k/mm/cache.c | 2 +- > arch/m68k/mm/fault.c | 1 - > arch/m68k/mm/kmap.c | 2 +- > arch/m68k/mm/mcfmmu.c | 1 + > arch/m68k/mm/memory.c | 1 - > arch/m68k/sun3x/dvma.c | 2 +- > arch/microblaze/include/asm/pgalloc.h | 6 -- > arch/microblaze/include/asm/tlbflush.h | 1 - > arch/microblaze/kernel/process.c | 1 - > arch/microblaze/kernel/signal.c | 1 - > arch/mips/include/asm/pgalloc.h | 19 +---- > arch/mips/sgi-ip32/ip32-memory.c | 1 - > arch/nds32/mm/mm-nds32.c | 2 + > arch/nios2/include/asm/pgalloc.h | 7 +- > arch/openrisc/include/asm/pgalloc.h | 33 +------- > arch/openrisc/include/asm/tlbflush.h | 1 - > arch/openrisc/kernel/or32_ksyms.c | 1 - > arch/parisc/include/asm/mmu_context.h | 1 - > arch/parisc/include/asm/pgalloc.h | 12 +-- > arch/parisc/kernel/cache.c | 1 - > arch/parisc/kernel/pci-dma.c | 1 - > arch/parisc/kernel/process.c | 1 - > arch/parisc/kernel/signal.c | 1 - > arch/parisc/kernel/smp.c | 1 - > arch/parisc/mm/hugetlbpage.c | 1 - > arch/parisc/mm/ioremap.c | 2 +- > arch/powerpc/include/asm/tlb.h | 1 - > arch/powerpc/mm/book3s64/hash_hugetlbpage.c | 1 - > arch/powerpc/mm/book3s64/hash_pgtable.c | 1 - > arch/powerpc/mm/book3s64/hash_tlb.c | 1 - > arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 1 - > arch/powerpc/mm/init_32.c | 1 - > arch/powerpc/mm/kasan/8xx.c | 1 - > arch/powerpc/mm/kasan/book3s_32.c | 1 - > arch/powerpc/mm/mem.c | 1 - > arch/powerpc/mm/nohash/40x.c | 1 - > arch/powerpc/mm/nohash/8xx.c | 1 - > arch/powerpc/mm/nohash/fsl_booke.c | 1 - > arch/powerpc/mm/nohash/kaslr_booke.c | 1 - > arch/powerpc/mm/pgtable.c | 1 - > arch/powerpc/mm/pgtable_64.c | 1 - > arch/powerpc/mm/ptdump/hashpagetable.c | 2 +- > arch/powerpc/mm/ptdump/ptdump.c | 1 - > arch/powerpc/platforms/pseries/cmm.c | 1 - > arch/riscv/include/asm/pgalloc.h | 18 +---- > arch/riscv/mm/fault.c | 1 - > arch/s390/include/asm/tlb.h | 1 - > arch/s390/include/asm/tlbflush.h | 1 - > arch/s390/kernel/machine_kexec.c | 1 - > arch/s390/kernel/ptrace.c | 1 - > arch/s390/kvm/diag.c | 1 - > arch/s390/kvm/priv.c | 1 - > arch/s390/kvm/pv.c | 1 - > arch/s390/mm/cmm.c | 1 - > arch/s390/mm/mmap.c | 1 - > arch/s390/mm/pgtable.c | 1 - > arch/sh/include/asm/pgalloc.h | 4 + > arch/sh/kernel/idle.c | 1 - > arch/sh/kernel/machine_kexec.c | 1 - > arch/sh/mm/cache-sh3.c | 1 - > arch/sh/mm/cache-sh7705.c | 1 - > arch/sh/mm/hugetlbpage.c | 1 - > arch/sh/mm/init.c | 1 + > arch/sh/mm/ioremap_fixed.c | 1 - > arch/sh/mm/tlb-sh3.c | 1 - > arch/sparc/include/asm/ide.h | 1 - > arch/sparc/include/asm/tlb_64.h | 1 - > arch/sparc/kernel/leon_smp.c | 1 - > arch/sparc/kernel/process_32.c | 1 - > arch/sparc/kernel/signal_32.c | 1 - > arch/sparc/kernel/smp_32.c | 1 - > arch/sparc/kernel/smp_64.c | 1 + > arch/sparc/kernel/sun4m_irq.c | 1 - > arch/sparc/mm/highmem.c | 1 - > arch/sparc/mm/io-unit.c | 1 - > arch/sparc/mm/iommu.c | 1 - > arch/sparc/mm/tlb.c | 1 - > arch/um/include/asm/pgalloc.h | 9 +-- > arch/um/include/asm/pgtable-3level.h | 3 - > arch/um/kernel/mem.c | 17 ----- > arch/x86/ia32/ia32_aout.c | 1 - > arch/x86/include/asm/mmu_context.h | 1 - > arch/x86/include/asm/pgalloc.h | 42 +--------- > arch/x86/kernel/alternative.c | 1 + > arch/x86/kernel/apic/apic.c | 1 - > arch/x86/kernel/mpparse.c | 1 - > arch/x86/kernel/traps.c | 1 - > arch/x86/mm/fault.c | 1 - > arch/x86/mm/hugetlbpage.c | 1 - > arch/x86/mm/kaslr.c | 1 - > arch/x86/mm/pgtable_32.c | 1 - > arch/x86/mm/pti.c | 1 - > arch/x86/platform/uv/bios_uv.c | 1 + > arch/xtensa/include/asm/pgalloc.h | 40 ++++------ > arch/xtensa/kernel/xtensa_ksyms.c | 1 - > arch/xtensa/mm/cache.c | 1 - > arch/xtensa/mm/fault.c | 1 - > drivers/block/xen-blkback/common.h | 1 - > drivers/iommu/ipmmu-vmsa.c | 1 - > drivers/xen/balloon.c | 1 - > drivers/xen/privcmd.c | 1 - > fs/binfmt_elf_fdpic.c | 1 - > include/asm-generic/pgalloc.h | 80 ++++++++++++++++++++ > include/asm-generic/tlb.h | 1 - > include/linux/mm.h | 45 ----------- > lib/Makefile | 1 - > mm/Makefile | 2 +- > mm/hugetlb.c | 1 + > {lib => mm}/ioremap.c | 2 + > mm/pgalloc-track.h | 51 +++++++++++++ > mm/sparse.c | 1 - > mm/vmalloc.c | 1 + > 151 files changed, 194 insertions(+), 451 deletions(-) > rename {lib => mm}/ioremap.c (99%) > create mode 100644 mm/pgalloc-track.h > > -- > 2.26.2 > -- Sincerely yours, Mike.