Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1853596ybt; Thu, 2 Jul 2020 16:01:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBng54IxxuNlki81RUY6+nynuml6xKAljDgbWg+qD73KKlSIi5CK4daKJFWkqZmCIyqTzj X-Received: by 2002:a50:a45d:: with SMTP id v29mr37119177edb.284.1593730876514; Thu, 02 Jul 2020 16:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593730876; cv=none; d=google.com; s=arc-20160816; b=juWy89pI9qRGl062P2Jh3itknAxXPWh2zkzOoXvB8bDeDlu/U92P44trrZIi1xrFJ9 GkrzTC6UaWotG+jVLU0vhtI0RLr7+RZuVv874wwhZlKFz669XVCIuwG2dSOvuVpd+OKk Sy/MDqJUc40mdWtoBIqqhtZYr8T5E3mjJvDap2YluRIvUtlZaR5AL/fsLaPit+n6iPWP jqw4RVNgMvjbKemJYftBNYIfBqGWHVA/N5egKAhLGdSg5zadySQxlXzl8dmzEX1BfEGi dQD0/LA+od8cvBdmkNE39HwpemsSrLQ8j+xdD92i4NK1I135r/iSIUCq6OikDQtnZb9k SNEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=rja40bkZ+uABEn1zz77pxq4CDtieylOgbo/CCZbZS0U=; b=ZkHhubewbKlXSYHwTVuuUeWvrhtn7IbCYWgKcLVi4jwR7uAih39/W+tipiNKjxWTxr XsL25M9vPEwQMpouuqzE2JiWKa2TiwO5oCPeGHkeJP1kl7cZemamN/wiJziKtpO/rGHM YYjD6xhw/OyokBqVwTeEnsV8XaKHIMFQ3D5yYg5etCAoG8dRytjy72BsaXGVuznnPXEQ sNftqrw7JrVKwC4EeIfp7fSYUOeGnAVbP6iPWTkereYJD/ciZ9GNxm0E+Whj6cxVMsZj mn8oG+WahhKpoRO2IL3Og2KJENzo0e+Ct6lAp4pDXPdiVYPqADgP5G+wEGqzSFrwbaTf TzZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=kndgUCLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id co3si6545457edb.134.2020.07.02.16.00.53; Thu, 02 Jul 2020 16:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=kndgUCLi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbgGBW7y (ORCPT + 99 others); Thu, 2 Jul 2020 18:59:54 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:47458 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGBW7x (ORCPT ); Thu, 2 Jul 2020 18:59:53 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 062MvTp8075029; Thu, 2 Jul 2020 22:59:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=rja40bkZ+uABEn1zz77pxq4CDtieylOgbo/CCZbZS0U=; b=kndgUCLi8TtT2/WeHmyYfw9qwBaJMg3c18lZZKETy+NXS0p5fTh/sbkr+4z902nhZl+0 K0m+qJFpAVL6igeiwoMBiAIGH2++AXdcKbUnPxpTzZGmZA9fedbrIOs9TqUOzTcR6aI8 zxnWs4wcImV7hB90a0i2eAm3aZnF+7El9T02kBCK5IgQNWVs7vMIPG57NyaIhLQ0fuEl 4zaEnZDOEqtZiSon3n1ddFj5toNYmkczbPVlXqnT+6ue47O3sCWk3GFMBHGYEf5vhIQu aozrGcaGV4J0oX1KvW5y71AvRNfLX1JVYjQYn47BTWBHqJ9P+V5Utnu+y+mFKjn2djMo Iw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 31ywrc17n7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 02 Jul 2020 22:59:30 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 062Mwgxi160912; Thu, 2 Jul 2020 22:59:30 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 31xfvwbfh9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Jul 2020 22:59:30 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 062MxRse016460; Thu, 2 Jul 2020 22:59:27 GMT Received: from [10.39.209.60] (/10.39.209.60) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Jul 2020 22:59:27 +0000 Subject: Re: [PATCH v2 1/4] x86/xen: remove 32-bit Xen PV guest support To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Stefano Stabellini References: <20200701110650.16172-1-jgross@suse.com> <20200701110650.16172-2-jgross@suse.com> From: Boris Ostrovsky Autocrypt: addr=boris.ostrovsky@oracle.com; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: <6d0b517a-6c53-61d3-117b-40e33e013037@oracle.com> Date: Thu, 2 Jul 2020 18:59:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200701110650.16172-2-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9670 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007020153 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9670 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999 clxscore=1011 cotscore=-2147483648 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007020153 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/1/20 7:06 AM, Juergen Gross wrote: > Xen is requiring 64-bit machines today and since Xen 4.14 it can be > built without 32-bit PV guest support. There is no need to carry the > burden of 32-bit PV guest support in the kernel any longer, as new > guests can be either HVM or PVH, or they can use a 64 bit kernel. > > Remove the 32-bit Xen PV support from the kernel. > > Signed-off-by: Juergen Gross > --- > arch/x86/entry/entry_32.S | 109 +---------- > arch/x86/include/asm/proto.h | 2 +- > arch/x86/include/asm/segment.h | 2 +- > arch/x86/kernel/head_32.S | 31 --- > arch/x86/xen/Kconfig | 3 +- > arch/x86/xen/Makefile | 3 +- > arch/x86/xen/apic.c | 17 -- > arch/x86/xen/enlighten_pv.c | 48 +---- Should we drop PageHighMem() test in set_aliased_prot()? (And there are few other places where is is used, in mmu_pv.c) > @@ -555,13 +547,8 @@ static void xen_load_tls(struct thread_struct *t, = unsigned int cpu) > * exception between the new %fs descriptor being loaded and > * %fs being effectively cleared at __switch_to(). > */ > - if (paravirt_get_lazy_mode() =3D=3D PARAVIRT_LAZY_CPU) { > -#ifdef CONFIG_X86_32 > - lazy_load_gs(0); > -#else I think this also needs an adjustment to the preceding comment. > =20 > -#ifdef CONFIG_X86_PAE > -static void xen_set_pte_atomic(pte_t *ptep, pte_t pte) > -{ > - trace_xen_mmu_set_pte_atomic(ptep, pte); > - __xen_set_pte(ptep, pte); Probably not for this series but I wonder whether __xen_set_pte() should continue to use hypercall now that we are 64-bit only. > @@ -654,14 +621,12 @@ static int __xen_pgd_walk(struct mm_struct *mm, p= gd_t *pgd, Comment above should be updated. -boris