Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1936419ybt; Thu, 2 Jul 2020 18:35:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrMFT9AtEVk7V7wdxyMa2v+VL7xoSS9HG8JLLhexmRE2JThuyxnbs1VfYntWpmS/jPigSp X-Received: by 2002:a05:6402:1597:: with SMTP id c23mr36369411edv.243.1593740109408; Thu, 02 Jul 2020 18:35:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593740109; cv=none; d=google.com; s=arc-20160816; b=pm+KuXbhVbpL3AZc2W0fhtXHqih9PiSiYOvXH8fuGu+vcMrpQj6TSNGVPPxzDhgXH3 bEx9iTSMDg3IvX9pb1wKo1MWdFchIUIqTxeWQghfhcMwSrHWcrR2yCyNkZVWsOwnYnch +H5fGILvKJ2l08ya5s7iusFd6aTSah5VXZk1jM9HzaPLdA8NBMHRsxtuX0Sr1XdHIH33 8Mv1KhcoxdgjF6UD5zek2wIBLIT6wyqXVjUzDeaJV0DBTcZQYxgkXVfeBFdNVKnH2JXN kZaAwCIcvObwJd3s2g+iqQH1wjACDyTtR54+V8ZA6InoFd+0sghBCYlPxOmShOEZwcQI vztQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=0HJVARDPC0nrXeRJEmNk6SfU2ID9M58z4ZM6ibB7zPM=; b=pCcg5/yOTCb9tdVQ6UZ8luKBOlrka/Jw3W5/w0FldrknTZh3UrvcFipig6xV4fNFrg jmrmHImzcwDHb5fOhB54DKDz9SRW0fpTZSLVZnbE2Vvh8/DcB6L/fx4A28bGJQEbnpRi iweFUTP9/aRUqq03AZW6SOIbDPjVrrSCeLFW1llEOgRuiEKQHfWPtibvNFdL0y5xeS3V ZDf9TwYTstQDbzdlSe6fhv2ntfPISRklOonSkpRahqiz13E5DTQnLx/mUsW4tlPsOwuI XNI36E+mkM6g8G12hd6EI/iIUbmNtLIIqXLuUJQU5gCEItQUkJwqbLiIhB7zRl03kij0 mvJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b17si7223334eds.439.2020.07.02.18.34.44; Thu, 02 Jul 2020 18:35:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726048AbgGCBds (ORCPT + 99 others); Thu, 2 Jul 2020 21:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgGCBds (ORCPT ); Thu, 2 Jul 2020 21:33:48 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD21BC08C5C1 for ; Thu, 2 Jul 2020 18:33:47 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrAa0-004Hdf-Fb; Fri, 03 Jul 2020 01:33:28 +0000 Date: Fri, 3 Jul 2020 02:33:28 +0100 From: Al Viro To: Linus Torvalds Cc: Michael Ellerman , Christophe Leroy , Josh Poimboeuf , Peter Zijlstra , the arch/x86 maintainers , Linux Kernel Mailing List Subject: Re: objtool clac/stac handling change.. Message-ID: <20200703013328.GQ2786714@ZenIV.linux.org.uk> References: <20200701184131.GI2786714@ZenIV.linux.org.uk> <20200701195914.GK2786714@ZenIV.linux.org.uk> <87lfk26nx4.fsf@mpe.ellerman.id.au> <20200702201755.GO2786714@ZenIV.linux.org.uk> <20200702205902.GP2786714@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 02, 2020 at 02:55:19PM -0700, Linus Torvalds wrote: > And while XSTATE_OP() is still disgusting, it's > > (a) slightly less disgusting than it used to be > > (b) now easily fixable if we do the "exceptions clear AC" thing. > > so it's an improvement all around. > > If it works, that is. As mentioned: IT HAS NO TESTING. What about load_unaligned_zeropad()? Normally the caller doesn't want to know about the exception on crossing into an unmapped page. Blanket "clear #AC of fixup, don't go through user_access_end() in case of exception" would complicate the code that calls that sucker.