Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1967014ybt; Thu, 2 Jul 2020 19:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi6CADZWlLeWOpuvUxEWGnP8Ln5mjLraglXkMLTE1+JrqzYKgEZ7oddjRb55G3PQYcNpx+ X-Received: by 2002:a17:906:456:: with SMTP id e22mr24748426eja.178.1593743949535; Thu, 02 Jul 2020 19:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593743949; cv=none; d=google.com; s=arc-20160816; b=lap6xkn5oe9VRKPE4xqU0UmBFjgE8LQUWx031B1uIL2sz63tKcSs2Y5o/W23usYx2U 4/Dy/KvTSeR97c2kH46bsCAY8pX2S/ZThAFkz/3fjrETKiIUl6Hg9sV3FkT0lpHM49lB YZoJfmTTpxJUdlmZU1ZZ+SPiPoZNSTlp+4om3eUs/31k2CdwXRyt2eR4sVYr6Zvvg3QY 4+wbsXeJ8J/gwKkyQOfnJuc0I9nHrD2CPCRKWNINhwI946EIYXJ0OhV2OMJxx1GknOGl 4K7+ppoEZBE4DLZY0JH2mLPuDBMtWbDUWKa6HR227RiSqpOLCWfx3thLPYMcuRlJkNhb hhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=g+aW9WMdN4vc8VTz1lt/FAgPXOfbufPnDEcODcBrw40=; b=Bw4QdBJ5/8QcX2T/ARRYX6WMlaRPAFGYhhoRyqHjJ12CQkrNebqqHjUU657BKoGTS1 wjebi29JeIDKjbDg8+R8d5mxY0aLcYkuDQcU1mO9xYyBu7tZhB8yu9ucOW9IN7jKAjVC xckYB8c3rS7p/fTOBrvRQpTm3m6F7s9cNQ6uw24nmzCBsES5CTNmd2g2yQTRQLkRwhjj FWBsTwGvyYi86A+QBwFXmGcOcRWSNPmqck745oyRgTeUH/wIK3+oYAGTufRYH/jOeiln 97w6snCKxqNmpH948HUaSoZPIWhKMdUXWtNVzI7G5iQ+/RZ0GQjxYrtRh1aVmIzSKtRw 8EoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si36279ejf.54.2020.07.02.19.38.46; Thu, 02 Jul 2020 19:39:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726966AbgGCCiD (ORCPT + 99 others); Thu, 2 Jul 2020 22:38:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:52028 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbgGCCgG (ORCPT ); Thu, 2 Jul 2020 22:36:06 -0400 IronPort-SDR: dLHdkoScc/SUNO/7Ij7gcozOvpgTy5KLJGHtPGU5M23ilncKoJFkGESLmCsmDlY97E/NJc/fbL 7dga66vNlUCw== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="145213961" X-IronPort-AV: E=Sophos;i="5.75,306,1589266800"; d="scan'208";a="145213961" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 19:36:05 -0700 IronPort-SDR: lq5xZUJFLbh93fPrxLG2HJCQFj4oIO5T+45h0TGZZxmJ+ksUWk2qwMwBdEwk9ZCIUVHF7gL3lU 8NZduWuw+fAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,306,1589266800"; d="scan'208";a="278295725" Received: from sjchrist-coffee.jf.intel.com ([10.54.74.152]) by orsmga003.jf.intel.com with ESMTP; 02 Jul 2020 19:36:04 -0700 From: Sean Christopherson To: Marc Zyngier , Paolo Bonzini , Arnd Bergmann Cc: James Morse , Julien Thierry , Suzuki K Poulose , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon , Peter Feiner , Peter Shier , Junaid Shahid , Christoffer Dall Subject: [PATCH v3 03/21] KVM: x86/mmu: Use consistent "mc" name for kvm_mmu_memory_cache locals Date: Thu, 2 Jul 2020 19:35:27 -0700 Message-Id: <20200703023545.8771-4-sean.j.christopherson@intel.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200703023545.8771-1-sean.j.christopherson@intel.com> References: <20200703023545.8771-1-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use "mc" for local variables to shorten line lengths and provide consistent names, which will be especially helpful when some of the helpers are moved to common KVM code in future patches. No functional change intended. Reviewed-by: Ben Gardon Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index d6612af6c056..b6df4525e86c 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -1060,27 +1060,27 @@ static void walk_shadow_page_lockless_end(struct kvm_vcpu *vcpu) local_irq_enable(); } -static int mmu_topup_memory_cache(struct kvm_mmu_memory_cache *cache, int min) +static int mmu_topup_memory_cache(struct kvm_mmu_memory_cache *mc, int min) { void *obj; - if (cache->nobjs >= min) + if (mc->nobjs >= min) return 0; - while (cache->nobjs < ARRAY_SIZE(cache->objects)) { - if (cache->kmem_cache) - obj = kmem_cache_zalloc(cache->kmem_cache, GFP_KERNEL_ACCOUNT); + while (mc->nobjs < ARRAY_SIZE(mc->objects)) { + if (mc->kmem_cache) + obj = kmem_cache_zalloc(mc->kmem_cache, GFP_KERNEL_ACCOUNT); else obj = (void *)__get_free_page(GFP_KERNEL_ACCOUNT); if (!obj) - return cache->nobjs >= min ? 0 : -ENOMEM; - cache->objects[cache->nobjs++] = obj; + return mc->nobjs >= min ? 0 : -ENOMEM; + mc->objects[mc->nobjs++] = obj; } return 0; } -static int mmu_memory_cache_free_objects(struct kvm_mmu_memory_cache *cache) +static int mmu_memory_cache_free_objects(struct kvm_mmu_memory_cache *mc) { - return cache->nobjs; + return mc->nobjs; } static void mmu_free_memory_cache(struct kvm_mmu_memory_cache *mc) @@ -1395,10 +1395,10 @@ static struct kvm_rmap_head *gfn_to_rmap(struct kvm *kvm, gfn_t gfn, static bool rmap_can_add(struct kvm_vcpu *vcpu) { - struct kvm_mmu_memory_cache *cache; + struct kvm_mmu_memory_cache *mc; - cache = &vcpu->arch.mmu_pte_list_desc_cache; - return mmu_memory_cache_free_objects(cache); + mc = &vcpu->arch.mmu_pte_list_desc_cache; + return mmu_memory_cache_free_objects(mc); } static int rmap_add(struct kvm_vcpu *vcpu, u64 *spte, gfn_t gfn) -- 2.26.0