Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1972114ybt; Thu, 2 Jul 2020 19:50:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzBgx0pcpG91p/DeqRL4/DIbU7uMGDP5VyY1wIFZKBnrZoMtaEMLcktDRXEmS9PM17UoiB X-Received: by 2002:a50:cc8a:: with SMTP id q10mr39113237edi.257.1593744634332; Thu, 02 Jul 2020 19:50:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593744634; cv=none; d=google.com; s=arc-20160816; b=WREPH64LprbhFVC0ZVvTCpyoSAjTO4b26K6RxGPZipy3akTAkdaHPP+eP92Pg4nqZS RXbhxqiKzOD4XCl3Xzaj+aLdNvnTTRbAd4e4f4ivHXVGNlbOEvzpHJmqGZO6q/yyblcm JiwMoxw0al5U/oJ6ciJRVUsi5kYfN0x9eDnfvQZARP31MQaHSpMt29PenpW1sHSwYejx 7KpfCDTsfWUSqDTAQPhdwHb5iTILk92AfyeCfcOcl4JMsYHQlI1I+tb7uK4r+E1xzG8W iSTZoLQ8+OkEfgT7XCZolZuhYtbi36VunD1OZnvjNoVGggdUqQ5BshrEGtjKgt5H3CAf ZkgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from; bh=ZjODFTYkLpFpoFnTocfJRyUaMdcqZLCO2nH8JrVom1w=; b=hBMVgTfz6aSf6/JdYE1CHP3RWzw4B4Nj6B5ZsFD7cqFCM1/XOkWH+2CMlfEkNhhr5E 4QVEavCLbCj6O8WVNgO8Vl8WwAyzPBpl0l0gvI7htiUm+J+W2KwHwpZKAnhTcBcjDylg kZv0milqiKotGoSg9e6bCAk3cPk07ojCxsyT+Nx7wjhLj9HS0cRz8QSCV7DA4JOdbxj4 R/UHD6BJF3EkgjXF7sau7xvEdwT12eau46QonZr/FtHwbkFRRGAWBBMkEH6PAY3Pmluu 3y9f380AuSoBgqYlxyizjvarPF977OrWqvs1vTN0d80avLHwE7qZutJHPhAwgfMpBsZ8 Skgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si6628932edp.515.2020.07.02.19.50.12; Thu, 02 Jul 2020 19:50:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbgGCCtt (ORCPT + 99 others); Thu, 2 Jul 2020 22:49:49 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:59435 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725937AbgGCCtt (ORCPT ); Thu, 2 Jul 2020 22:49:49 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0U1XMeTf_1593744587; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0U1XMeTf_1593744587) by smtp.aliyun-inc.com(127.0.0.1); Fri, 03 Jul 2020 10:49:47 +0800 From: Baolin Wang To: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me Cc: baolin.wang@linux.alibaba.com, baolin.wang7@gmail.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] nvme-pci: Remove redundant segment validation Date: Fri, 3 Jul 2020 10:49:22 +0800 Message-Id: <84ef8fd8eb4d7289fa92b5be12cc71eb1af46c5b.1593743937.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We've validated the segment counts before calling nvme_map_data(), so there is no need to validate again in nvme_pci_use_sgls() only called from nvme_map_data(). Signed-off-by: Baolin Wang --- drivers/nvme/host/pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index d0e9bbf..63bfb8b 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -501,9 +501,6 @@ static inline bool nvme_pci_use_sgls(struct nvme_dev *dev, struct request *req) int nseg = blk_rq_nr_phys_segments(req); unsigned int avg_seg_size; - if (nseg == 0) - return false; - avg_seg_size = DIV_ROUND_UP(blk_rq_payload_bytes(req), nseg); if (!(dev->ctrl.sgls & ((1 << 0) | (1 << 1)))) -- 1.8.3.1