Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1977900ybt; Thu, 2 Jul 2020 20:03:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGRVwmoBoOKzcKzylTiiD2ZINtplCJWd4I+7/82dtzaVGMt27JuB39ptgWPRoGb6q0tc49 X-Received: by 2002:a17:907:724d:: with SMTP id ds13mr29685042ejc.73.1593745418962; Thu, 02 Jul 2020 20:03:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593745418; cv=none; d=google.com; s=arc-20160816; b=gj7bWbTB5FH8KiEc69g8THVHMGJwd4yOlepe8SUb8VTfydMgHVveLon5p4OF3GAElX PbEANTYeGPAmszebNgoYVd9CbxFgZyZv2FSK6SxwM3w+GIPgVco+6QPcCiXk8QeUREiE 9jhpE+bcHlx04ZtmBgr5Kgkp4Xf1EVfLP17OOdhkZyzpNd7xJ00sYHyyWb+yHVrkG0QU Juy7nVfz/Nin+iV6FmZcz5blWIJbTHtNO6RdsPr4RyFO2wQbRA9NTL4KxbjTA+kWuIWV weR4hiC8c3c1HgR1WNldjGB2gNnGMoCxe7X90UsQ5QpS1IMkmkx5c+wkv10ALmWCYDNK cMQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Pvp5GqQnObwsM2WQjJTtbVs7GSQZ7G4lQMiDZtzgLT0=; b=CSSq5EiwWwFZPRCxsp4WVF1uPYIUPB8DTXHMhCq7Gqrr64s219is2bQzOcxc1dpl4k gd2pLv4Jv/LL1O3wWRGys5K7xyfHbuqDSTmvzoINuPYioV9iQYJoxStwXOygW0FaVdYW U/SPkzrq27+WZY1rhi3q5Z63EXNr4rb+ja/n+TxripQPwne6cH2bhXCe0zj89oSDoMlT Qddb29KHPh3ynrcRsNsV3s1wwCXpWIh8H4anOBVI4h41h109O8WLiYrpxTQvUmEVPfBW iBCYACdVsE4XHAKd47kCfXsZD3hpFsRxsI6s5SY0aT760Mo4CkhHDhbzAc+C3Cukfr8Q NCsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZV3DqdoA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg17si7093158edb.606.2020.07.02.20.03.16; Thu, 02 Jul 2020 20:03:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZV3DqdoA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726140AbgGCDDE (ORCPT + 99 others); Thu, 2 Jul 2020 23:03:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgGCDDD (ORCPT ); Thu, 2 Jul 2020 23:03:03 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2457C08C5C1; Thu, 2 Jul 2020 20:03:03 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id j1so13380021pfe.4; Thu, 02 Jul 2020 20:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Pvp5GqQnObwsM2WQjJTtbVs7GSQZ7G4lQMiDZtzgLT0=; b=ZV3DqdoAbv0sFGAPIy2vkGDpPQM3nJTjXxSxp1azMqqhWwEFZ4MNgt6imgmKYn5em9 I//8hxGOtjnFDUE87+sSiEPaqAZBuo1MA3v5wIJEkoKRw2uCndE3p0nq94bDdxm4GhAZ NIYLUq7Jb8NgNXvScBQUQn8HhKRwuhU085HiMk/G+Z+0GtfDsbGK5V+Nhq4O+r7Wv6WO 3/Xdt/7xjKCGo0FyRtZ9AVsEbouMwK2gBxWlv9zi9XVjf/u99YBtc0DAUFdQ5fjkX1V7 dnerw5o3FWksd0dsim81SKJkQu6qVj+pHFJgBMjFYxuuKn1G1aJm8sVPbNZycGvysmLF fBzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Pvp5GqQnObwsM2WQjJTtbVs7GSQZ7G4lQMiDZtzgLT0=; b=Z11McIv6oF6ul+/eDDyOPSnHJrgpxtU0c89W3Ufes/tjVfpYalYcm2bD3ZpU57AQYO JU0TcUIL5yQMikQawJMs8FtQzj6jZIgv3fm/xEe3nd7/SCYivjy2QsklXjO0CQXiDZTh iKhKNz8fTbEsTH8PgqR+CmydUhCtho708BCL2PJ+EYU+8yEpE68HaeZKX2cIiKH7/fIf Y58iKzATgYwR6+m/fEHad8OE/vZsNpKI9PRBdh0tUHc49E4y7wvzN1DxuDKgCga5bhl0 zh34kk3ebqVODzuVGe1xK47zslvMzCQzBdhwmp9yiWMHZwyBtg/cZUpJApDwHZfuHUL2 iX3w== X-Gm-Message-State: AOAM531LFyuTlMGsH44XVCrLIEDmtkVdAbEkdvSuJxOxgixxNAkrmkdS KjGCJ+QE0B52nIsvjtFhmlw= X-Received: by 2002:a63:5821:: with SMTP id m33mr27669386pgb.43.1593745383084; Thu, 02 Jul 2020 20:03:03 -0700 (PDT) Received: from varodek.iballbatonwifi.com ([103.105.153.57]) by smtp.gmail.com with ESMTPSA id h194sm9903223pfe.201.2020.07.02.20.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 20:03:02 -0700 (PDT) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , bjorn@helgaas.com, Vaibhav Gupta , "David S. Miller" , Jakub Kicinski , Steve Glendinning Cc: Vaibhav Gupta , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: [PATCH v2 0/2] smsc: use generic power management Date: Fri, 3 Jul 2020 08:31:36 +0530 Message-Id: <20200703030138.25724-1-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to remove legacy power management callbacks from smsc ethernet drivers. The callbacks performing suspend() and resume() operations are still calling pci_save_state(), pci_set_power_state(), etc. and handling the power management themselves, which is not recommended. The conversion requires the removal of the those function calls and change the callback definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. V2: Kbuild in V1, warning: variable 'err' is used uninitialized whenever 'if' conditio is false in funcution .resume() . Vaibhav Gupta (2): epic100: use generic power management smsc9420: use generic power management drivers/net/ethernet/smsc/epic100.c | 19 +++++-------- drivers/net/ethernet/smsc/smsc9420.c | 40 ++++++++-------------------- 2 files changed, 17 insertions(+), 42 deletions(-) -- 2.27.0