Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2013530ybt; Thu, 2 Jul 2020 21:21:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykkXkjSiPJsjk7sIy5d550oMIq3xsXvRg4aeWBNHJOT+uJal3+wYfMU3os3xD8gODkVxO6 X-Received: by 2002:a17:906:6897:: with SMTP id n23mr29420467ejr.473.1593750081868; Thu, 02 Jul 2020 21:21:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593750081; cv=none; d=google.com; s=arc-20160816; b=mz8nfXeis+QJawdxQ3n/yqZJ8XninyzqwRwRSzBTFBmgu+vUInRQDY0PrWiAXWTUCj cbI+Rvo4kb/moNO5xT6+DUNZBa65qU23irERGhWFxNjNPsrZiXNvjF/sU68Uh8hLT7Fr KLBpyXdUqJQ/OpXtii+LnPfgOgxp4NgGa30ZbNJGT+NNs47ffw+ArYshfDj+1ENJ8VGq H2N2c3QNf4Br6omzCyoY7tai06f/EEuVyjPMWAxaxPNINkArTy4jP3ReWGq1O0x3RSB7 lWWgGvF05/2l3qcWgNYiZ72Sz15rJGl+j88XDW50ZMBWNnztcvAXCvVy52+oBB/6xci4 fMvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=kJQjtK+o/tWbEg5tNyJ749tyecl/+rz5ss6HZ/SMZUw=; b=zDEhxm+WFZaXoO/TGy7KBBDphj6OaqKDVhwn4mAbWcA8v1Go1okKudq5P1ZQfzjj5v BLIEH6j46jIzVwoTjSFH+VRpi8Egw+qRgu9aooe/tfSHQwf98mZOQYqwNd7ZN6v5ALod Yi/cCKLDg8o/aux3F7JayCalg4RKKnKqzRaTWwKQ7f9WeESB626zd6+PhmsbzhEyyUCF LJ2ycOG4cCguMLlJZVFTRtaKF/XN9P/5NDBXhIAHAV/QlYIrdV9+I1LYMHFJA2rF1gXb ZDmo7P48crACWMtzowqPtET6MLbAwPUazcWnfmiK3P3jvLEzLc3RstFQMJKo6vCuyTZb GdFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si7029604eju.554.2020.07.02.21.20.58; Thu, 02 Jul 2020 21:21:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726035AbgGCET4 (ORCPT + 99 others); Fri, 3 Jul 2020 00:19:56 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:34926 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725294AbgGCET4 (ORCPT ); Fri, 3 Jul 2020 00:19:56 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R851e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0U1XckQJ_1593749988; Received: from 30.25.178.169(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0U1XckQJ_1593749988) by smtp.aliyun-inc.com(127.0.0.1); Fri, 03 Jul 2020 12:19:51 +0800 Subject: Re: [PATCH] drm/msm/dpu: fix wrong return value in dpu_encoder_init() To: Markus Elfring , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Chen Tao , Daniel Vetter , David Airlie , Drew Davenport , Kalyan Thota , Rob Clark , Sam Ravnborg , Sean Paul , zhengbin References: <1c338c4c-c185-0b37-eabb-1072a6502ec0@web.de> From: Tianjia Zhang Message-ID: <87c184ee-dfe7-03dc-e3c9-27996c57d6cd@linux.alibaba.com> Date: Fri, 3 Jul 2020 12:19:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1c338c4c-c185-0b37-eabb-1072a6502ec0@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/2 22:04, Markus Elfring wrote: >> A positive value ENOMEM is returned here. I thinr this is a typo error. >> It is necessary to return a negative error value. > > I imagine that a small adjustment could be nice for this change description. > > How do you think about to follow progress for the integration of > a previous patch like “[RESEND] drm/msm/dpu: fix error return code in dpu_encoder_init”? > https://lore.kernel.org/dri-devel/20200618062803.152097-1-chentao107@huawei.com/ > https://lore.kernel.org/patchwork/patch/1257957/ > https://lkml.org/lkml/2020/6/18/46 > > Regards, > Markus > This is the same fix, please ignore this patch. Thanks, Tianjia