Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Sinpw/FSKkRAGruNjnYc5LcspgTMhy8rpqzlrlxYGAQqcsMBy+6Q0is6gV3Sa7R3ppclbYeNt+
 U3YZUCltgJlFLUsIOUqNnKiRgVoQCa1EAMInm96F6vRpja8mwWqKKT6NAAm0emzEuzDb5OuJyC
 AbncRQEwjmP8NcmenUWtcZ4+Lgz3jXxG5fVAdHxSuiSKmSFZup3cHVdfKUEdTfzKTJEahGf3yW
 Gp5EZVMcK4hLvj/lONk1iRSoss1Txr6mHEo2m0Vp7kmCO5n7NJv2NlRpDpjKTXR7wtPQ6VHCpm
 UWo=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Kanchan Joshi <joshi.k@samsung.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "kbusch@kernel.org" <kbusch@kernel.org>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hch@lst.de" <hch@lst.de>, Selvakumar S <selvakuma.s1@samsung.com>,
        Nitesh Shetty <nj.shetty@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>
Subject: Re: [PATCH 1/2] block: fix error code for zone-append
Thread-Topic: [PATCH 1/2] block: fix error code for zone-append
Thread-Index: AQHWUIdcNaHZ5okuAE6oiVJHNmJMWw==
Date:   Fri, 3 Jul 2020 05:29:50 +0000
Message-ID: <CY4PR04MB3751B8037BE65D573667A6D5E76A0@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <1593704330-11540-1-git-send-email-joshi.k@samsung.com>
 <CGME20200702154208epcas5p39fe202f642a9d5c8dde9b911645c594c@epcas5p3.samsung.com>
 <1593704330-11540-2-git-send-email-joshi.k@samsung.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ef4f625b-90cf-4ba2-2d8b-08d81f121b92
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2020 05:29:50.3853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jl1tZqvNAmy0k39hTYjXWFOvEi91XCYrnGGTZgCh8NjX7cjMxhqIRsDviFR+/nrj6bonAc6gOPjGrhb1kyK9hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB1031
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/07/03 0:42, Kanchan Joshi wrote:=0A=
> avoid returning success when it should report failure, preventing=0A=
> odd behavior in caller.=0A=
=0A=
You can be more precise here: the odd behavior is an infinite loop in=0A=
bio_iov_iter_get_pages() whcih is is the only user of __bio_iov_append_get_=
pages().=0A=
=0A=
> =0A=
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>=0A=
> Signed-off-by: Selvakumar S <selvakuma.s1@samsung.com>=0A=
> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>=0A=
> Signed-off-by: Javier Gonzalez <javier.gonz@samsung.com>=0A=
> ---=0A=
>  block/bio.c | 2 +-=0A=
>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/block/bio.c b/block/bio.c=0A=
> index a7366c0..0cecdbc 100644=0A=
> --- a/block/bio.c=0A=
> +++ b/block/bio.c=0A=
> @@ -1044,7 +1044,7 @@ static int __bio_iov_append_get_pages(struct bio *b=
io, struct iov_iter *iter)=0A=
>  	size_t offset;=0A=
>  =0A=
>  	if (WARN_ON_ONCE(!max_append_sectors))=0A=
> -		return 0;=0A=
> +		return -EINVAL;=0A=
>  =0A=
>  	/*=0A=
>  	 * Move page array up in the allocated memory for the bio vecs as far a=
s=0A=
> =0A=
=0A=
Note: the odd behavior mentioned in the commit message cannot currently be=
=0A=
triggered since only zonefs issues REQ_OP_ZONE_APPEND BIOs so we are guaran=
teed=0A=
that max_append_sectors is not 0 in that case. But this fix certainly makes=
=0A=
things more solid. So:=0A=
=0A=
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=