Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2076996ybt; Thu, 2 Jul 2020 23:37:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvBwx0cIt3fj/p5eVaIEc/hnhhQiMZvAIdMOovghMuZbm0lvKTk5M4f3swgzXgANCi7r7D X-Received: by 2002:a50:f384:: with SMTP id g4mr37390143edm.205.1593758251678; Thu, 02 Jul 2020 23:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593758251; cv=none; d=google.com; s=arc-20160816; b=e3EgSDuKQsTPz5sZnyqH5eDLX59DWb4JXIyKwRwKpQTk8T42J9p6Fxdlj144MhxgfI pm9mhNwAUwSO/U9DpUElvE7aCR8kvvYNA3xVE5V1LoSb+rzyEm1Zt8W54nAVwSyn5xF8 RSZsNPJwHOjTqfZl+l+LMT6GHOfIn5rxgSTe7mXqP95r4b98K15zKKmEViX6BdjL6++x nY6BZa7XVXpNmIh6zZ6jnEsimyEdFzAiyqCHQJtSdVVUXhaTxfQo6Lj3OHBtYAkVMVEz ZvFJ/IoKUvbw2QRW2ZPy6VUGnfcrBw/3iSteJENXGP+xmWoOw1/k05ITL1KfEnavwKeh QchQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6tTU3W6nm9T69pSo/AUuSnYEH422ZRtxxHjBIvp+Clk=; b=J41WFw6hJuLw3KdB0PzRMHRUgH7KJ7JpVE9uBujYNbjaB1/Ge5C6C74Jx1fGubcAdy Pf7sUinNy4dnWkxDRQfECDcphpYIledjWWyBBWEROGzuDjpfvDj7FfXwlo6SPwEDo+io h4/9C5gua50b0Sb89mV5/ZMGQ1aVCnvXeV79qkIDnN0ChdXUFWHHNTy+tIhI2BsFOyYf oPMFJ7nCr6OBRDzdJozowP0QrviXn2B2Fsi2TlRRHIPNDdsKSLNYjYdYNiNWc/d+VXz6 3l5ivx2radSPEUxmdTmgdpiaOB2HgnrkgpU1+vc8xVghkBvUvczKToEccgHIlKAgHeIj wUuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b22si8342553edn.212.2020.07.02.23.37.08; Thu, 02 Jul 2020 23:37:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbgGCGgc (ORCPT + 99 others); Fri, 3 Jul 2020 02:36:32 -0400 Received: from mail1.windriver.com ([147.11.146.13]:59323 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725764AbgGCGgc (ORCPT ); Fri, 3 Jul 2020 02:36:32 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.2) with ESMTPS id 0636a3hI024507 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 2 Jul 2020 23:36:03 -0700 (PDT) Received: from pek-lpg-core1-vm1.wrs.com (128.224.156.106) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.487.0; Thu, 2 Jul 2020 23:36:02 -0700 From: To: , , , , , CC: Subject: [PATCH] kthread: work could not be queued when worker being destroyed Date: Thu, 2 Jul 2020 12:49:46 +0800 Message-ID: <20200702044946.33142-1-qiang.zhang@windriver.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Qiang The queuing_blocked func should returns true when the worker being destroyed. Signed-off-by: Zhang Qiang --- kernel/kthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kthread.c b/kernel/kthread.c index 1166f2043e67..2ca711d0e78a 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -791,7 +791,7 @@ static inline bool queuing_blocked(struct kthread_worker *worker, { lockdep_assert_held(&worker->lock); - return !list_empty(&work->node) || work->canceling; + return !list_empty(&work->node) || work->canceling || !worker->task; } static void kthread_insert_work_sanity_check(struct kthread_worker *worker, -- 2.24.1