Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2088941ybt; Fri, 3 Jul 2020 00:02:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxN+xEYfI7O7dxeEYCQR2irwx+oTbSZqGLky0NckwWXmpuEdx7/VsIChIkHz5WeVwDX4Xj8 X-Received: by 2002:a05:6402:f:: with SMTP id d15mr16734180edu.25.1593759772265; Fri, 03 Jul 2020 00:02:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593759772; cv=none; d=google.com; s=arc-20160816; b=v9G4HByuTRbrYRskPBkpBmx9YoofYpfTLb0OaafAEqU1KfIEkzIHSJRQ+nsidludk7 RWv/nwQ7yyosQeIWFyGKT+gfWxcsP5UgUrrQJKog3G+OXpGX+Cgnw2SjAFU+7ty4IEKZ YDjRTP2IaTSd3wVH5nL26qgBZn+iKu8779YncuqLo1IsKrnJlyEmjyndKZ9g0KHMh4ux XY8+nZnQiLwuBbjpoIUMvOa/ZiuqukQCjA8LLljTM2h9gQitRKUsSeQnYTw+WJP9qS2i OiZikiJIXP++nro2aO1oEQaoDL8ID3g3tI8AXfm8AokHW8iujguewayQpCmCu29T3UT3 /IKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=r8p8qebU0QaHELpvUpDlxxD1hjqihihXAbp+XRt5y4Y=; b=ix0KoQuuaHDqrT/rPH6IWKr/XIZNFebFO2dP/zQrE/hBoiQle/Dw5MyZEEOwOYO2ch iv+KEE/F/fwFIVX8uqvKf+wSZQmajyyve/U3v+6Bppovl5scs8dohzuqipqLLK/84lVK pU1mgf/j3Zj2U97KbQo3gJ06gZUzJqeqIcduRjtEN6j0k0ktQVWx1L1wdf7nN35F2F0Q uaaBSyZBH+3pt9vlacAqu56RgkLvDC5ZPp5baRirbPwAPv/5PY0mFbGpis8fKae/xN+p dFzKVEKa7Hm6bDgl0zlA6nYn++XTSmx1eUe4Pi6Z/y1JfncVeJpq5lHst2Jq6Voqs37e R3UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WdzsXHjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cn9si7036664edb.325.2020.07.03.00.02.29; Fri, 03 Jul 2020 00:02:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WdzsXHjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726035AbgGCHCS (ORCPT + 99 others); Fri, 3 Jul 2020 03:02:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:50042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725764AbgGCHCR (ORCPT ); Fri, 3 Jul 2020 03:02:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA9BC206DF; Fri, 3 Jul 2020 07:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593759737; bh=BgND3EEs+d8uxCUH6k4pODMG5kSA1ZdIdK8o28GS5U0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WdzsXHjSYVyx1OL7BFS5pmV1UfIjn59q4VEl3zORWCnMBZ9Vpu3q1NMz+tbC4ACwQ nPrc0jykxyEQtDl4y+aleTrNj/N/V+IgZs5dk7/UCrNVnjqHVIyGEOxoSOsvYx6PHZ 6yogSUX+6/ecOdLlGjifiD3Cv6S6VWcAyOJzvwSE= Date: Fri, 3 Jul 2020 09:02:21 +0200 From: Greg Kroah-Hartman To: Ran Wang Cc: Peter Chen , "balbi@kernel.org" , Leo Li , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] USB: phy: fsl-usb: remove character device usage Message-ID: <20200703070221.GA2221524@kroah.com> References: <20200702072914.1072878-1-gregkh@linuxfoundation.org> <20200702072914.1072878-2-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 03, 2020 at 01:56:28AM +0000, Ran Wang wrote: > Hi > > On Thursday, July 2, 2020 5:08 PM, Peter Chen wrote > > > > > > No idea why this driver is using a char device node, statically > > > allocated, with no dynamic allocation or hook up with devtmpfs, along > > > with a reserverd major number, for "special" operations, not all of which ever > > were implemented. > > > > > > So just rip it out, as no one must be using it because no modern > > > system will ever actually create the /dev/ node it needs. > > > > > > > Add related people from NXP. > > > > Reviewed-by: Ran Wang Thanks for the review! greg k-h