Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200703061350.94474-1-songmuchun@bytedance.com>
 <CAOJsxLGc-o1Os7HAoQmhd1DNxGWVrfbw2R8NroTQg0wHNyWX1w@mail.gmail.com> <fe891223-9f83-d112-b185-643d6121712d@redhat.com>
In-Reply-To: <fe891223-9f83-d112-b185-643d6121712d@redhat.com>
From:   Pekka Enberg <penberg@gmail.com>
Date:   Fri, 3 Jul 2020 10:47:20 +0300
Message-ID: <CAOJsxLFpj1iZ8BVPwoSQJjBBtWnREQ=dVLNRV5fm4_Gvyn_DTw@mail.gmail.com>
Subject: Re: [PATCH RESEND] mm/page_alloc: skip setting nodemask when we are
 in interrupt
To:     David Hildenbrand <david@redhat.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03.07.20 08:34, Pekka Enberg wrote:
> >         if (cpusets_enabled()) {
> >                 *alloc_mask |= __GFP_HARDWALL;
> >                 if (!in_interrupt() && !ac->nodemask)
> >                         ac->nodemask = &cpuset_current_mems_allowed;
> >                 else
> >                         *alloc_flags |= ALLOC_CPUSET;
> >         }

On Fri, Jul 3, 2020 at 10:20 AM David Hildenbrand <david@redhat.com> wrote:
> ^ looks much cleaner as well. Do we want to add a summarizing comment?

I see no harm in adding one. I'm sure the next person starting a
journey in the maze some call the page allocator will appreciate it.

- Pekka