Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1588791882.08g1378g67.none.ref@localhost> <1588791882.08g1378g67.none@localhost>
 <202007020818.87EA89106@keescook>
In-Reply-To: <202007020818.87EA89106@keescook>
Reply-To: sedat.dilek@gmail.com
From:   Sedat Dilek <sedat.dilek@gmail.com>
Date:   Fri, 3 Jul 2020 10:15:20 +0200
Message-ID: <CA+icZUUBAzBNwqThSF=YS1zg9EVCuSZ-XDc5Pu3NrO6R3Fi2Zw@mail.gmail.com>
Subject: Re: Kernel compression benchmarks
To:     Kees Cook <keescook@chromium.org>
Cc:     "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>,
        linux-kernel@vger.kernel.org,
        Nick Terrell <nickrterrell@gmail.com>,
        Nick Terrell <terrelln@fb.com>,
        Norbert Lange <nolange79@gmail.com>, Chris Mason <clm@fb.com>,
        linux-kbuild@vger.kernel.org, x86@kernel.org,
        gregkh@linuxfoundation.org, Petr Malat <oss@malat.biz>,
        Kernel Team <Kernel-team@fb.com>,
        Adam Borowski <kilobyte@angband.pl>,
        Patrick Williams <patrickw3@fb.com>, rmikey@fb.com,
        mingo@kernel.org, Patrick Williams <patrick@stwcx.xyz>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 2, 2020 at 5:18 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Wed, Jul 01, 2020 at 10:35:48AM -0400, Alex Xu (Hello71) wrote:
> > ZSTD compression patches have been sent in a number of times over the
> > past few years. Every time, someone asks for benchmarks. Every time,
> > someone is concerned about compression time. Sometimes, someone provides
> > benchmarks.
>
> Where's the latest series for this, btw? I thought it had landed. :P It
> seemed like it was done.
>

Hi,

Again, I would like to see this upstream, too.

Last I asked for a rebase against Linux v5.8-rc1 or later.

Beyond above adaptations, the latest series "zstd-v5" of Nick T.s
patchset needs some addition of zstd to the patch (see [1]):

commit 8dfb61dcbaceb19a5ded5e9c9dcf8d05acc32294
"kbuild: add variables for compression tools"

NOTE:
"zstd-v5" was against Linux-next 20200408 or download the series from
patchwork LKML which applies cleanly against Linux v5.7 - last is what
I did.

There was a follow-up to the above patch (see [2]):

commit e4a42c82e943b97ce124539fcd7a47445b43fa0d
"kbuild: fix broken builds because of GZIP,BZIP2,LZOP variables"

Nevertheless, this is the kernel-side of doing - user-space like for
example Debian's initramfs-tools needs adaptations (see [3]).

@Kees: Can you aid Nick T. to get this upstream? You know the
processes a bit better than me.

Regards,
- Sedat -

[0] https://github.com/terrelln/linux/tree/zstd-v5
[0] https://lore.kernel.org/patchwork/project/lkml/list/?series=437934
[1] https://git.kernel.org/linus/8dfb61dcbaceb19a5ded5e9c9dcf8d05acc32294
[2] https://git.kernel.org/linus/e4a42c82e943b97ce124539fcd7a47445b43fa0d
[2] https://bugs.debian.org/955469