Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "tiwai@suse.de" <tiwai@suse.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        Support Opensource <Support.Opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used'
 warning
Thread-Topic: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used'
 warning
Thread-Index: AQHWT9TglCRPh6aF50mArntijWazBaj1l1Kw
Date:   Fri, 3 Jul 2020 09:33:06 +0000
Message-ID: <DB6PR1001MB1096535996028B7DE0D136DC806A0@DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM>
References: <20200701182422.81496-1-pierre-louis.bossart@linux.intel.com>
 <20200701182422.81496-5-pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20200701182422.81496-5-pierre-louis.bossart@linux.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.64]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 379ba017-6421-494b-ec74-08d81f341774
x-ms-traffictypediagnostic: DB8PR10MB3768:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DB8PR10MB3768C708CEF52F084651389FA76A0@DB8PR10MB3768.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:200;
x-forefront-prvs: 045315E1EE
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Wcyr+VA/mh7RjNH1rv+VoPU5FAOsLzV6gmXSZK5mW1DhByxvYAuruWbqvWALloIBWZdyI8LJLqmIC2vfl97L84yP8THDPjoSZaCas+EMaJF0k/I9Eg5wHS5a5eBx9MvYQ8xVYFS9vpu9aC2Hc6zzif8LXaFILSNfCgReIbimzcI5a8Y3QAondCg/F35ZBpFqHDwVleD+7riKrFnen7PFWwY8oZ7ZzApbd7e8zbxmubpPJEqT1AwKY8CF4B6flXe08noFjzDQVljdM8SRw9JRT+bc4ZTwRfkyhOwsmOmrMU51qohTuBA2sGlurCwZPM+c1PH24YdNI/OEnRIuVHPtOg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(86362001)(83380400001)(316002)(4326008)(55016002)(478600001)(9686003)(110136005)(33656002)(71200400001)(54906003)(26005)(8936002)(66476007)(7696005)(66946007)(66446008)(64756008)(66556008)(186003)(5660300002)(76116006)(2906002)(8676002)(52536014)(6506007)(53546011)(55236004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: VMmVviWtJ3R6R4fKWadIRAv/6x+1GzyhD6+6MatwpLhGPut3XpvWr8se80dUfYJiyMxfYAOER9AvVKBDZPFXfXGQk/n9qPtwysXIsNJyjy28zF9CulIYbli5woaN02/X2aY2uWVmm91ejChxc8E6qlQwe4T1mN0UBRPoTzieLIgKNBxlkyGZtcW8tBlr38IbZrmHxFNXKEkiCpjSG3eU0USosbb/qHI4hib5s/ro8BNpLcskKcRxon+qMLMi5BW+4V8ypJhTuDpTvnLEquyESlZ1PvJbOlzT9PUXiufLUnzbw/TPMDn1ZBqPQo3RxmreOitpwv5YMxyWzi08gFzs8idrmvY1fBs1gOd+x4/yUUo1kTCn/I6n6RI6yPHEwbVyZLtphGhF+COlYTcQKPlmxeVKd5OTwXlGxPO5DnUHZOjJDwvHTQNvfmFUOolZTG+T4HjjLy1hA4EY1ZZ8snz79jh/wdHqzOxXLNcsS7kG61A=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 379ba017-6421-494b-ec74-08d81f341774
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2020 09:33:06.3385
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qoYziLgV34Y2c7edlV0PbsveeSRUVB5bER2lMVYxyI0X1lunKX+MTnguBLfk05WP2W6f3qskd1xM1rNJSihWt6gHx4ujZlFoJIHbq+kWqv4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3768
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01 July 2020 19:24, Pierre-Louis Bossart wrote:

> fix W=3D1 warning
>=20
> sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> defined but not used [-Wunused-const-variable=3D]
>  1711 | static const struct acpi_device_id da7219_acpi_match[] =3D {
>       |                                    ^~~~~~~~~~~~~~~~~
>=20
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com=
>
> ---
>  sound/soc/codecs/da7219.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index f2520a6c7875..153ea30b5a8f 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_match[=
] =3D
> {
>  };
>  MODULE_DEVICE_TABLE(of, da7219_of_match);
>=20
> +#ifdef CONFIG_ACPI
>  static const struct acpi_device_id da7219_acpi_match[] =3D {
>  	{ .id =3D "DLGS7219", },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
> +#endif

I think this will break non-ACPI builds as this symbol is used in the
declaration of 'da7219_i2c_driver', without conditional compilation surroun=
ding
it. Unless of course I'm missing something. Could we instead use
'__maybe_unused' to avoid this warning?

>=20
>  static enum da7219_micbias_voltage
>  	da7219_fw_micbias_lvl(struct device *dev, u32 val)
> --
> 2.25.1