Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "tiwai@suse.de" <tiwai@suse.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        Support Opensource <Support.Opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used'
 warning
Thread-Topic: [PATCH 04/11] ASoC: codecs: da7219: fix 'defined but not used'
 warning
Thread-Index: AQHWT9TglCRPh6aF50mArntijWazBaj1l1KwgAAIcQA=
Date:   Fri, 3 Jul 2020 09:57:46 +0000
Message-ID: <DB6PR1001MB1096D4378397C76A4CFEAF28806A0@DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM>
References: <20200701182422.81496-1-pierre-louis.bossart@linux.intel.com>
 <20200701182422.81496-5-pierre-louis.bossart@linux.intel.com>
 <DB6PR1001MB1096535996028B7DE0D136DC806A0@DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM>
In-Reply-To: <DB6PR1001MB1096535996028B7DE0D136DC806A0@DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.64]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d6659de3-9f97-473d-cea9-08d81f3789bf
x-ms-traffictypediagnostic: DB6PR1001MB1144:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DB6PR1001MB11440485C077558648CCD16DA76A0@DB6PR1001MB1144.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:147;
x-forefront-prvs: 045315E1EE
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: XE5b8DO1/Yln1IXel+YK4uz5THtSk+9vZLkjiKZ9fcfg0uI3hKZg/9QkImlY/yX18K/10Ql+cI6kR+A/JPkK2kVRRMJ1pYY3FDbG25uNPWFCLlI58MLMdQd9smIyAUyAmh600RWzokzKiiZRXGWS50Spb33eVSgwgZmUKhf4cE4MOfsgbBlf6Jb8WEp498l/DKCu5yIDf+KgOduywmpLCyyvQSXGDZYpjJILZYKX0PAeVvpImHRFbli5FUnYN68OBaRs8k56Ut84K/QA9s92QDBEH6cf2C38Vc2xSNrscPmpKWLq7h5LHYYjStG2StyPwu1c0kSVA1nT8E+/625U3g==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(346002)(396003)(39860400002)(376002)(136003)(2940100002)(83380400001)(33656002)(52536014)(4326008)(55236004)(86362001)(26005)(6506007)(5660300002)(53546011)(7696005)(186003)(54906003)(8676002)(8936002)(110136005)(9686003)(71200400001)(478600001)(64756008)(55016002)(66446008)(2906002)(66476007)(76116006)(66556008)(316002)(66946007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: M7WeRRdt4tkPXyIvXIyTtu41PDfqMS7wYlS/D/CQcvp93WxBqEIyhihYSrzuCD+u+c2hsgRclG+GO1yYnjrvCXCtGMgDWfv87cves6yP7864GCJOiy/XtZigaDtVr9aLXDbpze5DFD47pwtnfifNI5YQDzW1Bc77Yc5BhMs2Kug4SJ+k8/ED55+X6wn0ywmbGJSA9cBSjxTUtE6Oc9gdP3eySeux/x+qEYyRZ0rMxFyGRvNSrTiiDaIzdvmE1zB32VO6XFoj/oJxTwsE8oLFNbo8QgZYfcwcfPleYL/KCOOZWb4B+HQxIj6uMoSSN7nYaI0dbh2gGawTWNhxFd/iPnFXc7s0vWMbzdw2b6mbixs5dT8Z5J2YGsjiCJvMti++7VZGjbhhq96plch7QgA8AZdF+89dL74j07C0QH/+g9t6z1xO+bRuAXzutW/3Zu2VWdoW8XiSalDfEvZ+1ZHpmB7Olq7dfy+N4szGjv29oVI=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB6PR1001MB1096.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: d6659de3-9f97-473d-cea9-08d81f3789bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2020 09:57:46.6526
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iN3bPhffLRutYkJwRh5m7B0lQLOvhlhNY2oN34mhcFq8Ic29jRJcPcAlM75GfKOzyv3nSMOw0oFFWWqKptnAQI8tfMJb9yh/FnCiEuFnMXs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR1001MB1144
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03 July 2020 10:33, Adam Thomson wrote

> On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
>=20
> > fix W=3D1 warning
> >
> > sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> > defined but not used [-Wunused-const-variable=3D]
> >  1711 | static const struct acpi_device_id da7219_acpi_match[] =3D {
> >       |                                    ^~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.c=
om>
> > ---
> >  sound/soc/codecs/da7219.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> > index f2520a6c7875..153ea30b5a8f 100644
> > --- a/sound/soc/codecs/da7219.c
> > +++ b/sound/soc/codecs/da7219.c
> > @@ -1708,11 +1708,13 @@ static const struct of_device_id da7219_of_matc=
h[]
> =3D
> > {
> >  };
> >  MODULE_DEVICE_TABLE(of, da7219_of_match);
> >
> > +#ifdef CONFIG_ACPI
> >  static const struct acpi_device_id da7219_acpi_match[] =3D {
> >  	{ .id =3D "DLGS7219", },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(acpi, da7219_acpi_match);
> > +#endif
>=20
> I think this will break non-ACPI builds as this symbol is used in the
> declaration of 'da7219_i2c_driver', without conditional compilation surro=
unding
> it. Unless of course I'm missing something. Could we instead use
> '__maybe_unused' to avoid this warning?

Obviously a slow start to the day for my brain. You've obviously built test=
 this
given the intention behind this is for non-ACPI builds. Will get more coffe=
e
shortly.

Still wonder if '__maybe_unused' might be nicer as per suspend/resume funct=
ions
on platforms which don't include PM_OPS. Either way though:

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

>=20
> >
> >  static enum da7219_micbias_voltage
> >  	da7219_fw_micbias_lvl(struct device *dev, u32 val)
> > --
> > 2.25.1