Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2211697ybt; Fri, 3 Jul 2020 03:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGDuolZOAwOXBFv7lq7V+NoyvlCnnkBEWFOgCnFTlLT3U+aXyWNg64QTsJ571xRjVJ9nik X-Received: by 2002:a50:d7c1:: with SMTP id m1mr40507979edj.217.1593773173341; Fri, 03 Jul 2020 03:46:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593773173; cv=none; d=google.com; s=arc-20160816; b=jcJXOnvZ9OVnpffV9AUxRqR2mYSJsL9fyPxsyw2WtTvcXphJfLtGeWA1ninEVGyNdo PWwoA1YK0La6xv6l9ZJSuKy9HpOqyNeNrx7C31Wcr3VE7xtlhQ0v/2/gn+tcB3Ad0hWm K/76N7cbjW5NYeGFL6Uxkg1vnU403alxila+NzZvoU7oqtorLaqBdnDYEg3yUdo/Wba+ op4XSx8t04DL8TMPs44AMpu79hpGHUDsjaooyB+/hjjVoKUrBXzif6l/kIgyQ1Qhz0/K p2GkNP7abD/wHcGwEnKwpWYHhE6aYOgsDlDYs+3Ffi9ZM+nhXSeRErRp6GXfWRIkBNLS MHrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:dkim-signature; bh=UTo/mWoBDP+SPDYXvZxFydz9bgU14dxIpLiFWz7ea8o=; b=RVCD8D281knjGPMLQ5BxtCK5LQIWMi+QQbyzwdZ/v4QgBovllEbTnpFb9u97DCzwaP SbOA8ObjyEN7aLXu6HldI0rLNShBqbij/mLzREiTzhrDDkv20rNy4vGcJwUzA6G4/7L9 Ky6kq2ucWLlFQWj5I9EfUGfUVAujdqjtHedmvwRfWDxbNdH8D/WoMhOILcNURb6i/0sI d58va415c4/upTGT/pYfnvyjR2mRG+NIik3b79wFkMT0IoTY2dRTzvuQboTWtDojdCPi yNB/WF9wMw0HBJrtsHf5q9FX+qHulCWr6xAZ+GJyiBWzx7UnpF16iMBntCr95yJTqE/y jzdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=bOsFxfpm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds10si9453804ejc.183.2020.07.03.03.45.49; Fri, 03 Jul 2020 03:46:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=bOsFxfpm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbgGCKow (ORCPT + 99 others); Fri, 3 Jul 2020 06:44:52 -0400 Received: from vps.xff.cz ([195.181.215.36]:40334 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbgGCKov (ORCPT ); Fri, 3 Jul 2020 06:44:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1593773088; bh=nrh0KH3J1yRnIENV/8zoqi7FGv+zeQdvh0IitngxK0Y=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=bOsFxfpm7+YVeVF6lMZ7ESyBG9Mwl6LGVE+CCno+DbO2ejqDClY6BUiSyoPu0TRYk Xa8+qSCWumhmlSTrd90JG6QCyWwxVOeP0KYLZVFFnmjy/fM6mfauaQF3X0jXFZQG+H FZw9vAu834beeDCk2qCS7l0BIkK+VRwyUrOKCbHM= Date: Fri, 3 Jul 2020 12:44:48 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Sam Ravnborg Cc: Rob Herring , David Airlie , Daniel Vetter , Guido =?utf-8?Q?G=C3=BCnther?= , linux-kernel@vger.kernel.org, Purism Kernel Team , Chen-Yu Tsai , Samuel Holland , devicetree@vger.kernel.org, Bhushan Shah , Thierry Reding , linux-sunxi@googlegroups.com, Luca Weiss , Martijn Braam , Icenowy Zheng , Maxime Ripard , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Linus Walleij , Rob Herring Subject: Re: [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml Message-ID: <20200703104448.iwhxk77d2hyrr3x5@core.my.home> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Sam Ravnborg , Rob Herring , David Airlie , Daniel Vetter , Guido =?utf-8?Q?G=C3=BCnther?= , linux-kernel@vger.kernel.org, Purism Kernel Team , Chen-Yu Tsai , Samuel Holland , devicetree@vger.kernel.org, Bhushan Shah , Thierry Reding , linux-sunxi@googlegroups.com, Luca Weiss , Martijn Braam , Icenowy Zheng , Maxime Ripard , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Linus Walleij , Rob Herring References: <20200701162928.1638874-1-megous@megous.com> <20200701162928.1638874-3-megous@megous.com> <20200702205143.GA1670522@bogus> <20200702210354.562wkzpdmyrlwojx@core.my.home> <20200703051155.GA1685118@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200703051155.GA1685118@ravnborg.org> X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sam, On Fri, Jul 03, 2020 at 07:11:55AM +0200, Sam Ravnborg wrote: > Hi Ondrej. > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property > > > > Paths look bogus ^^^^ > > > > It should be .../rocktech,jh057n00900.yaml: ... > > The example in nwl-dsi.yaml contains: > compatible = "rocktech,jh057n00900"; > > So the example is checked against your updated binding. > And the binding check fails because the example is no longer valid. Ah, now I understand. > This needs to be fixed as we do not wat to introduce new errors. > Either the example or the binding needs the fix. I think we can unrequire the supplies, but reset is needed really. The panel only has one port, so there should be no address/size-cells in the example, and port@0 should be just port to match existing binding. If it had multiple ports, port@0 would have to be inside ports { } node anyway, according to the existing binding. Then add reset-gpios to the example... And that should fix it. I'll prepare the patch shortly. regards, o. > Sam > > > > > > regards, > > o. > > > > > > > > See https://patchwork.ozlabs.org/patch/1320690 > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure dt-schema is up to date: > > > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > Please check and re-submit. > > >