Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the
 features
To:     Chanwoo Choi <cw00.choi@samsung.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     leonard.crestez@nxp.com, lukasz.luba@arm.com,
        enric.balletbo@collabora.com, hl@rock-chips.com,
        thierry.reding@gmail.com, jonathanh@nvidia.com, abel.vesa@nxp.com,
        chanwoo@kernel.org, myungjoo.ham@samsung.com,
        kyungmin.park@samsung.com
References: <20200703100810.12304-1-cw00.choi@samsung.com>
 <CGME20200703095657epcas1p187b7f90a4a33da7791a83a78760f3a91@epcas1p1.samsung.com>
 <20200703100810.12304-3-cw00.choi@samsung.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com>
Date:   Fri, 3 Jul 2020 13:46:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200703100810.12304-3-cw00.choi@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

03.07.2020 13:08, Chanwoo Choi пишет:
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index e94a27804c20..620ecd250d7c 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>  
>  static struct devfreq_governor tegra_devfreq_governor = {
>  	.name = "tegra_actmon",
> +	.flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> +		| DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,

Hello, Chanwoo!

There is a typo here, it should be ".attr = ".

> +	.flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> +		| DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,

There is a typo here too FLAG_FLAG ^

>  	.get_target_freq = tegra_governor_get_target,
>  	.event_handler = tegra_governor_event_handler,
> -	.immutable = true,
> -	.interrupt_driven = true,
>  };
>