Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2227665ybt;
        Fri, 3 Jul 2020 04:12:03 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw61gsvrYnXC8j+6UbG4sha3xRPm5BLleseUpe+R3GlgC9YtEejm92PC68n7GFHUcY53LR9
X-Received: by 2002:a17:906:57c6:: with SMTP id u6mr31005565ejr.194.1593774722981;
        Fri, 03 Jul 2020 04:12:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1593774722; cv=none;
        d=google.com; s=arc-20160816;
        b=Imr3t+9SiBwk1Y9O2fw7MGkS1pwebsytpNtbj5tG1ki0EusvJ5PBnHbUqbykABKaE8
         hlJls0nlS0/9KC262R69OxpgtWUKCXjJCh+Q8xqPrxeJp8zPyRJac7+D2bMF53nNwEU4
         YsCm9TQ8CJMYE9g+hLCexoSk4ppQTrmjUmhnd0azh+KxUNEbZ18qbnGfcDPH/LchjHEH
         csMtyDDU7VX3eEROpivaylnewRb3tAPh9bUv2/jXWoZpnd7X4V/yywZY5muQg2FBD0bD
         rIQoul62YLNjihtolcgkkYeSnuFQDCZCrbfj7QzWN74w3We+zjzqtnhPvYgXm7lJa845
         l4kg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=/Sp0XcdBK63PQZ1UBbjypcJDY9tsB8M2xhGGknJRg0k=;
        b=SKBvJLDvyMdohydZ/tXboz6JdVUF+bcW0PaC2NAD/6DG20aoJzfINfojLDIlwDpdB7
         fWgWB32Ud5jQMxNUpbG344g59yqbb3X4KEwcrAkVUEQbFbZG5toSgM/1/nEc+NrE+s4h
         NUebKmygLx9sC4TkyJikUPcaqZV8JI7rPqP65oHzCVyo9LuUQoXyjfWbea7XdH5b3aWJ
         R5E6hijBkYC2S9ZvMZ1mhocYmsQhcPBOdRjLtPKW3HUaszlCNxfPwT6tDiJeagj6TvZS
         4JRZHy4Ft/5Fxnuiui3CD3GgwRUwj/gt8pP0S23162ik7ouTnXeUnvqKW9FDCH2mlEmN
         2xEQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n24si7515673edt.561.2020.07.03.04.11.39;
        Fri, 03 Jul 2020 04:12:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726286AbgGCLLQ (ORCPT <rfc822;jaysonjohndmello@gmail.com>
        + 99 others); Fri, 3 Jul 2020 07:11:16 -0400
Received: from mx2.suse.de ([195.135.220.15]:54744 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725984AbgGCLLQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Jul 2020 07:11:16 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 55C19AEA7;
        Fri,  3 Jul 2020 11:11:14 +0000 (UTC)
Date:   Fri, 3 Jul 2020 13:11:13 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     qiang.zhang@windriver.com
Cc:     ben.dooks@codethink.co.uk, bfields@redhat.com, cl@rock-chips.com,
        peterz@infradead.org, tj@kernel.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] kthread: work could not be queued when worker being
 destroyed
Message-ID: <20200703111113.GG14288@alley>
References: <20200702070156.5862-1-qiang.zhang@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200702070156.5862-1-qiang.zhang@windriver.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 2020-07-02 15:01:56, qiang.zhang@windriver.com wrote:
> From: Zhang Qiang <qiang.zhang@windriver.com>
> 
> The "queuing_blocked" func should print warning message and
> returns true when the worker being destroyed.
>
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>

Looks good to me.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Adding Andrew into CC. Changes in kernel/kthread.c usually goes
through him. You might need to resend the patch once again
with Andrew in CC.

Best Regards,
Petr Mladek