Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2228979ybt; Fri, 3 Jul 2020 04:14:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiJuk6W1jdIIVBWtenx/f+ktO3/6tAkYdtcrv2zPuz/EFqjepSVvbZcOA4v7A2pfIGfh0D X-Received: by 2002:a05:6402:21d3:: with SMTP id bi19mr40608102edb.56.1593774841710; Fri, 03 Jul 2020 04:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593774841; cv=none; d=google.com; s=arc-20160816; b=WAfKQdagjvTpnLtMjKKJVR23lwj4g0OQ6XLYVLk4itunBGqoYjlBn9QiBrtWsy0EVc zxBR/671pMf2bPOjReBpX5BXERCa8cs23hxCf16kd4/tXyThD34k8s35W4d+WRKfDnyF h2liTrPN1huwP+cUI3X13F4VpcF7kH6U2ff9lEFGdJEPbNfeaZGlF+0Jke7cv8znmAs2 V87xaa4wH6Qd9qpyAf1mZj8alur2cN6W6w832JUH9UBgSDMKPgXzNGnXzA58FgtA2gku TUNDCf+R4T+FUgDhQcmlted6tu//NJ2oHyPQamz8AfyCYiTxstuMyK3EG9mTgNb6z8KJ 8nOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:to:from :date:dkim-signature; bh=091WStVMKcgtFyWfUpvXfLU6rQ4MDDelmZ8O8TC7STQ=; b=qjDVaaEAJBaQI+IsUFxRK2GTkxCOlJIA1QiVM+enq5/FWgjFxBnmEfuXNWTDuIoEhp vCaakQxjqWO0fEhkMuqut33OPPHZSQAMiS2JF++6dS73RhH0qDCICsJKhMvNIOE8LL4d xXPulc4Ej8Ni33ufebe1saGYjJdq7mWMRCEQHZ4NUP34oATMQlFfTu48ebyOaQBurhZp Q7mZwpzGvk4Wdwt3Rey9T6sPv/NncoHn4wzpQebh6OYLwnnZvYeeVD6ezW38ZYtAxkj3 u50ZX0jMrZBMV0vgYkjJrXX4FL4CCVPXEnaJWjUmL52TgXwBlTgah/Du1ny3YeAJflHa JckA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=S7oWV+eP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si7943203ejb.397.2020.07.03.04.13.38; Fri, 03 Jul 2020 04:14:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=S7oWV+eP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbgGCLN3 (ORCPT + 99 others); Fri, 3 Jul 2020 07:13:29 -0400 Received: from vps.xff.cz ([195.181.215.36]:40748 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgGCLN0 (ORCPT ); Fri, 3 Jul 2020 07:13:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1593774803; bh=PK9XQwVLZikvPIqIQvVj+rgD6Y+uR8PxJm+ULrZzNEY=; h=Date:From:To:Subject:References:X-My-GPG-KeyId:From; b=S7oWV+ePVh3bfJXlbi+307IscRv04ljcgUCHfqikI/1D//XWGqaz4mN46BGZAazVj 5bdCe0vCNFUu1n/lHJ7onleN+X9HghCqqMprndSR8s+JCw/aKbIpo8LQ8SKVK0q3vR b1gDz1xB4J3mN4HoEExzY3QakP/cqkk5MQuGnFsE= Date: Fri, 3 Jul 2020 13:13:23 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Sam Ravnborg , Rob Herring , David Airlie , Daniel Vetter , Guido =?utf-8?Q?G=C3=BCnther?= , linux-kernel@vger.kernel.org, Purism Kernel Team , Chen-Yu Tsai , Samuel Holland , devicetree@vger.kernel.org, Bhushan Shah , Thierry Reding , linux-sunxi@googlegroups.com, Luca Weiss , Martijn Braam , Icenowy Zheng , Maxime Ripard , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Linus Walleij , Rob Herring Subject: Re: [PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml Message-ID: <20200703111323.zcmv3cuo7toa4d3g@core.my.home> Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Sam Ravnborg , Rob Herring , David Airlie , Daniel Vetter , Guido =?utf-8?Q?G=C3=BCnther?= , linux-kernel@vger.kernel.org, Purism Kernel Team , Chen-Yu Tsai , Samuel Holland , devicetree@vger.kernel.org, Bhushan Shah , Thierry Reding , linux-sunxi@googlegroups.com, Luca Weiss , Martijn Braam , Icenowy Zheng , Maxime Ripard , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Linus Walleij , Rob Herring References: <20200701162928.1638874-1-megous@megous.com> <20200701162928.1638874-3-megous@megous.com> <20200702205143.GA1670522@bogus> <20200702210354.562wkzpdmyrlwojx@core.my.home> <20200703051155.GA1685118@ravnborg.org> <20200703104448.iwhxk77d2hyrr3x5@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200703104448.iwhxk77d2hyrr3x5@core.my.home> X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 03, 2020 at 12:44:48PM +0200, megous hlavni wrote: > Hello Sam, > > On Fri, Jul 03, 2020 at 07:11:55AM +0200, Sam Ravnborg wrote: > > Hi Ondrej. > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property > > > > > > Paths look bogus ^^^^ > > > > > > It should be .../rocktech,jh057n00900.yaml: ... > > > > The example in nwl-dsi.yaml contains: > > compatible = "rocktech,jh057n00900"; > > > > So the example is checked against your updated binding. > > And the binding check fails because the example is no longer valid. > > Ah, now I understand. > > > This needs to be fixed as we do not wat to introduce new errors. > > Either the example or the binding needs the fix. > > I think we can unrequire the supplies, but reset is needed really. Hmm, that's probably wrong kind of thinking. Panel has the supplies, and obviously requires them, so the dts must describe them somehow, even if they are the fixed supplies. So I'll not unrequire them. > The panel only has one port, so there should be no address/size-cells > in the example, and port@0 should be just port to match existing binding. > If it had multiple ports, port@0 would have to be inside ports { } node > anyway, according to the existing binding. Then add reset-gpios to > the example... > > And that should fix it. > > I'll prepare the patch shortly. > > regards, > o. > > > Sam > > > > > > > > > > regards, > > > o. > > > > > > > > > > > See https://patchwork.ozlabs.org/patch/1320690 > > > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > > error(s), then make sure dt-schema is up to date: > > > > > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > > > Please check and re-submit. > > > >