Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 3 Jul 2020 14:17:06 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Ondrej Jirman <megous@megous.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Icenowy Zheng <icenowy@aosc.io>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Samuel Holland <samuel@sholland.org>,
        Martijn Braam <martijn@brixit.nl>, Luca Weiss <luca@z3ntu.xyz>,
        Bhushan Shah <bshah@kde.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen
 support
Message-ID: <20200703121706.gf2yxfe7crleatlm@gilmour.lan>
References: <20200702081432.1727696-1-megous@megous.com>
 <20200702081432.1727696-3-megous@megous.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cxgywaqrrd6jmrsp"
Content-Disposition: inline
In-Reply-To: <20200702081432.1727696-3-megous@megous.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--cxgywaqrrd6jmrsp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote:
> Pinephone has a Goodix GT917S capacitive touchscreen controller on
> I2C0 bus. Add support for it.
>=20
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/ar=
ch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index a89425ad3727..5c7386566053 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -121,6 +121,25 @@ &ehci1 {
>  	status =3D "okay";
>  };
> =20
> +&i2c0 {
> +	pinctrl-names =3D "default";
> +	pinctrl-0 =3D <&i2c0_pins>;
> +	status =3D "okay";

I didn't spot this earlier, but the pinctrl properties are already set
in the DTSI. I've removed them while applying the patch.

Thanks!
Maxime

--cxgywaqrrd6jmrsp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXv8hwQAKCRDj7w1vZxhR
xZHoAQDeaPm5c6iWX8CcvBcL8Vrae7EAun13r2RrsQbElBt06AD/RGPN7dt9hGp8
nvnWM3MC/4nwVVPKFdGRLOiTy6Tg1AI=
=+CVs
-----END PGP SIGNATURE-----

--cxgywaqrrd6jmrsp--